Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348546 > unrolled thread

[PATCH 00/27] Third batch of LNet fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/27] Third batch of LNet fixes James Simmons <jsimmons@infradead.org> - 2016-03-02 23:10 +0100
    [PATCH 09/27] staging: lustre: set task state before scheduling in lnet_sock_accept James Simmons <jsimmons@infradead.org> - 2016-03-02 23:10 +0100
    [PATCH 05/27] staging: lustre: remove annoying message in parse_nidrange James Simmons <jsimmons@infradead.org> - 2016-03-02 23:10 +0100
    Re: [PATCH 00/27] Third batch of LNet fixes Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-03 00:30 +0100
      RE: [lustre-devel] [PATCH 00/27] Third batch of LNet fixes "Simmons, James A." <simmonsja@ornl.gov> - 2016-03-03 01:00 +0100

#1348546 — [PATCH 00/27] Third batch of LNet fixes

This patch set merges all the fixes for the klnd drivers, socklnd and
o2iblnd, to what is currently used in production environments. Several
more fixes for the LNet core are also included with this patch set.

Alyona Romanenko (1):
  staging: lustre: issue in the offset in lnet match hash table

Amir Shehata (3):
  staging: lustre: change ibh_mrs from array to pointer
  staging: lustre: make ko2iblnd connect parameters persistent
  staging: lustre: Ignore hops if not explicitly set

Dmitry Eremin (4):
  staging: lustre: fix socklnd issues found by Klocwork Insight tool
  staging: lustre: fix api-ni.c issues found by Klocwork Insight tool
  staging: lustre: fix conctl.c issues found by Klocwork Insight tool
  staging: lustre: fix framework.c issues found by Klocwork Insight tool

Doug Oucharek (1):
  staging: lustre: Change connect peer failed cleanup order

Frank Zago (3):
  staging: lustre: make o2iblnd local functions static
  staging: lustre: make o2iblnd_cb.c local functions static
  staging: lustre: corrected some typos and grammar errors

James Simmons (3):
  staging: lustre: return proper error code for LNet core
  staging: lustre: bind socklnd peers to a specific CPT
  staging: lustre: reverse LNet and infinband header order

Jeremy Filizetti (1):
  staging: lustre: Support different ko2iblnd configs between systems

Jian Yu (1):
  staging: lustre: replace direct LNet HZ access with kernel APIs

John L. Hammond (1):
  staging: lustre: set task state before scheduling in lnet_sock_accept

Li Xi (1):
  staging: lustre: remove annoying message in parse_nidrange

Liang Zhen (6):
  staging: lustre: set downis to 1 if there's no NI for remote net
  staging: lustre: recv could access freed message
  staging: lustre: take extra refcount in kiblnd_connreq_done
  staging: lustre: check wr_id returned by ib_poll_cq
  staging: lustre: avoid intensive reconnecting for ko2iblnd
  staging: lustre: do less intense allocating retry for ko2iblnd

Olaf Weber (1):
  staging: lustre: Use after free in lnet_ptl_match_delay()

Sebastien Buisson (1):
  staging: lustre: fix 'copy into fixed size buffer' errors

 .../staging/lustre/include/linux/lnet/lib-lnet.h   |    2 +-
 .../staging/lustre/include/linux/lnet/lib-types.h  |    2 +-
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |  230 ++++------
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h    |  135 ++++---
 .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |  475 ++++++++++++++------
 .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |    7 +-
 drivers/staging/lustre/lnet/lnet/api-ni.c          |    8 +-
 drivers/staging/lustre/lnet/lnet/config.c          |   14 +-
 drivers/staging/lustre/lnet/lnet/lib-eq.c          |    2 +-
 drivers/staging/lustre/lnet/lnet/lib-move.c        |   51 ++-
 drivers/staging/lustre/lnet/lnet/lib-ptl.c         |   93 +++--
 drivers/staging/lustre/lnet/lnet/lib-socket.c      |   45 +-
 drivers/staging/lustre/lnet/lnet/nidstrings.c      |    3 +-
 drivers/staging/lustre/lnet/lnet/router.c          |   22 +-
 drivers/staging/lustre/lnet/lnet/router_proc.c     |    2 +-
 drivers/staging/lustre/lnet/selftest/conctl.c      |    9 +-
 drivers/staging/lustre/lnet/selftest/conrpc.c      |    2 +-
 drivers/staging/lustre/lnet/selftest/console.c     |   23 +-
 drivers/staging/lustre/lnet/selftest/framework.c   |   14 +-
 drivers/staging/lustre/lustre/libcfs/workitem.c    |    6 +-
 drivers/staging/lustre/lustre/llite/dir.c          |    6 +-
 drivers/staging/lustre/lustre/obdclass/lu_object.c |    2 +-
 drivers/staging/lustre/lustre/ptlrpc/import.c      |    2 +-
 drivers/staging/lustre/lustre/ptlrpc/nrs.c         |    8 +-
 drivers/staging/lustre/lustre/ptlrpc/sec_config.c  |    7 +-
 25 files changed, 715 insertions(+), 455 deletions(-)

[toc] | [next] | [standalone]

#1348547 — [PATCH 09/27] staging: lustre: set task state before scheduling in lnet_sock_accept

From: John L. Hammond <john.hammond@intel.com>

In the original code change when libcfs_sock_accept() was made
into lnet_sock_accept() a call to set_current_state(TASK_INTERRUPTIBLE)
got dropped which was restored. For upstream this is an
optimization of calling init_waitqueue_entry() only if
accept() return -EAGAIN. Also we can remove setting the
task to TASK_RUNNING that is not needed.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6407
Reviewed-on: http://review.whamcloud.com/14265
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Amir Shehata <amir.shehata@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
---
 drivers/staging/lustre/lnet/lnet/lib-socket.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers/staging/lustre/lnet/lnet/lib-socket.c
index 5d77049..269a6d8 100644
--- a/drivers/staging/lustre/lnet/lnet/lib-socket.c
+++ b/drivers/staging/lustre/lnet/lnet/lib-socket.c
@@ -531,8 +531,6 @@ lnet_sock_accept(struct socket **newsockp, struct socket *sock)
 	struct socket *newsock;
 	int rc;
 
-	init_waitqueue_entry(&wait, current);
-
 	/*
 	 * XXX this should add a ref to sock->ops->owner, if
 	 * TCP could be a module
@@ -548,11 +546,11 @@ lnet_sock_accept(struct socket **newsockp, struct socket *sock)
 	rc = sock->ops->accept(sock, newsock, O_NONBLOCK);
 	if (rc == -EAGAIN) {
 		/* Nothing ready, so wait for activity */
-		set_current_state(TASK_INTERRUPTIBLE);
+		init_waitqueue_entry(&wait, current);
 		add_wait_queue(sk_sleep(sock->sk), &wait);
+		set_current_state(TASK_INTERRUPTIBLE);
 		schedule();
 		remove_wait_queue(sk_sleep(sock->sk), &wait);
-		set_current_state(TASK_RUNNING);
 		rc = sock->ops->accept(sock, newsock, O_NONBLOCK);
 	}
 
-- 
1.7.1

[toc] | [prev] | [next] | [standalone]

#1348550 — [PATCH 05/27] staging: lustre: remove annoying message in parse_nidrange

From: Li Xi <lixi@ddn.com>

When setting TBF rules of jobid, parse_nidrange() prints warning
messages. However, this is unnecessary and annoying since paring
a TBF rule will always try to parse the jobid like a nid.

Signed-off-by: Li Xi <lixi@ddn.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7647
Reviewed-on: http://review.whamcloud.com/17916
Reviewed-by: Emoly Liu <emoly.liu@intel.com>
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
---
 drivers/staging/lustre/lnet/lnet/nidstrings.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c b/drivers/staging/lustre/lnet/lnet/nidstrings.c
index 9d1c7fd..ebf468f 100644
--- a/drivers/staging/lustre/lnet/lnet/nidstrings.c
+++ b/drivers/staging/lustre/lnet/lnet/nidstrings.c
@@ -270,7 +270,6 @@ parse_nidrange(struct cfs_lstr *src, struct list_head *nidlist)
 
 	return 1;
 failed:
-	CWARN("can't parse nidrange: \"%.*s\"\n", tmp.ls_len, tmp.ls_str);
 	return 0;
 }
 
-- 
1.7.1

[toc] | [prev] | [next] | [standalone]

#1348605

On Wed, Mar 02, 2016 at 05:01:43PM -0500, James Simmons wrote:
> This patch set merges all the fixes for the klnd drivers, socklnd and
> o2iblnd, to what is currently used in production environments. Several
> more fixes for the LNet core are also included with this patch set.

I've applied the first 20, I never got patch 21 in the series, so please
rebase and resend the remaining ones, properly numbered :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1348628 — RE: [lustre-devel] [PATCH 00/27] Third batch of LNet fixes

>On Wed, Mar 02, 2016 at 05:01:43PM -0500, James Simmons wrote:
>> This patch set merges all the fixes for the klnd drivers, socklnd and
>> o2iblnd, to what is currently used in production environments. Several
>> more fixes for the LNet core are also included with this patch set.
>
>I've applied the first 20, I never got patch 21 in the series, so please
>rebase and resend the remaining ones, properly numbered :)
>
>thanks,

Okay. I will send the remaining patches as a new patch series.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web