Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348435 > unrolled thread

[PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits Gustavo Padovan <gustavo@padovan.org> - 2016-03-02 21:00 +0100
    Re: [PATCH v6 4/6] staging/android: align struct sync_merge_data to  a multiple of 64-bits Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-03-02 22:50 +0100

#1348435 — [PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Change order of the field to avoid alignment issues with 64 bits
platforms.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/staging/android/uapi/sync.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
index f0b41ce..a6c648c 100644
--- a/drivers/staging/android/uapi/sync.h
+++ b/drivers/staging/android/uapi/sync.h
@@ -16,13 +16,13 @@
 
 /**
  * struct sync_merge_data - data passed to merge ioctl
- * @fd2:	file descriptor of second fence
  * @name:	name of new fence
+ * @fd2:	file descriptor of second fence
  * @fence:	returns the fd of the new fence to userspace
  */
 struct sync_merge_data {
-	__s32	fd2;
 	char	name[32];
+	__s32	fd2;
 	__s32	fence;
 };
 
-- 
2.5.0

[toc] | [next] | [standalone]

#1348491 — Re: [PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits

2016-03-02 Gustavo Padovan <gustavo@padovan.org>:

> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Change order of the field to avoid alignment issues with 64 bits
> platforms.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
>  drivers/staging/android/uapi/sync.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please ignore this patch, it is not really needed.

	Gustavo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web