Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348404 > unrolled thread
| Started by | Joe Perches <joe@perches.com> |
|---|---|
| First post | 2016-03-02 20:00 +0100 |
| Last post | 2016-03-03 13:30 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn Joe Perches <joe@perches.com> - 2016-03-02 20:00 +0100
Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn Richard Weinberger <richard@nod.at> - 2016-03-02 22:30 +0100
Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn Joe Perches <joe@perches.com> - 2016-03-02 22:40 +0100
Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn Artem Bityutskiy <dedekind1@gmail.com> - 2016-03-03 09:50 +0100
Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn Joe Perches <joe@perches.com> - 2016-03-03 13:30 +0100
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-02 20:00 +0100 |
| Subject | Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn |
| Message-ID | <r8ka5-3CZ-1@gated-at.bofh.it> |
On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: > Am 02.03.2016 7:19 nachm. schrieb Joe Perches <joe@perches.com>: > > On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: > > > The existing logging macros are fairly large and converting the > > > macros to functions make the object code smaller. > > Artem and Adrian are the nominal maintainers for ubifs. > > > > Artem last had a sign-off on a ubifs patch 6 months ago and > > Adrian's last one was over 3 years ago. > > > > Is there an expected ack/nack/applied handling time for a > > ubifs patch like this? > > > > Should this patch go to someone else? > > > > Should the MAINTAINERS entry for ubifs be changed to orphan? > No need to panic. I take care of the patch. :) No worries, I'm calm. But if you're taking care of the patch and not the nominal maintainers, likely the MAINTAINERS entry should be updated. Presumably the equivalent ubi patch will be handled in the same fashion, For drivers/mtd/ubi, Artem is also a nominal maintainer, but last signed a patch in 2014. Likely the MAINTAINERS entry for UBI should be updated too. Maybe something like: --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81302e4..927557c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11266,8 +11266,7 @@ S: Maintained F: drivers/scsi/u14-34f.c UBI FILE SYSTEM (UBIFS) -M: Artem Bityutskiy <dedekind1@gmail.com> -M: Adrian Hunter <adrian.hunter@intel.com> +M: Richard Weinberger <richard@nod.at> L: linux-mtd@lists.infradead.org T: git git://git.infradead.org/ubifs-2.6.git W: http://www.linux-mtd.infradead.org/doc/ubifs.html @@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt F: drivers/scsi/ufs/ UNSORTED BLOCK IMAGES (UBI) -M: Artem Bityutskiy <dedekind1@gmail.com> M: Richard Weinberger <richard@nod.at> W: http://www.linux-mtd.infradead.org/ L: linux-mtd@lists.infradead.org
[toc] | [next] | [standalone]
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Date | 2016-03-02 22:30 +0100 |
| Subject | Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn |
| Message-ID | <r8mvh-5nK-5@gated-at.bofh.it> |
| In reply to | #1348404 |
Joe, Am 02.03.2016 um 19:58 schrieb Joe Perches: > On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: >> Am 02.03.2016 7:19 nachm. schrieb Joe Perches <joe@perches.com>: >>> On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: >>>> The existing logging macros are fairly large and converting the >>>> macros to functions make the object code smaller. >>> Artem and Adrian are the nominal maintainers for ubifs. >>> >>> Artem last had a sign-off on a ubifs patch 6 months ago and >>> Adrian's last one was over 3 years ago. >>> >>> Is there an expected ack/nack/applied handling time for a >>> ubifs patch like this? >>> >>> Should this patch go to someone else? >>> >>> Should the MAINTAINERS entry for ubifs be changed to orphan? >> No need to panic. I take care of the patch. :) > > No worries, I'm calm. But if you're taking care of the patch > and not the nominal maintainers, likely the MAINTAINERS entry > should be updated. > > Presumably the equivalent ubi patch will be handled in the > same fashion, > > For drivers/mtd/ubi, Artem is also a nominal maintainer, but > last signed a patch in 2014. > > Likely the MAINTAINERS entry for UBI should be updated too. > > Maybe something like: > --- > MAINTAINERS | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 81302e4..927557c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11266,8 +11266,7 @@ S: Maintained > F: drivers/scsi/u14-34f.c > > UBI FILE SYSTEM (UBIFS) > -M: Artem Bityutskiy <dedekind1@gmail.com> > -M: Adrian Hunter <adrian.hunter@intel.com> > +M: Richard Weinberger <richard@nod.at> I can be the official patch monkey for UBIFS. Especial as the git tree is the same as for UBI. But I definitely want to keep Artem. He gives very valuable input and knows UBIFS much better than I do. > L: linux-mtd@lists.infradead.org > T: git git://git.infradead.org/ubifs-2.6.git > W: http://www.linux-mtd.infradead.org/doc/ubifs.html > @@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt > F: drivers/scsi/ufs/ > > UNSORTED BLOCK IMAGES (UBI) > -M: Artem Bityutskiy <dedekind1@gmail.com> > M: Richard Weinberger <richard@nod.at> > W: http://www.linux-mtd.infradead.org/ > L: linux-mtd@lists.infradead.org Same here. Artem has to stay. Thanks, //richard
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-02 22:40 +0100 |
| Message-ID | <r8mEW-5rx-1@gated-at.bofh.it> |
| In reply to | #1348480 |
On Wed, 2016-03-02 at 22:24 +0100, Richard Weinberger wrote: > Am 02.03.2016 um 19:58 schrieb Joe Perches: [] > > For drivers/mtd/ubi, Artem is also a nominal maintainer, but > > last signed a patch in 2014. > > > > Likely the MAINTAINERS entry for UBI should be updated too. > > > > Maybe something like: [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -11266,8 +11266,7 @@ S: Maintained > > F: drivers/scsi/u14-34f.c > > > > UBI FILE SYSTEM (UBIFS) > > -M: Artem Bityutskiy <dedekind1@gmail.com> > > -M: Adrian Hunter <adrian.hunter@intel.com> > > +M: Richard Weinberger <richard@nod.at> > I can be the official patch monkey for UBIFS. > Especial as the git tree is the same as for UBI. > > But I definitely want to keep Artem. > He gives very valuable input and knows UBIFS much better than I do. That's fine and it's your (and his) choice what do to. > > L: linux-mtd@lists.infradead.org > > T: git git://git.infradead.org/ubifs-2.6.git > > W: http://www.linux-mtd.infradead.org/doc/ubifs.html > > @@ -11350,7 +11349,6 @@ F: Documentation/scsi/ufs.txt > > F: drivers/scsi/ufs/ > > > > UNSORTED BLOCK IMAGES (UBI) > > -M: Artem Bityutskiy <dedekind1@gmail.com> > > M: Richard Weinberger <richard@nod.at> > > W: http://www.linux-mtd.infradead.org/ > > L: linux-mtd@lists.infradead.org > Same here. Artem has to stay. Perhaps an "R:" (reviewer) entry is appropriate for Artem.
[toc] | [prev] | [next] | [standalone]
| From | Artem Bityutskiy <dedekind1@gmail.com> |
|---|---|
| Date | 2016-03-03 09:50 +0100 |
| Message-ID | <r8x7k-4p8-15@gated-at.bofh.it> |
| In reply to | #1348404 |
On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: > > UBI FILE SYSTEM (UBIFS) > -M: Artem Bityutskiy <dedekind1@gmail.com> > -M: Adrian Hunter <adrian.hunter@intel.com> > +M: Richard Weinberger <richard@nod.at> > L: linux-mtd@lists.infradead.org > T: git git://git.infradead.org/ubifs-2.6.git > W: http://www.linux-mtd.infradead.org/doc/ubifs.html Hi Joe, could please, re-send this patch with the following modifications: 1. Put Richard's name first. 2. Do not remove mine and Adrian's name. We are not very active, but still useful. Thanks!
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-03 13:30 +0100 |
| Message-ID | <r8Aye-745-15@gated-at.bofh.it> |
| In reply to | #1348913 |
On Thu, 2016-03-03 at 10:39 +0200, Artem Bityutskiy wrote: > On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: > > > > > > UBI FILE SYSTEM (UBIFS) > > -M: Artem Bityutskiy <dedekind1@gmail.com> > > -M: Adrian Hunter <adrian.hunter@intel.com> > > +M: Richard Weinberger <richard@nod.at> > > L: linux-mtd@lists.infradead.org > > T: git git://git.infradead.org/ubifs-2.6.git > > W: http://www.linux-mtd.infradead.org/doc/ubifs.html > Hi Joe, > > could please, re-send this patch with the following modifications: > > 1. Put Richard's name first. > 2. Do not remove mine and Adrian's name. We are not very active, but > still useful. > > Thanks! Hello Artem. It's not really for me to change Richard's maintainership. It should be his sign-off, not mine. My suggestion would be to add him and designate you and Adrian as R: reviewers instead of M: maintainers like below. --- MAINTAINERS | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81302e4..61e17a6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11266,8 +11266,9 @@ S: Maintained F: drivers/scsi/u14-34f.c UBI FILE SYSTEM (UBIFS) -M: Artem Bityutskiy <dedekind1@gmail.com> -M: Adrian Hunter <adrian.hunter@intel.com> +M: Richard Weinberger <richard@nod.at> +R: Artem Bityutskiy <dedekind1@gmail.com> +R: Adrian Hunter <adrian.hunter@intel.com> L: linux-mtd@lists.infradead.org T: git git://git.infradead.org/ubifs-2.6.git W: http://www.linux-mtd.infradead.org/doc/ubifs.html @@ -11350,8 +11351,8 @@ F: Documentation/scsi/ufs.txt F: drivers/scsi/ufs/ UNSORTED BLOCK IMAGES (UBI) -M: Artem Bityutskiy <dedekind1@gmail.com> M: Richard Weinberger <richard@nod.at> +R: Artem Bityutskiy <dedekind1@gmail.com> W: http://www.linux-mtd.infradead.org/ L: linux-mtd@lists.infradead.org T: git git://git.infradead.org/ubifs-2.6.git
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web