Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1348199 > unrolled thread

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Started byTejun Heo <tj@kernel.org>
First post2016-03-02 16:50 +0100
Last post2016-03-03 10:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: net/bluetooth: workqueue destruction WARNING in  hci_unregister_dev Tejun Heo <tj@kernel.org> - 2016-03-02 16:50 +0100
    Re: net/bluetooth: workqueue destruction WARNING in  hci_unregister_dev Jiri Slaby <jslaby@suse.cz> - 2016-03-03 10:20 +0100

#1348199 — Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

FromTejun Heo <tj@kernel.org>
Date2016-03-02 16:50 +0100
SubjectRe: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev
Message-ID<r8hcf-1c4-37@gated-at.bofh.it>
Hello, Jiri.

On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote:
> > 1. didn't help, the problem persists. So I haven't applied the patch from 2.
> 
> FWIW I dumped more info about the wq:
> wq->name='hci0' pwq=ffff8800390d7600 wq->dfl_pwq=ffff8800390d5200
> pwq->refcnt=2 pwq->nr_active=0 delayed_works: <nothing>

Can you please print out the same info for all pwq's during shutdown?
It looks like we're leaking pwq refcnt but I can't spot a place where
that could happen on an empty pwq.

Thanks.

-- 
tejun

[toc] | [next] | [standalone]


#1348923

FromJiri Slaby <jslaby@suse.cz>
Date2016-03-03 10:20 +0100
Message-ID<r8xAm-4OI-19@gated-at.bofh.it>
In reply to#1348199
Hi,

On 03/02/2016, 04:45 PM, Tejun Heo wrote:
> On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote:
>>> 1. didn't help, the problem persists. So I haven't applied the patch from 2.
>>
>> FWIW I dumped more info about the wq:
>> wq->name='hci0' pwq=ffff8800390d7600 wq->dfl_pwq=ffff8800390d5200
>> pwq->refcnt=2 pwq->nr_active=0 delayed_works: <nothing>
> 
> Can you please print out the same info for all pwq's during shutdown?
> It looks like we're leaking pwq refcnt but I can't spot a place where
> that could happen on an empty pwq.

I have not done that yet, but today, I see:
destroy_workqueue: name='req_hci0' pwq=ffff88002f590300
wq->dfl_pwq=ffff88002f591e00 pwq->refcnt=2 pwq->nr_active=0 delayed_works:
   pwq 12: cpus=0-1 node=0 flags=0x4 nice=-20 active=0/1
     in-flight: 18568:wq_barrier_func

thanks,
-- 
js
suse labs

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web