Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348045 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-03-02 15:00 +0100 |
| Last post | 2016-03-02 19:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] batman-adv: clarify CFG80211 dependency Arnd Bergmann <arnd@arndb.de> - 2016-03-02 15:00 +0100
Re: [PATCH] batman-adv: clarify CFG80211 dependency Antonio Quartulli <a@unstable.cc> - 2016-03-02 16:30 +0100
Re: [PATCH] batman-adv: clarify CFG80211 dependency David Miller <davem@davemloft.net> - 2016-03-02 19:50 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-03-02 15:00 +0100 |
| Subject | [PATCH] batman-adv: clarify CFG80211 dependency |
| Message-ID | <r8ftN-8on-19@gated-at.bofh.it> |
The driver calls cfg80211_get_station, which may be part of a
module, so we must not enable BATMAN_ADV_BATMAN_V if
BATMAN_ADV=y and CFG80211=m:
net/built-in.o: In function `batadv_v_elp_get_throughput':
(text+0x5c62c): undefined reference to `cfg80211_get_station'
This clarifies the dependency to cover all combinations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
---
net/batman-adv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index e651dc927bfd..f66930ee3c0b 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -17,7 +17,7 @@ config BATMAN_ADV
config BATMAN_ADV_BATMAN_V
bool "B.A.T.M.A.N. V protocol (experimental)"
- depends on BATMAN_ADV && CFG80211
+ depends on BATMAN_ADV && CFG80211=y || (CFG80211=m && BATMAN_ADV=m)
default n
help
This option enables the B.A.T.M.A.N. V protocol, the successor
--
2.7.0
[toc] | [next] | [standalone]
| From | Antonio Quartulli <a@unstable.cc> |
|---|---|
| Date | 2016-03-02 16:30 +0100 |
| Message-ID | <r8gSS-14i-19@gated-at.bofh.it> |
| In reply to | #1348045 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
> The driver calls cfg80211_get_station, which may be part of a
> module, so we must not enable BATMAN_ADV_BATMAN_V if
> BATMAN_ADV=y and CFG80211=m:
>
> net/built-in.o: In function `batadv_v_elp_get_throughput':
> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>
> This clarifies the dependency to cover all combinations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Acked-by: Antonio Quartulli <a@unstable.cc>
Thanks a lot Arnd!
David, could you please merge this change in net-next directly ?
Regards,
--
Antonio Quartulli
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-03-02 19:50 +0100 |
| Message-ID | <r8k0q-3yn-27@gated-at.bofh.it> |
| In reply to | #1348149 |
From: Antonio Quartulli <a@unstable.cc>
Date: Wed, 2 Mar 2016 22:46:07 +0800
> On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote:
>> The driver calls cfg80211_get_station, which may be part of a
>> module, so we must not enable BATMAN_ADV_BATMAN_V if
>> BATMAN_ADV=y and CFG80211=m:
>>
>> net/built-in.o: In function `batadv_v_elp_get_throughput':
>> (text+0x5c62c): undefined reference to `cfg80211_get_station'
>>
>> This clarifies the dependency to cover all combinations.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: c833484e5f38 ("batman-adv: ELP - compute the metric based on the estimated throughput")
>
> Acked-by: Antonio Quartulli <a@unstable.cc>
>
> Thanks a lot Arnd!
>
> David, could you please merge this change in net-next directly ?
Done, applied, thanks everyone.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web