Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1348074 > unrolled thread
| Started by | Paolo Abeni <pabeni@redhat.com> |
|---|---|
| First post | 2016-03-02 15:30 +0100 |
| Last post | 2016-03-03 10:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Paolo Abeni <pabeni@redhat.com> - 2016-03-02 15:30 +0100
Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-03-02 15:40 +0100
Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Josh Boyer <jwboyer@fedoraproject.org> - 2016-03-02 16:10 +0100
Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal Paolo Abeni <pabeni@redhat.com> - 2016-03-03 10:20 +0100
| From | Paolo Abeni <pabeni@redhat.com> |
|---|---|
| Date | 2016-03-02 15:30 +0100 |
| Subject | [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal |
| Message-ID | <r8fWO-pB-13@gated-at.bofh.it> |
This patch add a rpm preuninstall scriptlet to cleanup the boot loader configuration on kernel package uninstall. The initrd for the to-be-removed kernel is deleted, too. Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- scripts/package/mkspec | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/package/mkspec b/scripts/package/mkspec index fe44d68..b6de63c 100755 --- a/scripts/package/mkspec +++ b/scripts/package/mkspec @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE /boot/.vmlinuz-$KERNELRELEASE-rpm /boot echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm /boot/.System.map-$KERNELRELEASE-rpm" echo "fi" echo "" +echo "%preun" +echo "if [ -x /sbin/new-kernel-pkg ]; then" +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd --initrdfile=/boot/initramfs-$KERNELRELEASE.img" +echo "fi" +echo "" echo "%files" echo '%defattr (-, root, root)' echo "/lib/modules/$KERNELRELEASE" -- 1.8.3.1
[toc] | [next] | [standalone]
| From | Hannes Frederic Sowa <hannes@stressinduktion.org> |
|---|---|
| Date | 2016-03-02 15:40 +0100 |
| Subject | Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal |
| Message-ID | <r8g6u-uK-21@gated-at.bofh.it> |
| In reply to | #1348074 |
On 02.03.2016 15:28, Paolo Abeni wrote: > This patch add a rpm preuninstall scriptlet to cleanup the > boot loader configuration on kernel package uninstall. > The initrd for the to-be-removed kernel is deleted, too. > > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > scripts/package/mkspec | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > index fe44d68..b6de63c 100755 > --- a/scripts/package/mkspec > +++ b/scripts/package/mkspec > @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE /boot/.vmlinuz-$KERNELRELEASE-rpm /boot > echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm /boot/.System.map-$KERNELRELEASE-rpm" > echo "fi" > echo "" > +echo "%preun" > +echo "if [ -x /sbin/new-kernel-pkg ]; then" > +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd --initrdfile=/boot/initramfs-$KERNELRELEASE.img" > +echo "fi" > +echo "" > echo "%files" > echo '%defattr (-, root, root)' > echo "/lib/modules/$KERNELRELEASE" > Maybe we should also switch to new-kernel-pkg for the postinstall call? How about switching to kernel-install? Thanks, Hannes
[toc] | [prev] | [next] | [standalone]
| From | Josh Boyer <jwboyer@fedoraproject.org> |
|---|---|
| Date | 2016-03-02 16:10 +0100 |
| Message-ID | <r8gzw-UO-19@gated-at.bofh.it> |
| In reply to | #1348093 |
On Wed, Mar 2, 2016 at 9:38 AM, Hannes Frederic Sowa <hannes@stressinduktion.org> wrote: > On 02.03.2016 15:28, Paolo Abeni wrote: >> >> This patch add a rpm preuninstall scriptlet to cleanup the >> boot loader configuration on kernel package uninstall. >> The initrd for the to-be-removed kernel is deleted, too. >> >> Signed-off-by: Paolo Abeni <pabeni@redhat.com> >> --- >> scripts/package/mkspec | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/scripts/package/mkspec b/scripts/package/mkspec >> index fe44d68..b6de63c 100755 >> --- a/scripts/package/mkspec >> +++ b/scripts/package/mkspec >> @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE >> /boot/.vmlinuz-$KERNELRELEASE-rpm /boot >> echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm >> /boot/.System.map-$KERNELRELEASE-rpm" >> echo "fi" >> echo "" >> +echo "%preun" >> +echo "if [ -x /sbin/new-kernel-pkg ]; then" >> +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd >> --initrdfile=/boot/initramfs-$KERNELRELEASE.img" >> +echo "fi" >> +echo "" >> echo "%files" >> echo '%defattr (-, root, root)' >> echo "/lib/modules/$KERNELRELEASE" >> > > Maybe we should also switch to new-kernel-pkg for the postinstall call? How > about switching to kernel-install? new-kernel-pkg probably shouldn't be used here either. The installkernel binary is the distro agnostic kernel installation tool and the various distros provide that as either the tool they use or as a wrapper. Switching to new-kernel-pkg implies this would only be viable on grubby based distros, and using kernel-install would require systemd. josh
[toc] | [prev] | [next] | [standalone]
| From | Paolo Abeni <pabeni@redhat.com> |
|---|---|
| Date | 2016-03-03 10:20 +0100 |
| Subject | Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal |
| Message-ID | <r8xAm-4OI-21@gated-at.bofh.it> |
| In reply to | #1348116 |
On Wed, 2016-03-02 at 10:09 -0500, Josh Boyer wrote: > On Wed, Mar 2, 2016 at 9:38 AM, Hannes Frederic Sowa > <hannes@stressinduktion.org> wrote: > > On 02.03.2016 15:28, Paolo Abeni wrote: > >> > >> This patch add a rpm preuninstall scriptlet to cleanup the > >> boot loader configuration on kernel package uninstall. > >> The initrd for the to-be-removed kernel is deleted, too. > >> > >> Signed-off-by: Paolo Abeni <pabeni@redhat.com> > >> --- > >> scripts/package/mkspec | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/scripts/package/mkspec b/scripts/package/mkspec > >> index fe44d68..b6de63c 100755 > >> --- a/scripts/package/mkspec > >> +++ b/scripts/package/mkspec > >> @@ -138,6 +138,11 @@ echo "/sbin/installkernel $KERNELRELEASE > >> /boot/.vmlinuz-$KERNELRELEASE-rpm /boot > >> echo "rm -f /boot/.vmlinuz-$KERNELRELEASE-rpm > >> /boot/.System.map-$KERNELRELEASE-rpm" > >> echo "fi" > >> echo "" > >> +echo "%preun" > >> +echo "if [ -x /sbin/new-kernel-pkg ]; then" > >> +echo "new-kernel-pkg --remove $KERNELRELEASE --rminitrd > >> --initrdfile=/boot/initramfs-$KERNELRELEASE.img" > >> +echo "fi" > >> +echo "" > >> echo "%files" > >> echo '%defattr (-, root, root)' > >> echo "/lib/modules/$KERNELRELEASE" > >> > > > > Maybe we should also switch to new-kernel-pkg for the postinstall call? How > > about switching to kernel-install? > > new-kernel-pkg probably shouldn't be used here either. The > installkernel binary is the distro agnostic kernel installation tool > and the various distros provide that as either the tool they use or as > a wrapper. Switching to new-kernel-pkg implies this would only be > viable on grubby based distros, and using kernel-install would require > systemd. I'm sorry, I try to dig a bit, but I did not find any distro agnostic kernel removal tools. Can you please point out some ? Elsewhere can we stuck with new-kernel-pkg, plus eventual fall-back to other options, i.e. kernel-install? Thank you, Paolo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web