Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1347983 > unrolled thread

[PATCH v3 2/2] sched/core: Get rid of 'cpu' local variable in __schedule()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 2/2] sched/core: Get rid of 'cpu' local variable in __schedule() Alexander Gordeev <agordeev@redhat.com> - 2016-03-02 13:00 +0100
    Re: [PATCH v3 2/2] sched/core: Get rid of 'cpu' local variable in  __schedule() Peter Zijlstra <peterz@infradead.org> - 2016-03-02 13:10 +0100

#1347983 — [PATCH v3 2/2] sched/core: Get rid of 'cpu' local variable in __schedule()

This update is a continuation of commit 3223d05 ("sched/core:
Remove dead statement in __schedule()") and completes the
removal of a dead code with a removal of an unnecessary 'cpu'
local variable - as it is only used to acquire the current
runqueue.

Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
---
 kernel/sched/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 735e87c..75e62ef 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3131,10 +3131,8 @@ static void __sched notrace __schedule(bool preempt)
 	struct task_struct *prev, *next;
 	unsigned long *switch_count;
 	struct rq *rq;
-	int cpu;
 
-	cpu = smp_processor_id();
-	rq = cpu_rq(cpu);
+	rq = this_rq();
 	prev = rq->curr;
 
 	/*
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1347987 — Re: [PATCH v3 2/2] sched/core: Get rid of 'cpu' local variable in __schedule()

On Wed, Mar 02, 2016 at 12:53:32PM +0100, Alexander Gordeev wrote:
> This update is a continuation of commit 3223d05 ("sched/core:

Please put

[core]
        abbrev = 12

Into your .gitconfig, 7 char SHA1s are no good.

If TJ acks the first, I can fix up this time, so no need to repost just
yet.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web