Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1350306 > unrolled thread

Re: Left-over select to PUBLIC_KEY_ALGO_RSA

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Left-over select to PUBLIC_KEY_ALGO_RSA David Howells <dhowells@redhat.com> - 2016-03-04 16:30 +0100
    [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA Andreas Ziegler <andreas.ziegler@fau.de> - 2016-03-04 19:10 +0100
      Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA David Howells <dhowells@redhat.com> - 2016-03-07 16:10 +0100

#1350306 — Re: Left-over select to PUBLIC_KEY_ALGO_RSA

Andreas Ziegler <andreas.ziegler@fau.de> wrote:

> As the corresponding option is gone, the select statement can safely be
> removed. Should I prepare a simple patch for that?

Please.

> I detected this by using scripts/checkkconfigsymbols on today's and
> yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d
> next-20160303..next-20160304").

Interesting - I didn't realise that exists.  This sort of consistency check
should be run every time the Kconfig files are parsed.

Thanks,
David

[toc] | [next] | [standalone]

#1350488 — [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
but forgot to remove a 'select' to this option in the definition of
INTEGRITY_ASYMMETRIC_KEYS.

Let's remove the select, as it's ineffective now.

Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
 security/integrity/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 979be65..da95658 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -35,7 +35,6 @@ config INTEGRITY_ASYMMETRIC_KEYS
 	default n
         select ASYMMETRIC_KEY_TYPE
         select ASYMMETRIC_PUBLIC_KEY_SUBTYPE
-        select PUBLIC_KEY_ALGO_RSA
         select CRYPTO_RSA
         select X509_CERTIFICATE_PARSER
 	help
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1351686 — Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Andreas Ziegler <andreas.ziegler@fau.de> wrote:

> Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
> the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
> but forgot to remove a 'select' to this option in the definition of
> INTEGRITY_ASYMMETRIC_KEYS.
> 
> Let's remove the select, as it's ineffective now.
> 
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web