Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344314 > unrolled thread

Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support Joerg Roedel <joro@8bytes.org> - 2016-02-26 15:50 +0100
    RE: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support "Wan, Vincent" <Vincent.Wan@amd.com> - 2016-03-04 04:30 +0100
      Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support Joerg Roedel <joro@8bytes.org> - 2016-03-04 09:50 +0100
        RE: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support "Wan, Vincent" <Vincent.Wan@amd.com> - 2016-03-04 09:50 +0100
          Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2016-03-05 10:10 +0100

#1344314 — Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support

On Tue, Jan 26, 2016 at 06:14:29PM -0500, Wan Zongshun wrote:
> Suravee Suthikulpanit (3):
>   iommu/amd: Modify ivhd_header structure to support type 11h and 40h
>   iommu/amd: Use the most comprehensive IVHD type that the driver can
>     support
>   iommu/amd: Introduces ivrs_acpihid kernel parameter
> 
> Wan Zongshun (5):
>   iommu/amd: Add new map for storing IVHD dev entry type HID
>   iommu/amd: Make call-sites of get_device_id aware of its return value
>   iommu/amd: Add iommu support for ACPI HID devices
>   iommu/amd: Manage iommu_group for ACPI HID devices
>   iommu/amd: Set AMD iommu callbacks for amba bus

These patches fail to boot on my Carrizo system. Unfortunatly it fails
before console is initialized and the box has no serial port to grab the
early panic.



	Joerg

[toc] | [next] | [standalone]

#1349809

Thanks!
Vincent Wan.

> -----Original Message-----
> From: Joerg Roedel [mailto:joro@8bytes.org]
> Sent: Friday, February 26, 2016 10:45 PM
> To: Wan, Vincent
> Cc: iommu@lists.linux-foundation.org; Suthikulpanit, Suravee; Borislav Petkov;
> Huang, Ray; Xue, Ken; vw@iommu.org; mcuos.com@gmail.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device
> support
> 
> On Tue, Jan 26, 2016 at 06:14:29PM -0500, Wan Zongshun wrote:
> > Suravee Suthikulpanit (3):
> >   iommu/amd: Modify ivhd_header structure to support type 11h and 40h
> >   iommu/amd: Use the most comprehensive IVHD type that the driver can
> >     support
> >   iommu/amd: Introduces ivrs_acpihid kernel parameter
> >
> > Wan Zongshun (5):
> >   iommu/amd: Add new map for storing IVHD dev entry type HID
> >   iommu/amd: Make call-sites of get_device_id aware of its return value
> >   iommu/amd: Add iommu support for ACPI HID devices
> >   iommu/amd: Manage iommu_group for ACPI HID devices
> >   iommu/amd: Set AMD iommu callbacks for amba bus
> 
> These patches fail to boot on my Carrizo system. Unfortunatly it fails before
> console is initialized and the box has no serial port to grab the early panic.
> 
Joerg,
Can you provide me which branch you are using to test those patches.

We are validating the patches in v4.5.0-rc6, and no issues like your description.

Vincent.

> 
> 
> 	Joerg

[toc] | [prev] | [next] | [standalone]

#1349951

On Fri, Mar 04, 2016 at 01:52:31AM +0000, Wan, Vincent wrote:
> > These patches fail to boot on my Carrizo system. Unfortunatly it fails before
> > console is initialized and the box has no serial port to grab the early panic.
> > 
> Joerg,
> Can you provide me which branch you are using to test those patches.
> 
> We are validating the patches in v4.5.0-rc6, and no issues like your description.

I tested them on v4.5-rc5.


	Joerg

[toc] | [prev] | [next] | [standalone]

#1349952

> > Joerg,
> > Can you provide me which branch you are using to test those patches.
> >
> > We are validating the patches in v4.5.0-rc6, and no issues like your
> description.
> 
> I tested them on v4.5-rc5.
> 
Thanks! 
We will test the patches basing on this v4.5-rc5 version again.

Vincent.
> 
> 	Joerg

[toc] | [prev] | [next] | [standalone]

#1350853

Hi Joerg,

On 03/04/2016 03:49 PM, Wan, Vincent wrote:
>>> Joerg,
>>> Can you provide me which branch you are using to test those patches.
>>>
>>> We are validating the patches in v4.5.0-rc6, and no issues like your
>> description.
>>
>> I tested them on v4.5-rc5.
>>
> Thanks!
> We will test the patches basing on this v4.5-rc5 version again.
>
> Vincent.
>>
>> 	Joerg
>

I found the issue now. I'll work with Vincent to send out V3.

The problem is because in the information in the IOMMU Attributes field 
of the IVHD header type 40h (offset byte 20 = struct 
ivhd_header.efr_attr) is incorrect. It was correct in the IVHD type 
10h.... Sigh :(

However, the same information in the MMIO offset 4000h Counter 
configuration Register is correct. So, I'll try to have the patch get 
information from here instead.

Earlier, we had another issue with IOMMU PERF intialization, and it was 
disabled. So, it hides this bug when we were testing the patch earlier.
Now that we had a workaround for that bug n v4.5-rc5, it bombs in the 
init_iommu_perf_ctr().

So, if you want to test out the rest of this patch series, just simply 
comment out this function, and it should boot.

Regards,
Suravee

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web