Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1348479 > unrolled thread

Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153!

Started byRoss Zwisler <zwisler@gmail.com>
First post2016-03-02 22:30 +0100
Last post2016-03-03 16:40 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153! Ross Zwisler <zwisler@gmail.com> - 2016-03-02 22:30 +0100
    Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153! Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-03 07:00 +0100
      Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153! Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-03-03 16:40 +0100

#1348479 — Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153!

FromRoss Zwisler <zwisler@gmail.com>
Date2016-03-02 22:30 +0100
SubjectRe: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153!
Message-ID<r8mvh-5nK-9@gated-at.bofh.it>
On Mon, Feb 15, 2016 at 4:50 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote:
>> Greetings,
>>
>> 0day kernel testing robot got the below dmesg and the first bad commit is
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
>>
>> commit e7223f18603374d235d8bb0398532323e5f318b9
>> Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>> AuthorDate: Fri Feb 12 18:33:45 2016 +0530
>> Commit:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> CommitDate: Sun Feb 14 17:43:50 2016 -0800
>>
>>     ppdev: use new parport device model
>>
>>     Modify ppdev driver to use the new parallel port device model.
>>
>>     Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Can you please send the .config file so that i can reproduce in my local
> system and test?
>
> Ying Huang also sent a similar report after posting the patches. I tried
> his .config and your scripts to reproduce this but was not able to.
>
> Anyway, this error is not related to this patch, this patch has just
> uncovered this error in parport. And will only happen if ppdev tries to
> register with parport before parport bus is registered.
> Can you please check if the below patch solves the problem:
>
>
> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index 3308427..176b2b6 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -273,6 +273,9 @@ int __parport_register_driver(struct parport_driver *drv, struct module *owner,
>                 /* using device model */
>                 int ret;
>
> +               if (!parport_bus_type.p)
> +                       return -EAGAIN;
> +
>                 /* initialize common driver fields */
>                 drv->driver.name = drv->name;
>                 drv->driver.bus = &parport_bus_type;
>
>
> --
> regards
> sudip

I've been hitting this error on my KVM system as well, and bisected to
the same commit.

The patch you have here solved the issue for me.

I'm happy to provide kernel config, etc. - let me know what would be helpful.

- Ross

[toc] | [next] | [standalone]


#1348801

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-03-03 07:00 +0100
Message-ID<r8usO-2yU-7@gated-at.bofh.it>
In reply to#1348479
On Wed, Mar 02, 2016 at 02:24:22PM -0700, Ross Zwisler wrote:
> On Mon, Feb 15, 2016 at 4:50 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote:
> >> Greetings,
> >>
> >> 0day kernel testing robot got the below dmesg and the first bad commit is
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
> >>
> >> commit e7223f18603374d235d8bb0398532323e5f318b9
> >> Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> >> AuthorDate: Fri Feb 12 18:33:45 2016 +0530
> >> Commit:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> CommitDate: Sun Feb 14 17:43:50 2016 -0800
> >>
<snip>
> 
> I've been hitting this error on my KVM system as well, and bisected to
> the same commit.
> 
> The patch you have here solved the issue for me.

I will submit the patch today. I am sorry for the delay, i got held up
in some other things. Since you have tested this can I add your
Tested-by: to the patch?

regards
sudip

[toc] | [prev] | [next] | [standalone]


#1349290

FromRoss Zwisler <ross.zwisler@linux.intel.com>
Date2016-03-03 16:40 +0100
Message-ID<r8Dw5-Di-1@gated-at.bofh.it>
In reply to#1348801
On Thu, Mar 03, 2016 at 11:21:33AM +0530, Sudip Mukherjee wrote:
> On Wed, Mar 02, 2016 at 02:24:22PM -0700, Ross Zwisler wrote:
> > On Mon, Feb 15, 2016 at 4:50 AM, Sudip Mukherjee
> > <sudipm.mukherjee@gmail.com> wrote:
> > > On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote:
> > >> Greetings,
> > >>
> > >> 0day kernel testing robot got the below dmesg and the first bad commit is
> > >>
> > >> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
> > >>
> > >> commit e7223f18603374d235d8bb0398532323e5f318b9
> > >> Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > >> AuthorDate: Fri Feb 12 18:33:45 2016 +0530
> > >> Commit:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >> CommitDate: Sun Feb 14 17:43:50 2016 -0800
> > >>
> <snip>
> > 
> > I've been hitting this error on my KVM system as well, and bisected to
> > the same commit.
> > 
> > The patch you have here solved the issue for me.
> 
> I will submit the patch today. I am sorry for the delay, i got held up
> in some other things. Since you have tested this can I add your
> Tested-by: to the patch?
> 
> regards
> sudip

Sure.

Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web