Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345613 > unrolled thread

[patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo

Back to article view | Back to linux.kernel

Contents

  [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-29 11:00 +0100
    Re: [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo Vinod Koul <vinod.koul@intel.com> - 2016-03-03 16:50 +0100

#1345613 — [patch] dma/mic_x100_dma: IS_ERR() vs PTR_ERR() typo

This is harmless because the caller only cares about zero vs non-zero
but we should be returning PTR_ERR() here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index 068e920..1502b24 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -483,7 +483,7 @@ static int mic_dma_setup_irq(struct mic_dma_chan *ch)
 			mic_dma_intr_handler, mic_dma_thread_fn,
 			"mic dma_channel", ch, ch->ch_num);
 	if (IS_ERR(ch->cookie))
-		return IS_ERR(ch->cookie);
+		return PTR_ERR(ch->cookie);
 	return 0;
 }
 

[toc] | [next] | [standalone]

#1349303

On Mon, Feb 29, 2016 at 12:51:07PM +0300, Dan Carpenter wrote:
> This is harmless because the caller only cares about zero vs non-zero
> but we should be returning PTR_ERR() here.

Applied thanks

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web