Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1349032 > unrolled thread

[PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

Started byNeil Armstrong <narmstrong@baylibre.com>
First post2016-03-03 12:50 +0100
Last post2016-03-03 16:00 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings Neil Armstrong <narmstrong@baylibre.com> - 2016-03-03 12:50 +0100
    Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller  bindings Neil Armstrong <narmstrong@baylibre.com> - 2016-03-03 16:00 +0100
      Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller  bindings Andrew Lunn <andrew@lunn.ch> - 2016-03-03 16:10 +0100
    Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller  bindings Andrew Lunn <andrew@lunn.ch> - 2016-03-03 16:00 +0100

#1349032 — [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

FromNeil Armstrong <narmstrong@baylibre.com>
Date2016-03-03 12:50 +0100
Subject[PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings
Message-ID<r8zVy-6xi-57@gated-at.bofh.it>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../bindings/interrupt-controller/plxtech,rps-irq.txt   | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
new file mode 100644
index 0000000..db117a0
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
@@ -0,0 +1,17 @@
+PLX Technology OXNAS SoCs Family RPS Interrupt Controller
+=========================================================
+
+Required properties:
+- compatible: Should be "plxtech,nas782x-rps"
+- reg : Specifies base physical address and size of the registers.
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Should be 1
+
+example:
+
+intc: interrupt-controller@0 {
+	compatible = "plxtech,nas782x-rps";
+	interrupt-controller;
+	reg = <0 0x200>;
+	#interrupt-cells = <1>;
+};
-- 
1.9.1

[toc] | [next] | [standalone]


#1349249 — Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

FromNeil Armstrong <narmstrong@baylibre.com>
Date2016-03-03 16:00 +0100
SubjectRe: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings
Message-ID<r8CTn-8sH-3@gated-at.bofh.it>
In reply to#1349032
Hi Andrew,

On 03/03/2016 03:53 PM, Andrew Lunn wrote:
> 
>> +- compatible: Should be "plxtech,nas782x-rps"
> 
> Hi Neil
> 
> It would be nice to be consistent with the naming.
The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer.

> 
> Maybe also the filename of the driver itself should be changed. You
> had an interesting sorting problem in the Makefile, which a consistent
> name would help with.
Yes, I will add -irq to the driver name and _IRQ to the config name.

> 
>      Andrew
> 
Thanks,
Neil

[toc] | [prev] | [next] | [standalone]


#1349260 — Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

FromAndrew Lunn <andrew@lunn.ch>
Date2016-03-03 16:10 +0100
SubjectRe: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings
Message-ID<r8D34-k8-3@gated-at.bofh.it>
In reply to#1349249
On Thu, Mar 03, 2016 at 03:57:10PM +0100, Neil Armstrong wrote:
> Hi Andrew,
> 
> On 03/03/2016 03:53 PM, Andrew Lunn wrote:
> > 
> >> +- compatible: Should be "plxtech,nas782x-rps"
> > 
> > Hi Neil
> > 
> > It would be nice to be consistent with the naming.
> The compatible is now oxsemi,os810se-rps-irq which is consistent with the timer.

Ah, i had not read that far down the thread yet.

Thanks
	Andrew

[toc] | [prev] | [next] | [standalone]


#1349255 — Re: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings

FromAndrew Lunn <andrew@lunn.ch>
Date2016-03-03 16:00 +0100
SubjectRe: [PATCH 03/17] dt-bindings: Add PLX Technology RPS IRQ Controller bindings
Message-ID<r8CTo-8sH-5@gated-at.bofh.it>
In reply to#1349032
On Thu, Mar 03, 2016 at 12:39:56PM +0100, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  .../bindings/interrupt-controller/plxtech,rps-irq.txt   | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt
> new file mode 100644
> index 0000000..db117a0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/plxtech,rps-irq.txt

...

> +- compatible: Should be "plxtech,nas782x-rps"

Hi Neil

It would be nice to be consistent with the naming.

Maybe also the filename of the driver itself should be changed. You
had an interesting sorting problem in the Makefile, which a consistent
name would help with.

     Andrew

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web