Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1347523 > unrolled thread

[PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section

Back to article view | Back to linux.kernel

Contents

  [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section Michael Ellerman <mpe@ellerman.id.au> - 2016-03-02 02:40 +0100
    Re: [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section Joel Stanley <joel@jms.id.au> - 2016-03-02 03:00 +0100
      Re: [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section Michael Ellerman <mpe@ellerman.id.au> - 2016-03-02 04:20 +0100
        Re: [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section Joe Perches <joe@perches.com> - 2016-03-02 04:40 +0100
          Re: [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section Mike & Meg <mikenmeg@ellerman.id.au> - 2016-03-02 05:20 +0100

#1347523 — [PATCH] MAINTAINERS: Add powerpc drivers to the powerpc section

We'd like folks working on drivers for powerpc to also Cc linuxppc-dev,
so we can be aware of what's going on in drivers and/or review the
changes.

So add patterns to the powerpc MAINTAINERS section to catch some of the
drivers we're interested in.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

If I've missed some let me know.

diff --git a/MAINTAINERS b/MAINTAINERS
index 74bbff3dda52..671c87d40c03 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6491,6 +6491,18 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S:	Supported
 F:	Documentation/powerpc/
 F:	arch/powerpc/
+F:	drivers/char/tpm/tpm_ibmvtpm*
+F:	drivers/crypto/nx/
+F:	drivers/crypto/vmx/
+F:	drivers/net/ethernet/ibm/ibmveth.*
+F:	drivers/net/ethernet/ibm/ibmvnic.*
+F:	drivers/pci/hotplug/rpa*
+F:	drivers/scsi/ibmvscsi/
+N:	/pmac
+N:	powermac
+N:	powernv
+N:	[^a-z0-9]ps3
+N:	pseries
 
 LINUX FOR POWER MACINTOSH
 M:	Benjamin Herrenschmidt <benh@kernel.crashing.org>
-- 
2.5.0

[toc] | [next] | [standalone]

#1347562

On Wed, Mar 2, 2016 at 12:06 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> We'd like folks working on drivers for powerpc to also Cc linuxppc-dev,
> so we can be aware of what's going on in drivers and/or review the
> changes.
>
> So add patterns to the powerpc MAINTAINERS section to catch some of the
> drivers we're interested in.

There are a few more that would be good. '*opal*.c' catches these:

./drivers/i2c/busses/i2c-opal.c
./drivers/rtc/rtc-opal.c
./drivers/tty/hvc/hvc_opal.c

and '*powernv*.c' gets these (some a duplicates with what you have):

./drivers/leds/leds-powernv.c
./drivers/cpufreq/powernv-cpufreq.c
./drivers/mtd/devices/powernv_flash.c
./drivers/cpuidle/cpuidle-powernv.c
./drivers/char/hw_random/powernv-rng.c
./drivers/char/ipmi/ipmi_powernv.c
./drivers/hwmon/ibmpowernv.c
./drivers/crypto/nx/nx-842-powernv.c

Cheers,

Joel

[toc] | [prev] | [next] | [standalone]

#1347753

On Wed, 2016-03-02 at 12:20 +1030, Joel Stanley wrote:

> On Wed, Mar 2, 2016 at 12:06 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:

> > We'd like folks working on drivers for powerpc to also Cc linuxppc-dev,
> > so we can be aware of what's going on in drivers and/or review the
> > changes.
> > 
> > So add patterns to the powerpc MAINTAINERS section to catch some of the
> > drivers we're interested in.
> 
> There are a few more that would be good. '*opal*.c' catches these:
> 
> ./drivers/i2c/busses/i2c-opal.c
> ./drivers/rtc/rtc-opal.c
> ./drivers/tty/hvc/hvc_opal.c

Ah yep thanks, will add "N: opal".

> and '*powernv*.c' gets these (some a duplicates with what you have):
> 
> ./drivers/leds/leds-powernv.c
> ./drivers/cpufreq/powernv-cpufreq.c
> ./drivers/mtd/devices/powernv_flash.c
> ./drivers/cpuidle/cpuidle-powernv.c
> ./drivers/char/hw_random/powernv-rng.c
> ./drivers/char/ipmi/ipmi_powernv.c
> ./drivers/hwmon/ibmpowernv.c
> ./drivers/crypto/nx/nx-842-powernv.c

They should all be covered by "N: powernv" I think:

    $ for f in ./drivers/leds/leds-powernv.c ./drivers/cpufreq/powernv-cpufreq.c ./drivers/mtd/devices/powernv_flash.c ./drivers/cpuidle/cpuidle-powernv.c ./drivers/char/hw_random/powernv-rng.c
./drivers/char/ipmi/ipmi_powernv.c ./drivers/hwmon/ibmpowernv.c ./drivers/crypto/nx/nx-842-powernv.c; do echo -en "$f\t"; ./scripts/get_maintainer.pl -f $f | grep linuxppc-dev; done
    ./drivers/leds/leds-powernv.c		linuxppc-dev@lists.ozlabs.org
    ./drivers/cpufreq/powernv-cpufreq.c		linuxppc-dev@lists.ozlabs.org
    ./drivers/mtd/devices/powernv_flash.c	linuxppc-dev@lists.ozlabs.org
    ./drivers/cpuidle/cpuidle-powernv.c		linuxppc-dev@lists.ozlabs.org
    ./drivers/char/hw_random/powernv-rng.c	linuxppc-dev@lists.ozlabs.org
    ./drivers/char/ipmi/ipmi_powernv.c		linuxppc-dev@lists.ozlabs.org
    ./drivers/hwmon/ibmpowernv.c		linuxppc-dev@lists.ozlabs.org
    ./drivers/crypto/nx/nx-842-powernv.c	linuxppc-dev@lists.ozlabs.org


cheers

[toc] | [prev] | [next] | [standalone]

#1347758

On Wed, 2016-03-02 at 14:12 +1100, Michael Ellerman wrote:
> On Wed, 2016-03-02 at 12:20 +1030, Joel Stanley wrote:
> 
> > 
> > On Wed, Mar 2, 2016 at 12:06 PM, Michael Ellerman  wrote:
> > 
> > > 
> > > We'd like folks working on drivers for powerpc to also Cc linuxppc-dev,
> > > so we can be aware of what's going on in drivers and/or review the
> > > changes.
> > > 
> > > So add patterns to the powerpc MAINTAINERS section to catch some of the
> > > drivers we're interested in.
> > There are a few more that would be good. '*opal*.c' catches these:
> > 
> > ./drivers/i2c/busses/i2c-opal.c
> > ./drivers/rtc/rtc-opal.c
> > ./drivers/tty/hvc/hvc_opal.c
> Ah yep thanks, will add "N: opal".

N: and F: have different characteristics for get_maintainer.pl

From MAINTAINERS:

	   scripts/get_maintainer.pl has different behavior for files that
	   match F: pattern and matches of N: patterns.  By default,
	   get_maintainer will not look at git log history when an F: pattern
	   match occurs.  When an N: match occurs, git log history is used
	   to also notify the people that have git commit signatures.

[toc] | [prev] | [next] | [standalone]

#1347772

On Tue, 2016-03-01 at 19:33 -0800, Joe Perches wrote:
> On Wed, 2016-03-02 at 14:12 +1100, Michael Ellerman wrote:
> > On Wed, 2016-03-02 at 12:20 +1030, Joel Stanley wrote:
> > 
> > > 
> > > On Wed, Mar 2, 2016 at 12:06 PM, Michael Ellerman  wrote:
> > > 
> > > > 
> > > > We'd like folks working on drivers for powerpc to also Cc linuxppc-dev,
> > > > so we can be aware of what's going on in drivers and/or review the
> > > > changes.
> > > > 
> > > > So add patterns to the powerpc MAINTAINERS section to catch some of the
> > > > drivers we're interested in.
> > > There are a few more that would be good. '*opal*.c' catches these:
> > > 
> > > ./drivers/i2c/busses/i2c-opal.c
> > > ./drivers/rtc/rtc-opal.c
> > > ./drivers/tty/hvc/hvc_opal.c

> > Ah yep thanks, will add "N: opal".
> 
> N: and F: have different characteristics for get_maintainer.pl
> 
> From MAINTAINERS:
> 
> 	   scripts/get_maintainer.pl has different behavior for files that
> 	   match F: pattern and matches of N: patterns.  By default,
> 	   get_maintainer will not look at git log history when an F: pattern
> 	   match occurs.  When an N: match occurs, git log history is used
> 	   to also notify the people that have git commit signatures.

Yeah I saw that.

What I want is to add linuxppc-dev to whatever it would have done previously.
ie. I don't want to hijack the patches from whoever would have got them.

And listing all the drivers explicitly would be a bit gross:

F:	drivers/block/ps3disk.c
F:	drivers/block/ps3vram.c
F:	drivers/char/hw_random/powernv-rng.c
F:	drivers/char/hw_random/pseries-rng.c
F:	drivers/char/ipmi/ipmi_powernv.c
F:	drivers/char/ps3flash.c
F:	drivers/cpufreq/pmac32-cpufreq.c
F:	drivers/cpufreq/pmac64-cpufreq.c
F:	drivers/cpufreq/powernv-cpufreq.c
F:	drivers/cpuidle/cpuidle-powernv.c
F:	drivers/cpuidle/cpuidle-pseries.c
F:	drivers/crypto/nx/nx-842-powernv.c
F:	drivers/crypto/nx/nx-842-pseries.c
F:	drivers/hwmon/ibmpowernv.c
F:	drivers/i2c/busses/i2c-opal.c
F:	drivers/i2c/busses/i2c-powermac.c
F:	drivers/ide/pmac.c
F:	drivers/leds/leds-powernv.c
F:	drivers/media/rc/keymaps/rc-asus-ps3-100.c
F:	drivers/mtd/devices/powernv_flash.c
F:	drivers/net/ethernet/ti/cpmac.c
F:	drivers/net/ethernet/toshiba/ps3_gelic_net.c
F:	drivers/net/ethernet/toshiba/ps3_gelic_net.h
F:	drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
F:	drivers/net/ethernet/toshiba/ps3_gelic_wireless.h
F:	drivers/ps3/ps3av.c
F:	drivers/ps3/ps3av_cmd.c
F:	drivers/ps3/ps3-lpm.c
F:	drivers/ps3/ps3stor_lib.c
F:	drivers/ps3/ps3-sys-manager.c
F:	drivers/ps3/ps3-vuart.c
F:	drivers/rtc/rtc-opal.c
F:	drivers/rtc/rtc-ps3.c
F:	drivers/scsi/ps3rom.c
F:	drivers/tty/hvc/hvc_opal.c
F:	drivers/tty/serial/pmac_zilog.c
F:	drivers/tty/serial/pmac_zilog.h
F:	drivers/usb/host/ehci-ps3.c
F:	drivers/usb/host/ohci-ps3.c
F:	drivers/video/fbdev/ps3fb.c
F:	sound/ppc/pmac.c
F:	sound/ppc/pmac.h
F:	sound/ppc/powermac.c
F:	sound/ppc/snd_ps3.c
F:	sound/ppc/snd_ps3.h
F:	sound/ppc/snd_ps3_reg.h

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web