Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1346861 > unrolled thread
| Started by | Joe Perches <joe@perches.com> |
|---|---|
| First post | 2016-03-01 19:40 +0100 |
| Last post | 2016-03-01 19:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id Joe Perches <joe@perches.com> - 2016-03-01 19:40 +0100
RE: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id "Pottratz, Dwane" <dwane.pottratz@intel.com> - 2016-03-01 19:40 +0100
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-03-01 19:40 +0100 |
| Subject | Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id |
| Message-ID | <r7Xnb-4qM-3@gated-at.bofh.it> |
On Tue, 2016-03-01 at 18:26 +0000, Pottratz, Dwane wrote:
> A commit hook for the Gerrit code review servers inserts change
> identifiers. These identifiers are noise in the context of the
> upstream kernel. However, they are needed in most development
> environments and the error needs to be ignored for static analysis
> tools.
It looks like there is some tab to space conversion corruption here.
Can you please resend it using some other email mechanism?
> Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b3c228..0756935 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);
> my $quiet = 0;
> my $tree = 1;
> my $chk_signoff = 1;
> +my $chk_changeid = 1;
> my $chk_patch = 1;
> my $tst_only;
> my $emacs = 0;
> @@ -64,6 +65,7 @@ Options:
> -q, --quiet quiet
> --no-tree run without a kernel tree
> --no-signoff do not check for 'Signed-off-by' line
> + --no-changeid do not check for 'Change-Id' line
> --patch treat FILE as patchfile (default)
> --emacs emacs compile window format
> --terse one line per report
> @@ -136,6 +138,7 @@ GetOptions(
> 'q|quiet+' => \$quiet,
> 'tree!' => \$tree,
> 'signoff!' => \$chk_signoff,
> + 'changeid!' => \$chk_changeid,
> 'patch!' => \$chk_patch,
> 'emacs!' => \$emacs,
> 'terse!' => \$terse,
> @@ -2310,7 +2313,7 @@ sub process {
> }
> # Check for unwanted Gerrit info
> - if ($in_commit_log && $line =~ /^\s*change-id:/i) {
> + if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
> ERROR("GERRIT_CHANGE_ID",
> "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
> }
> --
> 1.9.1
>
[toc] | [next] | [standalone]
| From | "Pottratz, Dwane" <dwane.pottratz@intel.com> |
|---|---|
| Date | 2016-03-01 19:40 +0100 |
| Message-ID | <r7Xnb-4qM-11@gated-at.bofh.it> |
| In reply to | #1346861 |
Sent in new message as a text file (instead of HTML). I hope that corrects the issue.
-Dwane
-----Original Message-----
From: Joe Perches [mailto:joe@perches.com]
Sent: Tuesday, March 1, 2016 10:31 AM
To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; linux-kernel@vger.kernel.org; akpm@linux-foundation.org
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
On Tue, 2016-03-01 at 18:26 +0000, Pottratz, Dwane wrote:
> A commit hook for the Gerrit code review servers inserts change
> identifiers. These identifiers are noise in the context of the
> upstream kernel. However, they are needed in most development
> environments and the error needs to be ignored for static analysis
> tools.
It looks like there is some tab to space conversion corruption here.
Can you please resend it using some other email mechanism?
> Signed-off-by: Dwane Pottratz <dwane.pottratz@intel.com>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b3c228..0756935 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -21,6 +21,7 @@ use Getopt::Long qw(:config no_auto_abbrev);
> my $quiet = 0;
> my $tree = 1;
> my $chk_signoff = 1;
> +my $chk_changeid = 1;
> my $chk_patch = 1;
> my $tst_only;
> my $emacs = 0;
> @@ -64,6 +65,7 @@ Options:
> -q, --quiet quiet
> --no-tree run without a kernel tree
> --no-signoff do not check for 'Signed-off-by' line
> + --no-changeid do not check for 'Change-Id' line
> --patch treat FILE as patchfile (default)
> --emacs emacs compile window format
> --terse one line per report
> @@ -136,6 +138,7 @@ GetOptions(
> 'q|quiet+' => \$quiet,
> 'tree!' => \$tree,
> 'signoff!' => \$chk_signoff,
> + 'changeid!' => \$chk_changeid,
> 'patch!' => \$chk_patch,
> 'emacs!' => \$emacs,
> 'terse!' => \$terse,
> @@ -2310,7 +2313,7 @@ sub process {
> }
> # Check for unwanted Gerrit info
> - if ($in_commit_log && $line =~ /^\s*change-id:/i) {
> + if ($in_commit_log && $line =~ /^\s*change-id:/i && $chk_changeid) {
> ERROR("GERRIT_CHANGE_ID",
> "Remove Gerrit Change-Id's before submitting upstream.\n" . $herecurr);
> }
> --
> 1.9.1
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web