Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1346775 > unrolled thread

[PATCH] rtc: vr41xx: remove unused function:

Back to article view | Back to linux.kernel

Contents

  [PATCH] rtc: vr41xx: remove unused function: Arnd Bergmann <arnd@arndb.de> - 2016-03-01 18:10 +0100
    Re: [PATCH] rtc: vr41xx: remove unused function: Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-01 18:40 +0100

#1346775 — [PATCH] rtc: vr41xx: remove unused function:

The vr41xx_rtc_alarm_irq_enable function is never called
has no effect other than producing a warning:

drivers/rtc/rtc-vr41xx.c:228:12: error: 'vr41xx_rtc_alarm_irq_enable' defined but not used [-Werror=unused-function]

This removes it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/rtc-vr41xx.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index f64c282275b3..68cb63ef1e44 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -225,24 +225,6 @@ static int vr41xx_rtc_ioctl(struct device *dev, unsigned int cmd, unsigned long
 	return 0;
 }
 
-static int vr41xx_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
-{
-	spin_lock_irq(&rtc_lock);
-	if (enabled) {
-		if (!alarm_enabled) {
-			enable_irq(aie_irq);
-			alarm_enabled = 1;
-		}
-	} else {
-		if (alarm_enabled) {
-			disable_irq(aie_irq);
-			alarm_enabled = 0;
-		}
-	}
-	spin_unlock_irq(&rtc_lock);
-	return 0;
-}
-
 static irqreturn_t elapsedtime_interrupt(int irq, void *dev_id)
 {
 	struct platform_device *pdev = (struct platform_device *)dev_id;
-- 
2.7.0

[toc] | [next] | [standalone]

#1346800

Hi Arnd,

On 01/03/2016 at 18:03:12 +0100, Arnd Bergmann wrote :
> The vr41xx_rtc_alarm_irq_enable function is never called
> has no effect other than producing a warning:
> 
> drivers/rtc/rtc-vr41xx.c:228:12: error: 'vr41xx_rtc_alarm_irq_enable' defined but not used [-Werror=unused-function]
> 
> This removes it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

For that one, I took Geert's patch which makes use of the function and
is a proper fix.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web