Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340291 > unrolled thread

Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

Started byJohn Dahlstrom <jodarom@SDF.ORG>
First post2016-02-23 05:40 +0100
Last post2016-02-29 23:20 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the  no_hw_rfkill DMI list John Dahlstrom <jodarom@SDF.ORG> - 2016-02-23 05:40 +0100
    Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the  no_hw_rfkill DMI list Darren Hart <dvhart@infradead.org> - 2016-02-26 20:00 +0100
      Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the  no_hw_rfkill DMI list John Dahlstrom <jodarom@SDF.ORG> - 2016-02-27 08:00 +0100
        Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the  no_hw_rfkill DMI list Darren Hart <dvhart@infradead.org> - 2016-02-29 23:20 +0100

#1340291 — Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

FromJohn Dahlstrom <jodarom@SDF.ORG>
Date2016-02-23 05:40 +0100
SubjectRe: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list
Message-ID<r5cVr-8tD-1@gated-at.bofh.it>
On Mon, 22 Feb 2016, Darren Hart wrote:

> Unfortunately, backporting this to stable is not quite so simple.
>
> First, 3.16 doesn't really work as between 3.16 and 3.17 the following patch
> landed:
>
> ce363c2 ideapad-laptop: Change Lenovo Yoga 2 series rfkill handling
>
> Which changes the name of the dmi_system_id struct from rfkill_blacklist to
> no_hw_rfkill_list.
>
> Following that, there were several additions to the list which should be applied
> before this patch to each stable kernel for which they haven't been picked up in
> order for this one to apply cleanly. Several of those are included below:
>

Despite the change in the no_hw_rfkill_list, GNU patch still yields the
correct output but with fuzz. I interpret apply cleanly to mean that
the patch must also apply with zero fuzz, such as with "patch -F 0".

In the case where the context has changed (including changes to an
enclosing struct or function), I gather that a patch exactly modified
for an older kernel is to be sent to stable@vger.kernel.org after the 
unmodified patch is accepted upstream with a commit ID.

> $ git l v3.17.. drivers/platform/x86/ideapad-laptop.c
[...]

> If you are going to specify a kernel version, you should also include the
> commits above necessary to make the patch apply cleanly. That would be a long
> list as you would need many of these for each version.
>

Thank you for that information. One commit is sufficient to apply the 
patch to all kernel versions without fuzz:

4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked

> What I'm going to do is include a single Cc to stable line without a kernel
> version. The maintainers will pull that back as far as they can using their own
> judgement. If you want this to go back earlier than they do on their own, you
> should submit it to linux-stable directly and include the Cc lines for the
> dependencies for each kernel you care to see this backported to. See the
> stable-kernel-rules for the specific formatting to accomplish this.
>

I've submitted v5 of the patch with a single Cc line with the prerequisite
kernel(s) and commit ID specified exactly.

Kind regards,

John

[toc] | [next] | [standalone]

#1344591

FromDarren Hart <dvhart@infradead.org>
Date2016-02-26 20:00 +0100
Message-ID<r6vMm-7w1-29@gated-at.bofh.it>
In reply to#1340291
On Mon, Feb 22, 2016 at 10:29:48PM -0600, John Dahlstrom wrote:
> On Mon, 22 Feb 2016, Darren Hart wrote:
> 
> >Unfortunately, backporting this to stable is not quite so simple.
> >
> >First, 3.16 doesn't really work as between 3.16 and 3.17 the following patch
> >landed:
> >
> >ce363c2 ideapad-laptop: Change Lenovo Yoga 2 series rfkill handling
> >
> >Which changes the name of the dmi_system_id struct from rfkill_blacklist to
> >no_hw_rfkill_list.
> >
> >Following that, there were several additions to the list which should be applied
> >before this patch to each stable kernel for which they haven't been picked up in
> >order for this one to apply cleanly. Several of those are included below:
> >
> 
> Despite the change in the no_hw_rfkill_list, GNU patch still yields the
> correct output but with fuzz. I interpret apply cleanly to mean that
> the patch must also apply with zero fuzz, such as with "patch -F 0".
> 
> In the case where the context has changed (including changes to an
> enclosing struct or function), I gather that a patch exactly modified
> for an older kernel is to be sent to stable@vger.kernel.org after the
> unmodified patch is accepted upstream with a commit ID.
> 
> >$ git l v3.17.. drivers/platform/x86/ideapad-laptop.c
> [...]
> 
> >If you are going to specify a kernel version, you should also include the
> >commits above necessary to make the patch apply cleanly. That would be a long
> >list as you would need many of these for each version.
> >
> 
> Thank you for that information. One commit is sufficient to apply the patch
> to all kernel versions without fuzz:
> 
> 4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked

This does not yield correct results for me on 3.17 (or 3.17.8). Do you get
different results from the following?

dvhart@dvhart-mobl5:~/source/linux/linux-pdx86 [testing]
$ git co -b 3.17 v3.17
Checking out files: 100% (36214/36214), done.
Switched to a new branch '3.17'

dvhart@dvhart-mobl5:~/source/linux/linux-pdx86 [3.17]
$ git cp 4fa9dab
[3.17 d2cdd70] ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked
 Author: Dmitry Tunin <hanipouspilot@gmail.com>
 Date: Sun Jan 18 15:44:40 2015 +0300
 1 file changed, 7 insertions(+)

dvhart@dvhart-mobl5:~/source/linux/linux-pdx86 [3.17]
$ git am ~/incoming/PATCH_v5_1-1_ideapad-laptop_Add_ideapad_Y700_15_to_the_no_hw_rfkill_DMI_list.mbox
Applying: ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list
error: patch failed: drivers/platform/x86/ideapad-laptop.c:864
error: drivers/platform/x86/ideapad-laptop.c: patch does not apply
Patch failed at 0001 ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list
The copy of the patch that failed is found in:
   /home/dvhart/source/linux/linux-pdx86/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

dvhart@dvhart-mobl5:~/source/linux/linux-pdx86 [3.17|AM 1/1]
$ patch -p1 < ~/incoming/PATCH_v5_1-1_ideapad-laptop_Add_ideapad_Y700_15_to_the_no_hw_rfkill_DMI_list.mbox 
patching file drivers/platform/x86/ideapad-laptop.c
Hunk #1 succeeded at 864 with fuzz 2.


$ cat drivers/platform/x86/ideapad-laptop.c | head -n 880 | tail -n 32

static int ideapad_acpi_add(struct platform_device *pdev)
{
	int ret, i;
	int cfg;
	struct ideapad_private *priv;
	struct acpi_device *adev;

	ret = acpi_bus_get_device(ACPI_HANDLE(&pdev->dev), &adev);
	if (ret)
		return -ENODEV;

	if (read_method_int(adev->handle, "_CFG", &cfg))
		return -ENODEV;

	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
	if (!priv)
	},
	{
		.ident = "Lenovo ideapad Y700-15ISK",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700-15ISK"),
		},
	},
	{
		.ident = "Lenovo ideapad Y700 Touch-15ISK",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 Touch-15ISK"),
		},
		return -ENOMEM;


Note that the DMI match blocks were stuffed in the middle of the
ideapad_acpi_add() function instead of the no_hw_rfkill.

> 
> >What I'm going to do is include a single Cc to stable line without a kernel
> >version. The maintainers will pull that back as far as they can using their own
> >judgement. If you want this to go back earlier than they do on their own, you
> >should submit it to linux-stable directly and include the Cc lines for the
> >dependencies for each kernel you care to see this backported to. See the
> >stable-kernel-rules for the specific formatting to accomplish this.
> >
> 
> I've submitted v5 of the patch with a single Cc line with the prerequisite
> kernel(s) and commit ID specified exactly.
> 
> Kind regards,
> 
> John
> 

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1344928

FromJohn Dahlstrom <jodarom@SDF.ORG>
Date2016-02-27 08:00 +0100
Message-ID<r6H18-7xD-5@gated-at.bofh.it>
In reply to#1344591
On Fri, 26 Feb 2016, Darren Hart wrote:
> On Mon, Feb 22, 2016 at 10:29:48PM -0600, John Dahlstrom wrote:
[...]
>> Thank you for that information. One commit is sufficient to apply the patch
>> to all kernel versions without fuzz:
>>
>> 4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked
>
> This does not yield correct results for me on 3.17 (or 3.17.8). Do you get
> different results from the following?
>
[...]
> Note that the DMI match blocks were stuffed in the middle of the
> ideapad_acpi_add() function instead of the no_hw_rfkill.

The v3, v4, and v5 patch submissions had been corrupted by spurious
whitespace inserted by my email client. I have sent a corrected version,
[PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

After submission, I verified the successful application of the patch
as received by the mailing list.

I also ran git clone, "git checkout -b 3.17 v3.17", and
"git cherry-pick 4fa9dab", followed by patch with success.

Kind regards,

John

[toc] | [prev] | [next] | [standalone]

#1346200

FromDarren Hart <dvhart@infradead.org>
Date2016-02-29 23:20 +0100
Message-ID<r7Ekx-tv-3@gated-at.bofh.it>
In reply to#1344928
On Sat, Feb 27, 2016 at 12:49:03AM -0600, John Dahlstrom wrote:
> On Fri, 26 Feb 2016, Darren Hart wrote:
> >On Mon, Feb 22, 2016 at 10:29:48PM -0600, John Dahlstrom wrote:
> [...]
> >>Thank you for that information. One commit is sufficient to apply the patch
> >>to all kernel versions without fuzz:
> >>
> >>4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked
> >
> >This does not yield correct results for me on 3.17 (or 3.17.8). Do you get
> >different results from the following?
> >
> [...]
> >Note that the DMI match blocks were stuffed in the middle of the
> >ideapad_acpi_add() function instead of the no_hw_rfkill.
> 
> The v3, v4, and v5 patch submissions had been corrupted by spurious
> whitespace inserted by my email client. I have sent a corrected version,
> [PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list
> 
> After submission, I verified the successful application of the patch
> as received by the mailing list.
> 
> I also ran git clone, "git checkout -b 3.17 v3.17", and
> "git cherry-pick 4fa9dab", followed by patch with success.

OK, I've replaced the one in for-next with this one.

I'm not keen on backporting only certain dmi match patches back to stable, but I
don't want to discourage people from working to get the hardware they care about
supported in stable either.

Thanks for sticking with it and seeing this through to completion.

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web