Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344824 > unrolled thread

[PATCH 0/4] bcm2835 SDHOST controller

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] bcm2835 SDHOST controller Eric Anholt <eric@anholt.net> - 2016-02-27 00:20 +0100
    [PATCH 4/4] ARM: bcm2835: Enable SDHOST by default. Eric Anholt <eric@anholt.net> - 2016-02-27 00:20 +0100
    Re: [PATCH 0/4] bcm2835 SDHOST controller Martin Sperl <martin@sperl.org> - 2016-02-29 11:10 +0100

#1344824 — [PATCH 0/4] bcm2835 SDHOST controller

Here's a series to enable the SDHOST controller.  It gives us better
performance than our old sdhci-bcm2835.c.  The downstream Raspberry Pi
kernel appears to be using this controller by default at this point.

I've tried to do some testing on it (mounting filesystem,
reading/writing files, speed tests), but I'm not sure what a good
testing regimen for storage drivers would be.

Eric Anholt (4):
  dt-bindings: Add binding for brcm,bcm2835-sdhost.
  mmc: bcm2835-sdhost: Add new driver for the internal SD controller.
  ARM: bcm2835: Include SDHOST in the device tree.
  ARM: bcm2835: Enable SDHOST by default.

 .../bindings/mmc/brcm,bcm2835-sdhost.txt           |   25 +
 arch/arm/boot/dts/bcm2835-rpi.dtsi                 |   10 +-
 arch/arm/boot/dts/bcm283x.dtsi                     |    8 +
 drivers/mmc/host/Kconfig                           |    9 +
 drivers/mmc/host/Makefile                          |    1 +
 drivers/mmc/host/bcm2835-sdhost.c                  | 1652 ++++++++++++++++++++
 6 files changed, 1704 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
 create mode 100644 drivers/mmc/host/bcm2835-sdhost.c

-- 
2.7.0

[toc] | [next] | [standalone]

#1344827 — [PATCH 4/4] ARM: bcm2835: Enable SDHOST by default.

This improves read speed on my SD card (as reported by hdparm -t) from
10.15MB/sec to 16.70MB/sec.  Once we add slave DMA, we can get to
18.45MB/sec.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 arch/arm/boot/dts/bcm2835-rpi.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index b8efd41..65d3594 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -65,10 +65,18 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&emmc_gpio48>;
 
-	status = "okay";
 	bus-width = <4>;
 };
 
+&sdhost {
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdhost_gpio48>;
+
+	bus-width = <4>;
+
+	status = "okay";
+};
+
 &pwm {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pwm0_gpio40 &pwm1_gpio45>;
-- 
2.7.0

[toc] | [prev] | [next] | [standalone]

#1345616

> On 27.02.2016, at 00:05, Eric Anholt <eric@anholt.net> wrote:
> 
> Here's a series to enable the SDHOST controller.  It gives us better
> performance than our old sdhci-bcm2835.c.  The downstream Raspberry Pi
> kernel appears to be using this controller by default at this point.
> 
> I've tried to do some testing on it (mounting filesystem,
> reading/writing files, speed tests), but I'm not sure what a good
> testing regimen for storage drivers would be.
> 
> Eric Anholt (4):
>  dt-bindings: Add binding for brcm,bcm2835-sdhost.
>  mmc: bcm2835-sdhost: Add new driver for the internal SD controller.
>  ARM: bcm2835: Include SDHOST in the device tree.
>  ARM: bcm2835: Enable SDHOST by default.

This patchset misses defconfig changes to enable
the new sdhost driver.

So we end up with a default kernel
without the sdhost driver compiled in
but with sdhost enabled in the default device-tree (patch4)
resulting in a system that does not boot.

Thanks,
	Martin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web