Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1343295 > unrolled thread

[PATCH] ARM: prima2: always enable reset controller

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: prima2: always enable reset controller Arnd Bergmann <arnd@arndb.de> - 2016-02-25 17:30 +0100
    Re: [PATCH] ARM: prima2: always enable reset controller Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-25 18:30 +0100
      Re: [PATCH] ARM: prima2: always enable reset controller Arnd Bergmann <arnd@arndb.de> - 2016-02-26 17:50 +0100

#1343295 — [PATCH] ARM: prima2: always enable reset controller

The atlas7 clock controller driver registers a reset controller
for itself, which causes a link error when the subsystem is
disabled:

drivers/built-in.o: In function `atlas7_clk_init':
drivers/clk/sirf/clk-atlas7.c:1681: undefined reference to `reset_controller_register'

As the clk driver does not have a Kconfig symbol for itself
but it always built-in when the platform is enabled, we have
to ensure that the reset controller subsystem is also built-in
in this case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 301c5d29402e ("clk: sirf: add CSR atlas7 clk and reset support")
---
 arch/arm/mach-prima2/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-prima2/Kconfig b/arch/arm/mach-prima2/Kconfig
index 59cafaf097c0..86b7c859784f 100644
--- a/arch/arm/mach-prima2/Kconfig
+++ b/arch/arm/mach-prima2/Kconfig
@@ -2,6 +2,7 @@ menuconfig ARCH_SIRF
 	bool "CSR SiRF"
 	depends on ARCH_MULTI_V6_V7
 	select ARCH_HAS_RESET_CONTROLLER
+	select RESET_CONTROLLER
 	select ARCH_REQUIRE_GPIOLIB
 	select GENERIC_IRQ_CHIP
 	select NO_IOPORT_MAP
-- 
2.7.0

[toc] | [next] | [standalone]

#1343343

Am Donnerstag, den 25.02.2016, 17:27 +0100 schrieb Arnd Bergmann:
> The atlas7 clock controller driver registers a reset controller
> for itself, which causes a link error when the subsystem is
> disabled:
> 
> drivers/built-in.o: In function `atlas7_clk_init':
> drivers/clk/sirf/clk-atlas7.c:1681: undefined reference to `reset_controller_register'
> 
> As the clk driver does not have a Kconfig symbol for itself
> but it always built-in when the platform is enabled, we have
> to ensure that the reset controller subsystem is also built-in
> in this case.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 301c5d29402e ("clk: sirf: add CSR atlas7 clk and reset support")

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

[toc] | [prev] | [next] | [standalone]

#1344447

On Thursday 25 February 2016 18:25:32 Philipp Zabel wrote:
> Am Donnerstag, den 25.02.2016, 17:27 +0100 schrieb Arnd Bergmann:
> > The atlas7 clock controller driver registers a reset controller
> > for itself, which causes a link error when the subsystem is
> > disabled:
> > 
> > drivers/built-in.o: In function `atlas7_clk_init':
> > drivers/clk/sirf/clk-atlas7.c:1681: undefined reference to `reset_controller_register'
> > 
> > As the clk driver does not have a Kconfig symbol for itself
> > but it always built-in when the platform is enabled, we have
> > to ensure that the reset controller subsystem is also built-in
> > in this case.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 301c5d29402e ("clk: sirf: add CSR atlas7 clk and reset support")
> 
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> 

Applied to next/fixes-non-critical, thanks!

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web