Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1345078 > unrolled thread
| Started by | Jannik Becher <becher.jannik@gmail.com> |
|---|---|
| First post | 2016-02-27 20:50 +0100 |
| Last post | 2016-02-27 21:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Media: usb: hackrf: fixed a style issue Jannik Becher <becher.jannik@gmail.com> - 2016-02-27 20:50 +0100
Re: [PATCH] Media: usb: hackrf: fixed a style issue Antonio Ospite <ao2@ao2.it> - 2016-02-27 21:20 +0100
| From | Jannik Becher <becher.jannik@gmail.com> |
|---|---|
| Date | 2016-02-27 20:50 +0100 |
| Subject | [PATCH] Media: usb: hackrf: fixed a style issue |
| Message-ID | <r6T2h-7Pm-1@gated-at.bofh.it> |
Fixed a coding style issue.
Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com>
---
drivers/media/usb/hackrf/hackrf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
index 9e700ca..186ef2d 100644
--- a/drivers/media/usb/hackrf/hackrf.c
+++ b/drivers/media/usb/hackrf/hackrf.c
@@ -249,6 +249,7 @@ static int hackrf_set_params(struct hackrf_dev *dev)
unsigned int uitmp, uitmp1, uitmp2;
const bool rx = test_bit(RX_ON, &dev->flags);
const bool tx = test_bit(TX_ON, &dev->flags);
+
static const struct {
u32 freq;
} bandwidth_lut[] = {
--
2.5.0
[toc] | [next] | [standalone]
| From | Antonio Ospite <ao2@ao2.it> |
|---|---|
| Date | 2016-02-27 21:20 +0100 |
| Message-ID | <r6Tvj-8g6-3@gated-at.bofh.it> |
| In reply to | #1345078 |
On Sat, 27 Feb 2016 20:42:36 +0100
Jannik Becher <becher.jannik@gmail.com> wrote:
> Fixed a coding style issue.
>
You should be more specific: which style issue?
See also my comment below.
> Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com>
> ---
> drivers/media/usb/hackrf/hackrf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c
> index 9e700ca..186ef2d 100644
> --- a/drivers/media/usb/hackrf/hackrf.c
> +++ b/drivers/media/usb/hackrf/hackrf.c
> @@ -249,6 +249,7 @@ static int hackrf_set_params(struct hackrf_dev *dev)
> unsigned int uitmp, uitmp1, uitmp2;
> const bool rx = test_bit(RX_ON, &dev->flags);
> const bool tx = test_bit(TX_ON, &dev->flags);
> +
> static const struct {
> u32 freq;
> } bandwidth_lut[] = {
If this has been found by scripts/checkpatch.pl as:
WARNING: Missing a blank line after declarations
#252: FILE: drivers/media/usb/hackrf/hackrf.c:252:
+ const bool tx = test_bit(TX_ON, &dev->flags);
+ static const struct {
it is a false positive, as the code which follows the blank line is a
declaration too.
Ciao ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web