Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1344885 > unrolled thread

[RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs

Started byscott.lawson@intel.com
First post2016-02-27 03:10 +0100
Last post2016-02-27 12:30 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs scott.lawson@intel.com - 2016-02-27 03:10 +0100
    Re: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA  RAID device IDs Christoph Hellwig <hch@infradead.org> - 2016-02-27 10:00 +0100
    Re: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA  RAID device IDs Tejun Heo <tj@kernel.org> - 2016-02-27 12:30 +0100

#1344885 — [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs

Fromscott.lawson@intel.com
Date2016-02-27 03:10 +0100
Subject[RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs
Message-ID<r6Cut-4dT-3@gated-at.bofh.it>
From: Scott Lawson <scott.lawson@intel.com>

These PCI device IDs in the AHCI driver conflict with proprietary drivers,
preventing them from loading.

Signed-off-by: Scott Lawson <scott.lawson@intel.com>
---
 drivers/ata/ahci.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 546a369..3394492 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -370,11 +370,9 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa182), board_ahci }, /* Lewisburg AHCI*/
 	{ PCI_VDEVICE(INTEL, 0xa184), board_ahci }, /* Lewisburg RAID*/
-	{ PCI_VDEVICE(INTEL, 0xa186), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa18e), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa202), board_ahci }, /* Lewisburg AHCI*/
 	{ PCI_VDEVICE(INTEL, 0xa204), board_ahci }, /* Lewisburg RAID*/
-	{ PCI_VDEVICE(INTEL, 0xa206), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa20e), board_ahci }, /* Lewisburg RAID*/
 
 	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
-- 
1.9.1

[toc] | [next] | [standalone]


#1344950 — Re: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs

FromChristoph Hellwig <hch@infradead.org>
Date2016-02-27 10:00 +0100
SubjectRe: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs
Message-ID<r6ITg-la-3@gated-at.bofh.it>
In reply to#1344885
On Fri, Feb 26, 2016 at 10:09:29AM -0800, scott.lawson@intel.com wrote:
> From: Scott Lawson <scott.lawson@intel.com>
> 
> These PCI device IDs in the AHCI driver conflict with proprietary drivers,
> preventing them from loading.

And that's a good thing!

[toc] | [prev] | [next] | [standalone]


#1344991 — Re: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs

FromTejun Heo <tj@kernel.org>
Date2016-02-27 12:30 +0100
SubjectRe: [RFC] AHCI: Remove conflicting Intel Lewisburg 3rd-party SATA RAID device IDs
Message-ID<r6Ler-2b9-25@gated-at.bofh.it>
In reply to#1344885
On Fri, Feb 26, 2016 at 10:09:29AM -0800, scott.lawson@intel.com wrote:
> From: Scott Lawson <scott.lawson@intel.com>
> 
> These PCI device IDs in the AHCI driver conflict with proprietary drivers,
> preventing them from loading.

So, the default ahci driver can't attach if these PCI IDs are in use?
I don't think breaking the upstream kernel for a proprietary driver is
a good idea.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web