Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340850 > unrolled thread

[PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes

Started byRoger Quadros <rogerq@ti.com>
First post2016-02-23 17:40 +0100
Last post2016-02-29 18:20 +0100
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes Roger Quadros <rogerq@ti.com> - 2016-02-23 17:40 +0100
    [PATCH v7 4/9] ARM: dts: am437x: Disable wait pin monitoring for NAND Roger Quadros <rogerq@ti.com> - 2016-02-23 17:40 +0100
    [PATCH v7 8/9] ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND Roger Quadros <rogerq@ti.com> - 2016-02-23 17:40 +0100
    Re: [PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes Tony Lindgren <tony@atomide.com> - 2016-02-26 19:50 +0100
      Re: [PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes Roger Quadros <rogerq@ti.com> - 2016-02-29 17:20 +0100
        Re: [PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes Tony Lindgren <tony@atomide.com> - 2016-02-29 18:20 +0100

#1340850 — [PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes

FromRoger Quadros <rogerq@ti.com>
Date2016-02-23 17:40 +0100
Subject[PATCH v7 0/9] ARM: dts: omap2+: GPMC NAND node fixes
Message-ID<r5oae-7Zs-7@gated-at.bofh.it>
Hi Tony,

These patches are a preparatory step towards the NAND DT cleanup
done in [1].

They mostly deal with adding the missing compatible property and
interrupt resources and fixing up register resources for the
NAND nodes.

Patches based on v4.5-rc1.

Tested on dra7-evm, am437x-gp-evm and omap3-beagle.

cheers,
-roger

[1] - http://article.gmane.org/gmane.linux.kernel/2156857

--
Roger Quadros (9):
  ARM: dts: dra7: Fix NAND device nodes.
  ARM: dts: dra7: Remove redundant nand property
  ARM: dts: am437x: Fix NAND device nodes
  ARM: dts: am437x: Disable wait pin monitoring for NAND
  ARM: dts: am335x: Fix NAND device nodes
  ARM: dts: am335x: Disable wait pin monitoring for NAND
  ARM: dts: dm816x: Fix NAND device nodes
  ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND
  ARM: dts: omap3: Fix NAND device nodess

 arch/arm/boot/dts/am335x-baltos-ir5221.dts        |  9 +++++----
 arch/arm/boot/dts/am335x-chilisom.dtsi            |  8 +++++---
 arch/arm/boot/dts/am335x-cm-t335.dts              | 10 ++++++----
 arch/arm/boot/dts/am335x-evm.dts                  |  7 ++++---
 arch/arm/boot/dts/am335x-igep0033.dtsi            |  8 +++++---
 arch/arm/boot/dts/am335x-phycore-som.dtsi         |  8 +++++---
 arch/arm/boot/dts/am33xx.dtsi                     |  2 ++
 arch/arm/boot/dts/am4372.dtsi                     |  2 ++
 arch/arm/boot/dts/am437x-cm-t43.dts               | 11 +++++------
 arch/arm/boot/dts/am437x-gp-evm.dts               |  8 +++++---
 arch/arm/boot/dts/am43x-epos-evm.dts              |  8 +++++---
 arch/arm/boot/dts/dm8168-evm.dts                  |  8 +++++---
 arch/arm/boot/dts/dm816x.dtsi                     |  2 ++
 arch/arm/boot/dts/dra7-evm.dts                    |  7 +++++--
 arch/arm/boot/dts/dra7.dtsi                       |  2 ++
 arch/arm/boot/dts/dra72-evm.dts                   |  7 +++++--
 arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts |  3 ++-
 arch/arm/boot/dts/logicpd-torpedo-som.dtsi        |  8 ++++++--
 arch/arm/boot/dts/omap3-beagle.dts                |  5 ++++-
 arch/arm/boot/dts/omap3-cm-t3x.dtsi               |  6 +++++-
 arch/arm/boot/dts/omap3-devkit8000-common.dtsi    |  4 ++++
 arch/arm/boot/dts/omap3-evm-37xx.dts              |  8 ++++++--
 arch/arm/boot/dts/omap3-gta04.dtsi                |  4 ++++
 arch/arm/boot/dts/omap3-igep.dtsi                 |  6 +++++-
 arch/arm/boot/dts/omap3-igep0020-common.dtsi      |  4 ++--
 arch/arm/boot/dts/omap3-igep0030-common.dtsi      |  4 ++++
 arch/arm/boot/dts/omap3-ldp.dts                   | 10 +++++++---
 arch/arm/boot/dts/omap3-lilly-a83x.dtsi           |  6 +++++-
 arch/arm/boot/dts/omap3-overo-base.dtsi           |  6 +++++-
 arch/arm/boot/dts/omap3-pandora-common.dtsi       |  4 ++++
 arch/arm/boot/dts/omap3-tao3530.dtsi              |  6 +++++-
 arch/arm/boot/dts/omap3.dtsi                      |  2 ++
 arch/arm/boot/dts/omap3430-sdp.dts                |  6 +++++-
 33 files changed, 143 insertions(+), 56 deletions(-)

-- 
2.5.0

[toc] | [next] | [standalone]

#1340852 — [PATCH v7 4/9] ARM: dts: am437x: Disable wait pin monitoring for NAND

FromRoger Quadros <rogerq@ti.com>
Date2016-02-23 17:40 +0100
Subject[PATCH v7 4/9] ARM: dts: am437x: Disable wait pin monitoring for NAND
Message-ID<r5oag-7Zs-51@gated-at.bofh.it>
In reply to#1340850
The NAND Ready/Busy# line is connected to GPMC_WAIT0 pin and
can't be used for wait state insertion for NAND I/O read/write.
So disable read/write wait monitoring as per Reference Manual's
suggestion [1].

[1] AM437x TRM: SPRUHL7D: 9.1.3.3.12.2 NAND Device-Ready Pin

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/am437x-cm-t43.dts  | 5 -----
 arch/arm/boot/dts/am437x-gp-evm.dts  | 2 --
 arch/arm/boot/dts/am43x-epos-evm.dts | 2 --
 3 files changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-cm-t43.dts b/arch/arm/boot/dts/am437x-cm-t43.dts
index 4aa5357..9551c47 100644
--- a/arch/arm/boot/dts/am437x-cm-t43.dts
+++ b/arch/arm/boot/dts/am437x-cm-t43.dts
@@ -170,17 +170,12 @@
 		gpmc,access-ns = <64>;
 		gpmc,rd-cycle-ns = <82>;
 		gpmc,wr-cycle-ns = <82>;
-		gpmc,wait-on-read = "true";
-		gpmc,wait-on-write = "true";
 		gpmc,bus-turnaround-ns = <0>;
 		gpmc,cycle2cycle-delay-ns = <0>;
 		gpmc,clk-activation-ns = <0>;
-		gpmc,wait-monitoring-ns = <0>;
 		gpmc,wr-access-ns = <40>;
 		gpmc,wr-data-mux-bus-ns = <0>;
 
-		gpmc,wait-pin = <0>;
-
 		#address-cells = <1>;
 		#size-cells = <1>;
 		/* MTD partition table */
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 7081b88..b3cfedb 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -837,11 +837,9 @@
 		gpmc,access-ns = <30>;
 		gpmc,rd-cycle-ns = <40>;
 		gpmc,wr-cycle-ns = <40>;
-		gpmc,wait-pin = <0>;
 		gpmc,bus-turnaround-ns = <0>;
 		gpmc,cycle2cycle-delay-ns = <0>;
 		gpmc,clk-activation-ns = <0>;
-		gpmc,wait-monitoring-ns = <0>;
 		gpmc,wr-access-ns = <40>;
 		gpmc,wr-data-mux-bus-ns = <0>;
 		/* MTD partition table */
diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index 12b08cf..b1f2bd6 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -586,11 +586,9 @@
 		gpmc,access-ns = <30>; /* tCEA + 4*/
 		gpmc,rd-cycle-ns = <40>;
 		gpmc,wr-cycle-ns = <40>;
-		gpmc,wait-pin = <0>;
 		gpmc,bus-turnaround-ns = <0>;
 		gpmc,cycle2cycle-delay-ns = <0>;
 		gpmc,clk-activation-ns = <0>;
-		gpmc,wait-monitoring-ns = <0>;
 		gpmc,wr-access-ns = <40>;
 		gpmc,wr-data-mux-bus-ns = <0>;
 		/* MTD partition table */
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1340854 — [PATCH v7 8/9] ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND

FromRoger Quadros <rogerq@ti.com>
Date2016-02-23 17:40 +0100
Subject[PATCH v7 8/9] ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND
Message-ID<r5oag-7Zs-55@gated-at.bofh.it>
In reply to#1340850
The NAND Ready/Busy# line is connected to GPMC_WAIT0 pin and
can't be used for wait state insertion for NAND I/O read/write.
So disable read/write wait monitoring as per Reference Manual's
suggestion [1].

[1] dm816x TRM: SPRUGX8C: 9.2.4.12.2 NAND Device-Ready Pin

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/dm8168-evm.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/dm8168-evm.dts b/arch/arm/boot/dts/dm8168-evm.dts
index 0cb1003..f50348b 100644
--- a/arch/arm/boot/dts/dm8168-evm.dts
+++ b/arch/arm/boot/dts/dm8168-evm.dts
@@ -111,12 +111,9 @@
 		gpmc,access-ns = <64>;
 		gpmc,rd-cycle-ns = <82>;
 		gpmc,wr-cycle-ns = <82>;
-		gpmc,wait-on-read = "true";
-		gpmc,wait-on-write = "true";
 		gpmc,bus-turnaround-ns = <0>;
 		gpmc,cycle2cycle-delay-ns = <0>;
 		gpmc,clk-activation-ns = <0>;
-		gpmc,wait-monitoring-ns = <0>;
 		gpmc,wr-access-ns = <40>;
 		gpmc,wr-data-mux-bus-ns = <0>;
 		partition@0 {
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1344571

FromTony Lindgren <tony@atomide.com>
Date2016-02-26 19:50 +0100
Message-ID<r6vCH-7sv-37@gated-at.bofh.it>
In reply to#1340850
Hi,

* Roger Quadros <rogerq@ti.com> [160223 08:37]:
> Hi Tony,
> 
> These patches are a preparatory step towards the NAND DT cleanup
> done in [1].

OK great NAND keeps working for me. I've pushed these into an
immutable branch against v4.5-r1 named omap-for-v4.6/dt-gpmc.

I have also merged that branch into omap-for-v4.6/dt.

Please feel free to use omap-for-v4.6/dt-gpmc branch as an
immutable base for the GPMC driver changes.

And please let me know what additional patches I may need to
apply into omap-for-v4.6/dt for new files that are not in
omap-for-v4.6/dt-gpmc.

Note that I also fixed two typos below:

> Roger Quadros (9):
>   ARM: dts: dra7: Fix NAND device nodes.

I removed the trailing period here.

>   ARM: dts: dra7: Remove redundant nand property
>   ARM: dts: am437x: Fix NAND device nodes
>   ARM: dts: am437x: Disable wait pin monitoring for NAND
>   ARM: dts: am335x: Fix NAND device nodes
>   ARM: dts: am335x: Disable wait pin monitoring for NAND
>   ARM: dts: dm816x: Fix NAND device nodes
>   ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND
>   ARM: dts: omap3: Fix NAND device nodess

I removed the extra s in nodes here.

Regards,

Tony

[toc] | [prev] | [next] | [standalone]

#1345945

FromRoger Quadros <rogerq@ti.com>
Date2016-02-29 17:20 +0100
Message-ID<r7yIa-5le-17@gated-at.bofh.it>
In reply to#1344571
Tony,

On 26/02/16 20:44, Tony Lindgren wrote:
> Hi,
> 
> * Roger Quadros <rogerq@ti.com> [160223 08:37]:
>> Hi Tony,
>>
>> These patches are a preparatory step towards the NAND DT cleanup
>> done in [1].
> 
> OK great NAND keeps working for me. I've pushed these into an
> immutable branch against v4.5-r1 named omap-for-v4.6/dt-gpmc.
> 
> I have also merged that branch into omap-for-v4.6/dt.
> 
> Please feel free to use omap-for-v4.6/dt-gpmc branch as an
> immutable base for the GPMC driver changes.

Thanks.

> 
> And please let me know what additional patches I may need to
> apply into omap-for-v4.6/dt for new files that are not in
> omap-for-v4.6/dt-gpmc.

We need to fix the following
gpmc node in dm814x.dtsi + nand node in dra62x-j5eco-evm.dts + nand node in dm8148-evm.


> 
> Note that I also fixed two typos below:

Thanks :)

cheers,
-roger

> 
>> Roger Quadros (9):
>>   ARM: dts: dra7: Fix NAND device nodes.
> 
> I removed the trailing period here.
> 
>>   ARM: dts: dra7: Remove redundant nand property
>>   ARM: dts: am437x: Fix NAND device nodes
>>   ARM: dts: am437x: Disable wait pin monitoring for NAND
>>   ARM: dts: am335x: Fix NAND device nodes
>>   ARM: dts: am335x: Disable wait pin monitoring for NAND
>>   ARM: dts: dm816x: Fix NAND device nodes
>>   ARM: dts: dm8168-evm: ARM: dts: Disable wait pin monitoring for NAND
>>   ARM: dts: omap3: Fix NAND device nodess
> 
> I removed the extra s in nodes here.
> 
> Regards,
> 
> Tony
>

[toc] | [prev] | [next] | [standalone]

#1346006

FromTony Lindgren <tony@atomide.com>
Date2016-02-29 18:20 +0100
Message-ID<r7zEe-5WZ-3@gated-at.bofh.it>
In reply to#1345945
* Roger Quadros <rogerq@ti.com> [160229 08:14]:
> On 26/02/16 20:44, Tony Lindgren wrote:
> > And please let me know what additional patches I may need to
> > apply into omap-for-v4.6/dt for new files that are not in
> > omap-for-v4.6/dt-gpmc.
> 
> We need to fix the following
> gpmc node in dm814x.dtsi + nand node in dra62x-j5eco-evm.dts + nand node in dm8148-evm.

OK can you send that separately and I'll apply it?

Regards,

Tony

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web