Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1340579 > unrolled thread
| Started by | Eli Billauer <eli.billauer@gmail.com> |
|---|---|
| First post | 2016-02-23 13:20 +0100 |
| Last post | 2016-02-23 17:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] char: xillybus: Fix internal data structure initialization Eli Billauer <eli.billauer@gmail.com> - 2016-02-23 13:20 +0100
Re: [PATCH] char: xillybus: Fix internal data structure initialization Greg KH <gregkh@linuxfoundation.org> - 2016-02-23 16:30 +0100
Re: [PATCH] char: xillybus: Fix internal data structure initialization Eli Billauer <eli.billauer@gmail.com> - 2016-02-23 17:00 +0100
| From | Eli Billauer <eli.billauer@gmail.com> |
|---|---|
| Date | 2016-02-23 13:20 +0100 |
| Subject | [PATCH] char: xillybus: Fix internal data structure initialization |
| Message-ID | <r5k6D-5fs-25@gated-at.bofh.it> |
Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
---
drivers/char/xillybus/xillybus_core.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
index 77d6c12..dcd19f3 100644
--- a/drivers/char/xillybus/xillybus_core.c
+++ b/drivers/char/xillybus/xillybus_core.c
@@ -509,7 +509,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep,
channel->log2_element_size = ((format > 2) ?
2 : format);
- bytebufsize = channel->rd_buf_size = bufsize *
+ bytebufsize = bufsize *
(1 << channel->log2_element_size);
buffers = devm_kcalloc(dev, bufnum,
@@ -523,6 +523,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep,
if (!is_writebuf) {
channel->num_rd_buffers = bufnum;
+ channel->rd_buf_size = bytebufsize;
channel->rd_allow_partial = allowpartial;
channel->rd_synchronous = synchronous;
channel->rd_exclusive_open = exclusive_open;
@@ -533,6 +534,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep,
bufnum, bytebufsize);
} else if (channelnum > 0) {
channel->num_wr_buffers = bufnum;
+ channel->wr_buf_size = bytebufsize;
channel->seekable = seekable;
channel->wr_supports_nonempty = supports_nonempty;
--
1.7.2.3
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-02-23 16:30 +0100 |
| Subject | Re: [PATCH] char: xillybus: Fix internal data structure initialization |
| Message-ID | <r5n4u-7ic-11@gated-at.bofh.it> |
| In reply to | #1340579 |
On Tue, Feb 23, 2016 at 01:41:28PM +0200, Eli Billauer wrote: > > Signed-off-by: Eli Billauer <eli.billauer@gmail.com> > --- > drivers/char/xillybus/xillybus_core.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) I can't accept patches without any changelog information :(
[toc] | [prev] | [next] | [standalone]
| From | Eli Billauer <eli.billauer@gmail.com> |
|---|---|
| Date | 2016-02-23 17:00 +0100 |
| Message-ID | <r5nxv-7tJ-9@gated-at.bofh.it> |
| In reply to | #1340780 |
Oops. Didn't know it was required. I'll resubmit this patch soon. Sorry. Eli On 23/02/16 17:22, Greg KH wrote: > On Tue, Feb 23, 2016 at 01:41:28PM +0200, Eli Billauer wrote: > >> Signed-off-by: Eli Billauer<eli.billauer@gmail.com> >> --- >> drivers/char/xillybus/xillybus_core.c | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> > I can't accept patches without any changelog information :( > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web