Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342959 > unrolled thread

Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info() Ingo Molnar <mingo@kernel.org> - 2016-02-25 09:30 +0100
    Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info() Chen Yucong <slaoub@gmail.com> - 2016-02-25 13:20 +0100

#1342959 — Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info()

* Chen Yucong <slaoub@gmail.com> wrote:

> arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info().
> This patch converts all of printk(KERN_INFO ) to pr_info() for
> arch/x86 directory.
> 
> Signed-off-by: Chen Yucong <slaoub@gmail.com>

>  85 files changed, 332 insertions(+), 394 deletions(-)

So what this changelog is missing is how it was ensured that the printk output did 
not change.

Thanks,

	Ingo

[toc] | [next] | [standalone]

#1343136

On Thu, 2016-02-25 at 09:22 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@gmail.com> wrote:
> 
> > arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info().
> > This patch converts all of printk(KERN_INFO ) to pr_info() for
> > arch/x86 directory.
> > 
> > Signed-off-by: Chen Yucong <slaoub@gmail.com>
> 
> >  85 files changed, 332 insertions(+), 394 deletions(-)
> 
> So what this changelog is missing is how it was ensured that the printk output did 
> not change.
> 
 The previously committed patch was applied to a particular directory.
This involved all printk(KERN_<LEVEL>), including `ugly` pr_debug().

However this patch are only related to printk(KERN_INFO ...), pr_info()
is less dangerous than pr_debug(). The macro body of pr_info() is
simple and definite, without any conditional options.

An theme to notice: this patch also refers to only a few pr_err(), and
if it is feasible, the next patch will covert all printk(KERN_ERR ) to
pr_err(). This might be a less risky way for conversion.

thx!
   cyc

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web