Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340996 > unrolled thread

Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.

Started byRob Herring <robh@kernel.org>
First post2016-02-23 21:20 +0100
Last post2016-02-25 04:50 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Rob Herring <robh@kernel.org> - 2016-02-23 21:20 +0100
    Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Scott Wood <oss@buserror.net> - 2016-02-23 21:30 +0100
      Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Scott Wood <oss@buserror.net> - 2016-02-25 04:20 +0100
        Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Scott Wood <oss@buserror.net> - 2016-02-25 07:00 +0100
        RE: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Qiang Zhao <qiang.zhao@nxp.com> - 2016-02-25 07:00 +0100
      RE: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree  bindings. Qiang Zhao <qiang.zhao@nxp.com> - 2016-02-25 04:50 +0100

#1340996 — Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.

FromRob Herring <robh@kernel.org>
Date2016-02-23 21:20 +0100
SubjectRe: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
Message-ID<r5rB8-1Z5-19@gated-at.bofh.it>
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> Add IC, SI and SIRAM document of QE to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> 	- Add interrupt-controller in Required properties
> 	- delete address-cells and size-cells for qe-si and qe-siram
> 
>  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> index 4f89302..84052a7 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> @@ -69,6 +69,56 @@ Example:
>  	};
>       };
>  
> +* Interrupt Controller (IC)
> +
> +Required properties:
> +- compatible : should be "fsl,qe-ic".

> +- compatible : should be "fsl,qe-si".

> +- compatible : should be "fsl,qe-siram".

These compatible strings are all a bit generic and should have SoC 
specific compatible strings.

Rob

[toc] | [next] | [standalone]

#1341006

FromScott Wood <oss@buserror.net>
Date2016-02-23 21:30 +0100
Message-ID<r5rKP-24m-53@gated-at.bofh.it>
In reply to#1340996
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > Add IC, SI and SIRAM document of QE to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > 
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > 	- Add interrupt-controller in Required properties
> > 	- delete address-cells and size-cells for qe-si and qe-siram
> > 
> >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > ++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > index 4f89302..84052a7 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > @@ -69,6 +69,56 @@ Example:
> >  	};
> >       };
> >  
> > +* Interrupt Controller (IC)
> > +
> > +Required properties:
> > +- compatible : should be "fsl,qe-ic".
> 
> > +- compatible : should be "fsl,qe-si".
> 
> > +- compatible : should be "fsl,qe-siram".
> 
> These compatible strings are all a bit generic and should have SoC 
> specific compatible strings.

I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
should be documented even if a more specific compatible is also added.

-Scott

[toc] | [prev] | [next] | [standalone]

#1342746

FromScott Wood <oss@buserror.net>
Date2016-02-25 04:20 +0100
Message-ID<r5UD9-6ag-55@gated-at.bofh.it>
In reply to#1341006
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> On Wed, 2016-02-24 at 04:20  AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Wednesday, February 24, 2016 4:20 AM
> > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
> > tree
> > bindings.
> > 
> > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > Add IC, SI and SIRAM document of QE to
> > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > 
> > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > ---
> > > > Changes for v2
> > > > 	- Add interrupt-controller in Required properties
> > > > 	- delete address-cells and size-cells for qe-si and qe-siram
> > > > 
> > > >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > > > ++++++++++++++++++++++
> > > >  1 file changed, 50 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > index 4f89302..84052a7 100644
> > > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > @@ -69,6 +69,56 @@ Example:
> > > >  	};
> > > >       };
> > > > 
> > > > +* Interrupt Controller (IC)
> > > > +
> > > > +Required properties:
> > > > +- compatible : should be "fsl,qe-ic".
> > > 
> > > > +- compatible : should be "fsl,qe-si".
> > > 
> > > > +- compatible : should be "fsl,qe-siram".
> > > 
> > > These compatible strings are all a bit generic and should have SoC
> > > specific compatible strings.
> > 
> > I don't know about si/siram, but "fsl,qe-ic" has been around since 2008,
> > so it
> > should be documented even if a more specific compatible is also added.
> 
> Agree, and si/siram are also has been around since 2008.

Where?  I couldn't find them when grepping.

> In addition, I don’t think it is needed to add specific compatible, because
> they are
> the same in qe-supported soc.

How do we know that they are 100% the same?

-Scott

[toc] | [prev] | [next] | [standalone]

#1342831

FromScott Wood <oss@buserror.net>
Date2016-02-25 07:00 +0100
Message-ID<r5X7X-7HS-5@gated-at.bofh.it>
In reply to#1342746
On Thu, 2016-02-25 at 05:55 +0000, Qiang Zhao wrote:
> On Thu, 2016-02-25 at 11:12  AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Thursday, February 25, 2016 11:12 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
> > tree
> > bindings.
> > 
> > On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> > > On Wed, 2016-02-24 at 04:20  AM, Scott Wood wrote:
> > > > -----Original Message-----
> > > > From: Scott Wood [mailto:oss@buserror.net]
> > > > Sent: Wednesday, February 24, 2016 4:20 AM
> > > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
> > > > device tree bindings.
> > > > 
> > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > > > Add IC, SI and SIRAM document of QE to
> > > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > 
> > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > > ---
> > > > > > Changes for v2
> > > > > > 	- Add interrupt-controller in Required properties
> > > > > > 	- delete address-cells and size-cells for qe-si and qe-siram
> > > > > > 
> > > > > >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > > > > > ++++++++++++++++++++++
> > > > > >  1 file changed, 50 insertions(+)
> > > > > > 
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > index 4f89302..84052a7 100644
> > > > > > ---
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx
> > > > > > +++ t
> > > > > > @@ -69,6 +69,56 @@ Example:
> > > > > >  	};
> > > > > >       };
> > > > > > 
> > > > > > +* Interrupt Controller (IC)
> > > > > > +
> > > > > > +Required properties:
> > > > > > +- compatible : should be "fsl,qe-ic".
> > > > > 
> > > > > > +- compatible : should be "fsl,qe-si".
> > > > > 
> > > > > > +- compatible : should be "fsl,qe-siram".
> > > > > 
> > > > > These compatible strings are all a bit generic and should have SoC
> > > > > specific compatible strings.
> > > > 
> > > > I don't know about si/siram, but "fsl,qe-ic" has been around since
> > > > 2008, so it should be documented even if a more specific compatible
> > > > is also added.
> > > 
> > > Agree, and si/siram are also has been around since 2008.
> > 
> > Where?  I couldn't find them when grepping.
> 
> Sorry, I make a mistake, they have not been in upstream.
> 
> > 
> > > In addition, I don’t think it is needed to add specific compatible,
> > > because they are the same in qe-supported soc.
> > 
> > How do we know that they are 100% the same?
> 
> You mean it will be changed in later version?

That's always a possibility, but even on current chips, what bit of
documentation are you referring to that confirms it's the exact same logic?

-Scott

[toc] | [prev] | [next] | [standalone]

#1342842

FromQiang Zhao <qiang.zhao@nxp.com>
Date2016-02-25 07:00 +0100
Message-ID<r5X7X-7HS-7@gated-at.bofh.it>
In reply to#1342746
On Thu, 2016-02-25 at 11:12  AM, Scott Wood wrote:
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Thursday, February 25, 2016 11:12 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree
> bindings.
> 
> On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> > On Wed, 2016-02-24 at 04:20  AM, Scott Wood wrote:
> > > -----Original Message-----
> > > From: Scott Wood [mailto:oss@buserror.net]
> > > Sent: Wednesday, February 24, 2016 4:20 AM
> > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
> > > device tree bindings.
> > >
> > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > > Add IC, SI and SIRAM document of QE to
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > >
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > ---
> > > > > Changes for v2
> > > > > 	- Add interrupt-controller in Required properties
> > > > > 	- delete address-cells and size-cells for qe-si and qe-siram
> > > > >
> > > > >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > > > > ++++++++++++++++++++++
> > > > >  1 file changed, 50 insertions(+)
> > > > >
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > index 4f89302..84052a7 100644
> > > > > ---
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx
> > > > > +++ t
> > > > > @@ -69,6 +69,56 @@ Example:
> > > > >  	};
> > > > >       };
> > > > >
> > > > > +* Interrupt Controller (IC)
> > > > > +
> > > > > +Required properties:
> > > > > +- compatible : should be "fsl,qe-ic".
> > > >
> > > > > +- compatible : should be "fsl,qe-si".
> > > >
> > > > > +- compatible : should be "fsl,qe-siram".
> > > >
> > > > These compatible strings are all a bit generic and should have SoC
> > > > specific compatible strings.
> > >
> > > I don't know about si/siram, but "fsl,qe-ic" has been around since
> > > 2008, so it should be documented even if a more specific compatible
> > > is also added.
> >
> > Agree, and si/siram are also has been around since 2008.
> 
> Where?  I couldn't find them when grepping.

Sorry, I make a mistake, they have not been in upstream.

> 
> > In addition, I don’t think it is needed to add specific compatible,
> > because they are the same in qe-supported soc.
> 
> How do we know that they are 100% the same?

You mean it will be changed in later version?

BR
-Zhao

[toc] | [prev] | [next] | [standalone]

#1342780

FromQiang Zhao <qiang.zhao@nxp.com>
Date2016-02-25 04:50 +0100
Message-ID<r5UD9-6ag-57@gated-at.bofh.it>
In reply to#1341006
On Wed, 2016-02-24 at 04:20  AM, Scott Wood wrote:
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Wednesday, February 24, 2016 4:20 AM
> To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree
> bindings.
> 
> On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > Add IC, SI and SIRAM document of QE to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > >
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > > Changes for v2
> > > 	- Add interrupt-controller in Required properties
> > > 	- delete address-cells and size-cells for qe-si and qe-siram
> > >
> > >  .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt  | 50
> > > ++++++++++++++++++++++
> > >  1 file changed, 50 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > index 4f89302..84052a7 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > @@ -69,6 +69,56 @@ Example:
> > >  	};
> > >       };
> > >
> > > +* Interrupt Controller (IC)
> > > +
> > > +Required properties:
> > > +- compatible : should be "fsl,qe-ic".
> >
> > > +- compatible : should be "fsl,qe-si".
> >
> > > +- compatible : should be "fsl,qe-siram".
> >
> > These compatible strings are all a bit generic and should have SoC
> > specific compatible strings.
> 
> I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
> should be documented even if a more specific compatible is also added.

Agree, and si/siram are also has been around since 2008.
In addition, I don’t think it is needed to add specific compatible, because they are
the same in qe-supported soc.

BR
-Zhao

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web