Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342322 > unrolled thread

Re: [PATCH v2 0/3] PCI: Revert "Implement pcibios_alloc_irq() and pcibios_free_irq()"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/3] PCI: Revert "Implement pcibios_alloc_irq() and  pcibios_free_irq()" Олег Мороз <oleg.moroz@mcc.vniiem.ru> - 2016-02-24 19:40 +0100
    Re: [PATCH v2 0/3] PCI: Revert "Implement pcibios_alloc_irq() and  pcibios_free_irq()" Bjorn Helgaas <helgaas@kernel.org> - 2016-02-25 16:00 +0100

#1342322 — Re: [PATCH v2 0/3] PCI: Revert "Implement pcibios_alloc_irq() and pcibios_free_irq()"

I've checked next next-20160218 tag and confirm that it works.

18.02.2016 19:03, Bjorn Helgaas пишет:
> On Thu, Feb 18, 2016 at 08:13:41AM +0300, Мороз Олег wrote:
>> On 17.02.2016 21:36, Bjorn Helgaas wrote:
>>> These are clean reverts of 991de2e59090 ("PCI, x86: Implement
>>> pcibios_alloc_irq() and pcibios_free_irq()") and related changes.
>>>
>>> We have two reports of drivers broken in v4.3 by Jiang's change,
>>> 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
>>> pcibios_free_irq()").
>>>
>>> It would be best to fix the problem instead of reverting 991de2e59090, but
>>> I don't have time to do that myself, and we haven't heard from Jiang, so
>>> the only choice I have is to revert the commit.
>>>
>>> Note that reverting will likely break IOAPIC hotplug.
>>>
>>> Олег and Sunjin, can you please test this and see whether it fixes your
>>> drivers?  This patch is based on v4.5-rc1.
>>>
>>> I intend to merge these for v4.5 unless I hear objections.
>>>
>>> They're on my for-linus branch, so they should appear in linux-next
>>> tomorrow.
>>>
>>> Changes from the v1 posting:
>>>    - Explicitly revert related patches instead of resolving conflicts
>>>      manually
>>> ---
>>>
>>> Bjorn Helgaas (3):
>>>        Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled"
>>>        Revert "PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed"
>>>        Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()"
>>>
>>>
>>>   arch/x86/include/asm/pci_x86.h |    2 ++
>>>   arch/x86/pci/common.c          |   26 ++++++++++----------------
>>>   arch/x86/pci/intel_mid_pci.c   |    9 +++------
>>>   arch/x86/pci/irq.c             |   23 +++++++++++++++++++----
>>>   drivers/acpi/pci_irq.c         |   17 +++++++++++++----
>>>   include/linux/pci.h            |   17 -----------------
>>>   6 files changed, 47 insertions(+), 47 deletions(-)
>> As i undestand this patch will appear in kernel git repo tomorrow? I
>> don't need to apply in manyally to v4.5-rc1?
> These are included in the next-20160218 tag in the linux-next git repo (not
> Linus' repo) at:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>
> You browse this at:
>
>    https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/
>
> If you'd rather, you can also apply the patches yourself to v4.5-rc1.
>
> Bjorn

[toc] | [next] | [standalone]

#1343243

On Wed, Feb 24, 2016 at 09:30:56PM +0300, Олег Мороз wrote:
> I've checked next next-20160218 tag and confirm that it works.

Thanks a lot for testing this!  I added your tested-by to the commit.

I apologize again for the inconvenience of this.  Thank you very much
for your effort in reporting it and helping track it down.

Bjorn

> 18.02.2016 19:03, Bjorn Helgaas пишет:
> >On Thu, Feb 18, 2016 at 08:13:41AM +0300, Мороз Олег wrote:
> >>On 17.02.2016 21:36, Bjorn Helgaas wrote:
> >>>These are clean reverts of 991de2e59090 ("PCI, x86: Implement
> >>>pcibios_alloc_irq() and pcibios_free_irq()") and related changes.
> >>>
> >>>We have two reports of drivers broken in v4.3 by Jiang's change,
> >>>991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
> >>>pcibios_free_irq()").
> >>>
> >>>It would be best to fix the problem instead of reverting 991de2e59090, but
> >>>I don't have time to do that myself, and we haven't heard from Jiang, so
> >>>the only choice I have is to revert the commit.
> >>>
> >>>Note that reverting will likely break IOAPIC hotplug.
> >>>
> >>>Олег and Sunjin, can you please test this and see whether it fixes your
> >>>drivers?  This patch is based on v4.5-rc1.
> >>>
> >>>I intend to merge these for v4.5 unless I hear objections.
> >>>
> >>>They're on my for-linus branch, so they should appear in linux-next
> >>>tomorrow.
> >>>
> >>>Changes from the v1 posting:
> >>>   - Explicitly revert related patches instead of resolving conflicts
> >>>     manually
> >>>---
> >>>
> >>>Bjorn Helgaas (3):
> >>>       Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled"
> >>>       Revert "PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed"
> >>>       Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()"
> >>>
> >>>
> >>>  arch/x86/include/asm/pci_x86.h |    2 ++
> >>>  arch/x86/pci/common.c          |   26 ++++++++++----------------
> >>>  arch/x86/pci/intel_mid_pci.c   |    9 +++------
> >>>  arch/x86/pci/irq.c             |   23 +++++++++++++++++++----
> >>>  drivers/acpi/pci_irq.c         |   17 +++++++++++++----
> >>>  include/linux/pci.h            |   17 -----------------
> >>>  6 files changed, 47 insertions(+), 47 deletions(-)
> >>As i undestand this patch will appear in kernel git repo tomorrow? I
> >>don't need to apply in manyally to v4.5-rc1?
> >These are included in the next-20160218 tag in the linux-next git repo (not
> >Linus' repo) at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >
> >You browse this at:
> >
> >   https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/
> >
> >If you'd rather, you can also apply the patches yourself to v4.5-rc1.
> >
> >Bjorn
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web