Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341973 > unrolled thread

[PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

Started byLaxman Dewangan <ldewangan@nvidia.com>
First post2016-02-24 14:30 +0100
Last post2016-02-28 16:00 +0100
Articles 8 on this page of 88 — 28 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:30 +0100
    [PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for  pinctrl registration Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-24 15:10 +0100
      Re: [PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for  pinctrl registration kbuild test robot <lkp@intel.com> - 2016-02-24 19:40 +0100
    [PATCH 10/50] pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 37/50] pinctrl: at91: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 49/50] pinctrl: u300: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 33/50] pinctrl: adi2: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 24/50] pinctrl: samsung: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 34/50] pinctrl: amd: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 31/50] pinctrl: uniphier: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 31/50] pinctrl: uniphier: Use devm_pinctrl_register() for  pinctrl registration Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-26 11:10 +0100
    [PATCH 03/50] pinctrl: bcm281xx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 03/50] pinctrl: bcm281xx: Use devm_pinctrl_register() for  pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
    [PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for  pinctrl registration Maxime Coquelin <maxime.coquelin@st.com> - 2016-02-24 17:20 +0100
    [PATCH 47/50] pinctrl: tz1090-pdc: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register,  unregister} Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:30 +0100
      Re: [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register,  unregister} Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-25 15:50 +0100
    [PATCH 30/50] pinctrl: tegra-xusb: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 30/50] pinctrl: tegra-xusb: Use devm_pinctrl_register()  for pinctrl registration Stephen Warren <swarren@wwwdotorg.org> - 2016-02-24 17:50 +0100
    [PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for  pinctrl registration Stephen Warren <swarren@wwwdotorg.org> - 2016-02-24 17:50 +0100
    [PATCH 32/50] pinctrl: vt8500: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 43/50] pinctrl: pistachio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 35/50] pinctrl: as3722: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 05/50] pinctrl: cygnus-mux: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 05/50] pinctrl: cygnus-mux: Use devm_pinctrl_register()  for pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
    [PATCH 42/50] pinctrl: pic32: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 42/50] pinctrl: pic32: Use devm_pinctrl_register() for  pinctrl registration Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-25 21:40 +0100
    [PATCH 46/50] pinctrl: tb10x: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for  pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
    [PATCH 07/50] pinctrl: nsp-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 44/50] pinctrl: rockchip: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 44/50] pinctrl: rockchip: Use devm_pinctrl_register() for pinctrl registration Heiko Stübner <heiko@sntech.de> - 2016-03-02 22:50 +0100
    [PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register()  for pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
    [PATCH 18/50] pinctrl: spmi: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 18/50] pinctrl: spmi: Use devm_pinctrl_register() for  pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
    [PATCH 12/50] pinctrl: intel: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 12/50] pinctrl: intel: Use devm_pinctrl_register() for  pinctrl registration Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-25 12:50 +0100
    [PATCH 36/50] pinctrl: at91-pio4: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register()  for pinctrl registration Baruch Siach <baruch@tkos.co.il> - 2016-02-24 14:50 +0100
    [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for  pinctrl registration Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-02-26 04:50 +0100
    [PATCH 48/50] pinctrl: tz1090 Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 41/50] pinctrl: palmas: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for  pinctrl registration Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-02-24 19:10 +0100
    [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register()  for pinctrl registration Matthias Brugger <matthias.bgg@gmail.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register()  for pinctrl registration Hongzhou Yang <hongzhou.yang@mediatek.com> - 2016-02-24 21:40 +0100
    [PATCH 40/50] pinctrl: lpc18xx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 40/50] pinctrl: lpc18xx: Use devm_pinctrl_register() for  pinctrl registration Joachim Eastwood <manabian@gmail.com> - 2016-02-24 16:10 +0100
    [PATCH 21/50] pinctrl: msm: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for  pinctrl registration Carlo Caione <carlo@caione.org> - 2016-02-26 22:00 +0100
    [PATCH 22/50] pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 22/50] pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-26 23:30 +0100
    [PATCH 16/50] pinctrl: nomadic: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for  pinctrl registration Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-25 15:50 +0100
      Re: [PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for  pinctrl registration Shawn Guo <shawnguo@kernel.org> - 2016-02-29 04:10 +0100
    [PATCH 06/50] pinctrl: iproc-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
    [PATCH 39/50] pinctrl: lantiq: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
      Re: [PATCH 39/50] pinctrl: lantiq: Use devm_pinctrl_register() for  pinctrl registration John Crispin <blogic@openwrt.org> - 2016-02-25 15:30 +0100
    [PATCH 11/50] pinctrl: cherryview: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 11/50] pinctrl: cherryview: Use devm_pinctrl_register()  for pinctrl registration Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-25 12:50 +0100
    [PATCH 26/50] pinctrl: spear: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 26/50] pinctrl: spear: Use devm_pinctrl_register() for  pinctrl registration Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-25 03:20 +0100
    [PATCH 23/50] pinctrl: exynos5440: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
    [PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for  pinctrl registration Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-25 15:10 +0100
    [PATCH 08/50] pinctrl: berlin: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 08/50] pinctrl: berlin: Use devm_pinctrl_register() for  pinctrl registration Antoine Ténart   <antoine.tenart@free-electrons.com> - 2016-02-24 18:40 +0100
    [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for  pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
    [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
      Re: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for  pinctrl registration Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-24 15:00 +0100
    [PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
    [PATCH 02/50] pinctrl: Add resource management devm_pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 15:00 +0100
    Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for  pinctrl_{register, unregister} Stefan Wahren <stefan.wahren@i2se.com> - 2016-02-24 18:30 +0100
      Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register,  unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 18:30 +0100
    Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for  pinctrl_{register, unregister} Linus Walleij <linus.walleij@linaro.org> - 2016-02-25 15:20 +0100
      Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register,  unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-28 16:00 +0100

Page 5 of 5 — ← Prev page 1 2 3 4 [5]

#1342037 — [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-24 14:50 +0100
Subject[PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration
Message-ID<r5HZg-5i2-37@gated-at.bofh.it>
In reply to#1341973
Use devm_pinctrl_register() for pin control registration.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/pinctrl/sh-pfc/core.c    |  1 -
 drivers/pinctrl/sh-pfc/core.h    |  1 -
 drivers/pinctrl/sh-pfc/pinctrl.c | 12 +-----------
 3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
index 181ea98..4b28fbb 100644
--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -587,7 +587,6 @@ static int sh_pfc_remove(struct platform_device *pdev)
 #ifdef CONFIG_GPIO_SH_PFC
 	sh_pfc_unregister_gpiochip(pfc);
 #endif
-	sh_pfc_unregister_pinctrl(pfc);
 
 	return 0;
 }
diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
index 62f53b2..8272114 100644
--- a/drivers/pinctrl/sh-pfc/core.h
+++ b/drivers/pinctrl/sh-pfc/core.h
@@ -57,7 +57,6 @@ int sh_pfc_register_gpiochip(struct sh_pfc *pfc);
 int sh_pfc_unregister_gpiochip(struct sh_pfc *pfc);
 
 int sh_pfc_register_pinctrl(struct sh_pfc *pfc);
-int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc);
 
 u32 sh_pfc_read_raw_reg(void __iomem *mapped_reg, unsigned int reg_width);
 void sh_pfc_write_raw_reg(void __iomem *mapped_reg, unsigned int reg_width,
diff --git a/drivers/pinctrl/sh-pfc/pinctrl.c b/drivers/pinctrl/sh-pfc/pinctrl.c
index 87b0a59..f17b5fc 100644
--- a/drivers/pinctrl/sh-pfc/pinctrl.c
+++ b/drivers/pinctrl/sh-pfc/pinctrl.c
@@ -692,19 +692,9 @@ int sh_pfc_register_pinctrl(struct sh_pfc *pfc)
 	pmx->pctl_desc.pins = pmx->pins;
 	pmx->pctl_desc.npins = pfc->info->nr_pins;
 
-	pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);
+	pmx->pctl = devm_pinctrl_register(pfc->dev, &pmx->pctl_desc, pmx);
 	if (IS_ERR(pmx->pctl))
 		return PTR_ERR(pmx->pctl);
 
 	return 0;
 }
-
-int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc)
-{
-	struct sh_pfc_pinctrl *pmx = pfc->pinctrl;
-
-	pinctrl_unregister(pmx->pctl);
-
-	pfc->pinctrl = NULL;
-	return 0;
-}
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1342040 — Re: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-02-24 15:00 +0100
SubjectRe: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration
Message-ID<r5I8W-5nh-1@gated-at.bofh.it>
In reply to#1342037
Hi Laxman,

On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Use devm_pinctrl_register() for pin control registration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: linux-renesas-soc@vger.kernel.org

Thanks for your patch!

> index 87b0a59..f17b5fc 100644
> --- a/drivers/pinctrl/sh-pfc/pinctrl.c
> +++ b/drivers/pinctrl/sh-pfc/pinctrl.c
> @@ -692,19 +692,9 @@ int sh_pfc_register_pinctrl(struct sh_pfc *pfc)
>         pmx->pctl_desc.pins = pmx->pins;
>         pmx->pctl_desc.npins = pfc->info->nr_pins;
>
> -       pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);
> +       pmx->pctl = devm_pinctrl_register(pfc->dev, &pmx->pctl_desc, pmx);
>         if (IS_ERR(pmx->pctl))
>                 return PTR_ERR(pmx->pctl);
>
>         return 0;
>  }
> -
> -int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc)
> -{
> -       struct sh_pfc_pinctrl *pmx = pfc->pinctrl;
> -
> -       pinctrl_unregister(pmx->pctl);
> -
> -       pfc->pinctrl = NULL;
> -       return 0;
> -}

There's no longer a need to have sh_pfc.pinctrl, so please remove that field
while you're at it.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1342038 — [PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-24 14:50 +0100
Subject[PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration
Message-ID<r5HZg-5i2-31@gated-at.bofh.it>
In reply to#1341973
Use devm_pinctrl_register() for pin control registration and clean
the error path.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
 drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
index 54a5402..49cc734 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
@@ -820,7 +820,7 @@ static int pm8xxx_mpp_probe(struct platform_device *pdev)
 	pctrl->desc.custom_conf_items = pm8xxx_conf_items;
 #endif
 
-	pctrl->pctrl = pinctrl_register(&pctrl->desc, &pdev->dev, pctrl);
+	pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
 	if (IS_ERR(pctrl->pctrl)) {
 		dev_err(&pdev->dev, "couldn't register pm8xxx mpp driver\n");
 		return PTR_ERR(pctrl->pctrl);
@@ -836,7 +836,7 @@ static int pm8xxx_mpp_probe(struct platform_device *pdev)
 	ret = gpiochip_add_data(&pctrl->chip, pctrl);
 	if (ret) {
 		dev_err(&pdev->dev, "failed register gpiochip\n");
-		goto unregister_pinctrl;
+		return ret;
 	}
 
 	ret = gpiochip_add_pin_range(&pctrl->chip,
@@ -856,9 +856,6 @@ static int pm8xxx_mpp_probe(struct platform_device *pdev)
 unregister_gpiochip:
 	gpiochip_remove(&pctrl->chip);
 
-unregister_pinctrl:
-	pinctrl_unregister(pctrl->pctrl);
-
 	return ret;
 }
 
@@ -868,8 +865,6 @@ static int pm8xxx_mpp_remove(struct platform_device *pdev)
 
 	gpiochip_remove(&pctrl->chip);
 
-	pinctrl_unregister(pctrl->pctrl);
-
 	return 0;
 }
 
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1342045 — [PATCH 02/50] pinctrl: Add resource management devm_pinctrl_{register, unregister}

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-24 15:00 +0100
Subject[PATCH 02/50] pinctrl: Add resource management devm_pinctrl_{register, unregister}
Message-ID<r5I8W-5nh-17@gated-at.bofh.it>
In reply to#1341973
Add new member of devm wrappers for the pinctrl_register and
pinctrl_unregister in list of managed interfaces.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 Documentation/driver-model/devres.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index 831a536..eed5e56 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -323,6 +323,8 @@ PHY
 PINCTRL
   devm_pinctrl_get()
   devm_pinctrl_put()
+  devm_pinctrl_register()
+  devm_pinctrl_unregister()
 
 PWM
   devm_pwm_get()
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1342241 — Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-02-24 18:30 +0100
SubjectRe: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}
Message-ID<r5Lq9-7M2-1@gated-at.bofh.it>
In reply to#1341973
Hi Laxman,

> Laxman Dewangan <ldewangan@nvidia.com> hat am 24. Februar 2016 um 14:15
> geschrieben:
>
>
> Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister()
> and use these new APIs on hw driver to reduce the error path code and
> remove callback for driver.
>

just for interest: why didn't you patch freescale/pinctrl-mxs.c?

Regards
Stefan

[toc] | [prev] | [next] | [standalone]

#1342245 — Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-24 18:30 +0100
SubjectRe: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}
Message-ID<r5Lqa-7M2-19@gated-at.bofh.it>
In reply to#1342241
On Wednesday 24 February 2016 10:52 PM, Stefan Wahren wrote:
> Hi Laxman,
>
>> Laxman Dewangan <ldewangan@nvidia.com> hat am 24. Februar 2016 um 14:15
>> geschrieben:
>>
>>
>> Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister()
>> and use these new APIs on hw driver to reduce the error path code and
>> remove callback for driver.
>>
> just for interest: why didn't you patch freescale/pinctrl-mxs.c?
>


The remove callback is implemented as:

int mxs_pinctrl_remove(struct platform_device *pdev)
{
         struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);

         pinctrl_unregister(d->pctl);
         iounmap(d->base);

         return 0;
}


So if I use devm_pinctrl_register() then the sequence will be different like
     iounmap()
     pinctrl_unregister()

And I did not want to change the sequence as dont know the side effect 
until I test it on actual platform which is not there with me.

[toc] | [prev] | [next] | [standalone]

#1343188 — Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-02-25 15:20 +0100
SubjectRe: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}
Message-ID<r64VQ-50x-9@gated-at.bofh.it>
In reply to#1341973
On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister()
> and use these new APIs on hw driver to reduce the error path code and
> remove callback for driver.

As you can probably guess I like this too, so wait a while, collect ACKs
and send me a branch to pull for this too.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1345300 — Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-28 16:00 +0100
SubjectRe: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister}
Message-ID<r7aZc-3Z9-15@gated-at.bofh.it>
In reply to#1343188
On Thursday 25 February 2016 07:43 PM, Linus Walleij wrote:
> On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Add resource manageemnt APIs fro pinctrl_register() and pinctrl_unregister()
>> and use these new APIs on hw driver to reduce the error path code and
>> remove callback for driver.
> As you can probably guess I like this too, so wait a while, collect ACKs
> and send me a branch to pull for this too.
>
Got lots of ack/reviewed by and captured all. Also did code changes per 
review:
- Optimizing in devm_ apis.
- Correcting the description of devm_ apis.
- Simplifying probe in digicolor.
- Removing unwanted pfc->pinctrl in ish.

Pushed the change at:
Branch "devm_pinctrl_register" of 
https://github.com/ldewangan/linux-upstream.git.

Base repo is
for-next of 
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git


If required, I can send the V2 version of list with acks.

[toc] | [prev] | [standalone]

Page 5 of 5 — ← Prev page 1 2 3 4 [5]

Back to top | Article view | linux.kernel

csiph-web