Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340190 > unrolled thread

Re: [PATCH 2/2] HSI: omap-ssi: add clk change support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/2] HSI: omap-ssi: add clk change support Sebastian Reichel <sre@kernel.org> - 2016-02-23 03:40 +0100
    Re: [PATCH 2/2] HSI: omap-ssi: add clk change support Arnd Bergmann <arnd@arndb.de> - 2016-02-24 16:20 +0100
      Re: [PATCH 2/2] HSI: omap-ssi: add clk change support Sebastian Reichel <sre@kernel.org> - 2016-02-24 18:10 +0100

#1340190 — Re: [PATCH 2/2] HSI: omap-ssi: add clk change support

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Sun, Jan 31, 2016 at 01:52:38AM +0100, Sebastian Reichel wrote:
> This adds support for frequency changes of the SSI
> functional clock, which may occur due to DVFS.

I queued this one for 4.6.

-- Sebastian

[toc] | [next] | [standalone]

#1342105

On Tuesday 23 February 2016 03:34:43 Sebastian Reichel wrote:
> 
> On Sun, Jan 31, 2016 at 01:52:38AM +0100, Sebastian Reichel wrote:
> > This adds support for frequency changes of the SSI
> > functional clock, which may occur due to DVFS.
> 
> I queued this one for 4.6.
> 

This causes a regression when SSI is a loadable module:

ERROR: "omap_ssi_port_update_fclk" [drivers/hsi/controllers/omap_ssi.ko] undefined!

I suspect that there is now some form of circular dependency between the
various modules, but I couldn't figure it out. Can you have a look,
and maybe revert the commit in linux-next for the time being?

	Arnd

[toc] | [prev] | [next] | [standalone]

#1342221

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Wed, Feb 24, 2016 at 04:19:09PM +0100, Arnd Bergmann wrote:
> On Tuesday 23 February 2016 03:34:43 Sebastian Reichel wrote:
> > 
> > On Sun, Jan 31, 2016 at 01:52:38AM +0100, Sebastian Reichel wrote:
> > > This adds support for frequency changes of the SSI
> > > functional clock, which may occur due to DVFS.
> > 
> > I queued this one for 4.6.
> > 
> 
> This causes a regression when SSI is a loadable module:
> 
> ERROR: "omap_ssi_port_update_fclk" [drivers/hsi/controllers/omap_ssi.ko] undefined!

Thanks for the notice.

> I suspect that there is now some form of circular dependency between the
> various modules, but I couldn't figure it out. Can you have a look,
> and maybe revert the commit in linux-next for the time being?

I dropped the patch from my -next branch until I figured out what's
going on.

-- Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web