Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1341591 > unrolled thread

Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA

Started byCaesar Wang <caesar.upstream@gmail.com>
First post2016-02-24 07:10 +0100
Last post2016-02-25 01:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA Caesar Wang <caesar.upstream@gmail.com> - 2016-02-24 07:10 +0100
    Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-02-24 14:30 +0100
      Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA Caesar Wang <caesar.upstream@gmail.com> - 2016-02-25 01:40 +0100

#1341591 — Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA

FromCaesar Wang <caesar.upstream@gmail.com>
Date2016-02-24 07:10 +0100
SubjectRe: commit 271e1b86e691 is breaking DMA uart on SoCFPGA
Message-ID<r5AO6-ke-1@gated-at.bofh.it>
Hi,

Thanks Dinh & Alexander for the intergration testing.

---

@Dinh,

Can you test it again with the patch[0]?

patch[0]:
https://patchwork.kernel.org/patch/8398511/



-
Caesar
在 2016年02月23日 23:14, Dinh Nguyen 写道:
> Hi,
>
> Sorry that I couldn't get to this sooner.
>
> On 02/18/2016 10:07 AM, Alexander Kochetkov wrote:
>> Hello!
>>
>> Bartlomiej, could you please tell what uart driver is used on Samsung
>> Exynos4412?
>> Dinh, could you please tell what uart driver is used on SoCFPGA?
>>
> SoCFPGA is using the 8250_dw.c uart driver.
>
>> Could you make two test?
>>
>> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support
>> burst mode for
>>   dev-to-mem and mem-to-dev transmit", make it buildable and see is it
>> works. In order to make in buildable remove bursts argument from the
>> line:
>>
>>      if (*bursts == 1)
>>      - return _bursts(pl330, dry_run, buf, pxs, 1);
>>      + return _bursts(dry_run, buf, pxs, 1);
>>
> This case still fails for me.
>
>> 2) Checkout next-20160211 kernel tree and set src_maxburst and
>> dst_maxburst to 1 inside UART driver to see is it works?
>>
> This case works and the UART is able to operate in DMA mode.
>
> Dinh
>
>
>
>
> -- 
> Thanks,
> Caesar

[toc] | [next] | [standalone]


#1341965

FromBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date2016-02-24 14:30 +0100
Message-ID<r5HFU-59T-23@gated-at.bofh.it>
In reply to#1341591
Hi,

On Wednesday, February 24, 2016 02:01:59 PM Caesar Wang wrote:
> Hi,
> 
> Thanks Dinh & Alexander for the intergration testing.
> 
> ---
> 
> @Dinh,
> 
> Can you test it again with the patch[0]?
> 
> patch[0]:
> https://patchwork.kernel.org/patch/8398511/

This fixes the problem for me (tested on Samsung Exynos4412 SoC
based Trats2 board).

You may add:

Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

to your patch.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> -
> Caesar
> 在 2016年02月23日 23:14, Dinh Nguyen 写道:
> > Hi,
> >
> > Sorry that I couldn't get to this sooner.
> >
> > On 02/18/2016 10:07 AM, Alexander Kochetkov wrote:
> >> Hello!
> >>
> >> Bartlomiej, could you please tell what uart driver is used on Samsung
> >> Exynos4412?
> >> Dinh, could you please tell what uart driver is used on SoCFPGA?
> >>
> > SoCFPGA is using the 8250_dw.c uart driver.
> >
> >> Could you make two test?
> >>
> >> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support
> >> burst mode for
> >>   dev-to-mem and mem-to-dev transmit", make it buildable and see is it
> >> works. In order to make in buildable remove bursts argument from the
> >> line:
> >>
> >>      if (*bursts == 1)
> >>      - return _bursts(pl330, dry_run, buf, pxs, 1);
> >>      + return _bursts(dry_run, buf, pxs, 1);
> >>
> > This case still fails for me.
> >
> >> 2) Checkout next-20160211 kernel tree and set src_maxburst and
> >> dst_maxburst to 1 inside UART driver to see is it works?
> >>
> > This case works and the UART is able to operate in DMA mode.
> >
> > Dinh

[toc] | [prev] | [next] | [standalone]


#1342551

FromCaesar Wang <caesar.upstream@gmail.com>
Date2016-02-25 01:40 +0100
Message-ID<r5S8i-49E-17@gated-at.bofh.it>
In reply to#1341965

在 2016年02月24日 21:24, Bartlomiej Zolnierkiewicz 写道:
> Hi,
>
> On Wednesday, February 24, 2016 02:01:59 PM Caesar Wang wrote:
>> Hi,
>>
>> Thanks Dinh & Alexander for the intergration testing.
>>
>> ---
>>
>> @Dinh,
>>
>> Can you test it again with the patch[0]?
>>
>> patch[0]:
>> https://patchwork.kernel.org/patch/8398511/
> This fixes the problem for me (tested on Samsung Exynos4412 SoC
> based Trats2 board).
>
> You may add:
>
> Tested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>


Thanks Bartlomiej for sharing the test result.:-)


-
Caesar
>
> to your patch.
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>> -
>> Caesar
>> 在 2016年02月23日 23:14, Dinh Nguyen 写道:
>>> Hi,
>>>
>>> Sorry that I couldn't get to this sooner.
>>>
>>> On 02/18/2016 10:07 AM, Alexander Kochetkov wrote:
>>>> Hello!
>>>>
>>>> Bartlomiej, could you please tell what uart driver is used on Samsung
>>>> Exynos4412?
>>>> Dinh, could you please tell what uart driver is used on SoCFPGA?
>>>>
>>> SoCFPGA is using the 8250_dw.c uart driver.
>>>
>>>> Could you make two test?
>>>>
>>>> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support
>>>> burst mode for
>>>>    dev-to-mem and mem-to-dev transmit", make it buildable and see is it
>>>> works. In order to make in buildable remove bursts argument from the
>>>> line:
>>>>
>>>>       if (*bursts == 1)
>>>>       - return _bursts(pl330, dry_run, buf, pxs, 1);
>>>>       + return _bursts(dry_run, buf, pxs, 1);
>>>>
>>> This case still fails for me.
>>>
>>>> 2) Checkout next-20160211 kernel tree and set src_maxburst and
>>>> dst_maxburst to 1 inside UART driver to see is it works?
>>>>
>>> This case works and the UART is able to operate in DMA mode.
>>>
>>> Dinh
>

-- 
Thanks,
Caesar

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web