Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341632 > unrolled thread

[PATCH] drm/amd: Do not make DRM_AMD_ACP default to y

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y Geert Uytterhoeven <geert+renesas@glider.be> - 2016-02-24 09:20 +0100
    Re: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-24 16:00 +0100
      Re: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y Alex Deucher <alexdeucher@gmail.com> - 2016-02-24 17:10 +0100
    RE: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-02-24 16:30 +0100

#1341632 — [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y

By default, not only this driver is enabled on all platforms, but also
generic PM Domains and Multi-Function Devices.

Drop the "default y" to fix this.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/amd/acp/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/acp/Kconfig b/drivers/gpu/drm/amd/acp/Kconfig
index 2b07813bceede66d..0f734ee0527434b0 100644
--- a/drivers/gpu/drm/amd/acp/Kconfig
+++ b/drivers/gpu/drm/amd/acp/Kconfig
@@ -2,7 +2,6 @@ menu "ACP Configuration"
 
 config DRM_AMD_ACP
        bool "Enable ACP IP support"
-       default y
        select MFD_CORE
        select PM_GENERIC_DOMAINS if PM
        help
-- 
1.9.1

[toc] | [next] | [standalone]

#1342095

Hi Alex,

On Wed, Feb 24, 2016 at 3:48 PM, Deucher, Alexander
<Alexander.Deucher@amd.com> wrote:
>> -----Original Message-----
>> From: Geert Uytterhoeven [mailto:geert+renesas@glider.be]
>> Sent: Wednesday, February 24, 2016 3:14 AM
>> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi
>> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Geert
>> Uytterhoeven
>> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y
>>
>> By default, not only this driver is enabled on all platforms, but also
>> generic PM Domains and Multi-Function Devices.
>>
>> Drop the "default y" to fix this.
>
> I guess I don't really care per se, but why is this an issue?

Because it causes kernel bloat on all platforms that are not AMD SoCs.
I noticed the option and the selected options were suddenly enabled when
running "make ARCH=sh se7724_defconfig".

As a general use, never use "default y", unless the system fails completely
in the absence of the module. Even then, there should be some dependencies
listed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1342162

On Wed, Feb 24, 2016 at 9:58 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Alex,
>
> On Wed, Feb 24, 2016 at 3:48 PM, Deucher, Alexander
> <Alexander.Deucher@amd.com> wrote:
>>> -----Original Message-----
>>> From: Geert Uytterhoeven [mailto:geert+renesas@glider.be]
>>> Sent: Wednesday, February 24, 2016 3:14 AM
>>> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi
>>> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Geert
>>> Uytterhoeven
>>> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y
>>>
>>> By default, not only this driver is enabled on all platforms, but also
>>> generic PM Domains and Multi-Function Devices.
>>>
>>> Drop the "default y" to fix this.
>>
>> I guess I don't really care per se, but why is this an issue?
>
> Because it causes kernel bloat on all platforms that are not AMD SoCs.
> I noticed the option and the selected options were suddenly enabled when
> running "make ARCH=sh se7724_defconfig".
>
> As a general use, never use "default y", unless the system fails completely
> in the absence of the module. Even then, there should be some dependencies
> listed.

Got it.  Applied, thanks,

Alex

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[toc] | [prev] | [next] | [standalone]

#1342128

> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert+renesas@glider.be]
> Sent: Wednesday, February 24, 2016 3:14 AM
> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Geert
> Uytterhoeven
> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y
> 
> By default, not only this driver is enabled on all platforms, but also
> generic PM Domains and Multi-Function Devices.
> 
> Drop the "default y" to fix this.
> 

I guess I don't really care per se, but why is this an issue?

Alex

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/gpu/drm/amd/acp/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/acp/Kconfig
> b/drivers/gpu/drm/amd/acp/Kconfig
> index 2b07813bceede66d..0f734ee0527434b0 100644
> --- a/drivers/gpu/drm/amd/acp/Kconfig
> +++ b/drivers/gpu/drm/amd/acp/Kconfig
> @@ -2,7 +2,6 @@ menu "ACP Configuration"
> 
>  config DRM_AMD_ACP
>         bool "Enable ACP IP support"
> -       default y
>         select MFD_CORE
>         select PM_GENERIC_DOMAINS if PM
>         help
> --
> 1.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web