Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1337898 > unrolled thread
| Started by | Eddie Huang <eddie.huang@mediatek.com> |
|---|---|
| First post | 2016-02-19 07:10 +0100 |
| Last post | 2016-02-23 19:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Eddie Huang <eddie.huang@mediatek.com> - 2016-02-19 07:10 +0100
Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Matthias Brugger <matthias.bgg@gmail.com> - 2016-02-19 11:10 +0100
Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Kevin Hilman <khilman@baylibre.com> - 2016-02-23 01:40 +0100
Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Matthias Brugger <matthias.bgg@gmail.com> - 2016-02-23 10:00 +0100
Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue Kevin Hilman <khilman@baylibre.com> - 2016-02-23 19:40 +0100
| From | Eddie Huang <eddie.huang@mediatek.com> |
|---|---|
| Date | 2016-02-19 07:10 +0100 |
| Subject | [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue |
| Message-ID | <r3Mqm-MH-3@gated-at.bofh.it> |
MT8173 E1 chip has one bug that if turn off USB power domain, vcore
power will also be off, thus cause modules using vcore power domain
fail, like MMC. The E1 chip only found on MT8173-evb board and this
board only has E1 chip, so implement this as a board specific
workaround.
Pwrapper use vcore power, so add pwrapper using USB power domain to
keep USB power domain not to zero and disabled.
Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
Sascha sent similar patch before[0], but MMC support runtime-pm,
vcore power domain still be disabled after MMC and USB suspend.
This silicon bug already fix in MT8173 MP chip.
[0]:http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/358065.html
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index e427f04..7453a47 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -214,6 +214,9 @@
};
&pwrap {
+ /* Only MT8173 E1 needs USB power domain */
+ power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
+
pmic: mt6397 {
compatible = "mediatek,mt6397";
interrupt-parent = <&pio>;
--
1.9.1
[toc] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2016-02-19 11:10 +0100 |
| Subject | Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue |
| Message-ID | <r3QaC-3rb-9@gated-at.bofh.it> |
| In reply to | #1337898 |
Hi Eddie,
On 19/02/16 07:00, Eddie Huang wrote:
> MT8173 E1 chip has one bug that if turn off USB power domain, vcore
> power will also be off, thus cause modules using vcore power domain
> fail, like MMC. The E1 chip only found on MT8173-evb board and this
> board only has E1 chip, so implement this as a board specific
> workaround.
>
> Pwrapper use vcore power, so add pwrapper using USB power domain to
> keep USB power domain not to zero and disabled.
>
> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
>
> ---
> Sascha sent similar patch before[0], but MMC support runtime-pm,
> vcore power domain still be disabled after MMC and USB suspend.
> This silicon bug already fix in MT8173 MP chip.
>
> [0]:http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/358065.html
> ---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index e427f04..7453a47 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -214,6 +214,9 @@
> };
>
> &pwrap {
> + /* Only MT8173 E1 needs USB power domain */
> + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>;
> +
Applied, thanks
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2016-02-23 01:40 +0100 |
| Message-ID | <r59bd-5O3-25@gated-at.bofh.it> |
| In reply to | #1337898 |
Eddie Huang <eddie.huang@mediatek.com> writes: > MT8173 E1 chip has one bug that if turn off USB power domain, vcore > power will also be off, thus cause modules using vcore power domain > fail, like MMC. The E1 chip only found on MT8173-evb board and this > board only has E1 chip, so implement this as a board specific > workaround. > > Pwrapper use vcore power, so add pwrapper using USB power domain to > keep USB power domain not to zero and disabled. > > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> Tested-by: Kevin Hilman <khilman@baylibre.com> I verified that this gets my mt8173-evb booting again when I enable MMC support. Thanks, Kevin
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2016-02-23 10:00 +0100 |
| Subject | Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue |
| Message-ID | <r5gZ4-2Qo-1@gated-at.bofh.it> |
| In reply to | #1340104 |
On 23/02/16 01:32, Kevin Hilman wrote: > Eddie Huang <eddie.huang@mediatek.com> writes: > >> MT8173 E1 chip has one bug that if turn off USB power domain, vcore >> power will also be off, thus cause modules using vcore power domain >> fail, like MMC. The E1 chip only found on MT8173-evb board and this >> board only has E1 chip, so implement this as a board specific >> workaround. >> >> Pwrapper use vcore power, so add pwrapper using USB power domain to >> keep USB power domain not to zero and disabled. >> >> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> > > Tested-by: Kevin Hilman <khilman@baylibre.com> > I send the patch in a pull request yesterday, so I won't be able to add your tag. Thanks for testing and reporting this issue! Matthias > I verified that this gets my mt8173-evb booting again when I enable MMC > support. > > Thanks, > > Kevin >
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2016-02-23 19:40 +0100 |
| Message-ID | <r5q2l-P6-17@gated-at.bofh.it> |
| In reply to | #1340406 |
Matthias Brugger <matthias.bgg@gmail.com> writes: > On 23/02/16 01:32, Kevin Hilman wrote: >> Eddie Huang <eddie.huang@mediatek.com> writes: >> >>> MT8173 E1 chip has one bug that if turn off USB power domain, vcore >>> power will also be off, thus cause modules using vcore power domain >>> fail, like MMC. The E1 chip only found on MT8173-evb board and this >>> board only has E1 chip, so implement this as a board specific >>> workaround. >>> >>> Pwrapper use vcore power, so add pwrapper using USB power domain to >>> keep USB power domain not to zero and disabled. >>> >>> Signed-off-by: Eddie Huang <eddie.huang@mediatek.com> >> >> Tested-by: Kevin Hilman <khilman@baylibre.com> >> > > I send the patch in a pull request yesterday, so I won't be able to > add your tag. No worries. Was on vacation, so couldn't test sooner. > Thanks for testing and reporting this issue! You're welcome, Kevin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web