Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1340032 > unrolled thread

Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused

Started byRobert Jarzmik <robert.jarzmik@free.fr>
First post2016-02-22 23:40 +0100
Last post2016-02-22 23:40 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-22 23:40 +0100

#1340032 — Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused

FromRobert Jarzmik <robert.jarzmik@free.fr>
Date2016-02-22 23:40 +0100
SubjectRe: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused
Message-ID<r57j5-4kk-43@gated-at.bofh.it>
Arnd Bergmann <arnd@arndb.de> writes:

> This variable may be used by some devices that each have their
> on Kconfig symbol, or by none of them, and that causes a build
> warning:
>
> arch/arm/mach-mmp/devices.c:241:12: error: 'usb_dma_mask' defined but not used [-Werror=unused-variable]
>
> Marking it __maybe_unused avoids the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/mach-mmp/devices.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Haojian,

I still didn't get an ack on this one, do you want to carry it through your
tree, or let Arnd carry it or let me carry it ?

Cheers.

--
Robert

[1] The patch
> diff --git a/arch/arm/mach-mmp/devices.c b/arch/arm/mach-mmp/devices.c
> index 3330ac7cfbef..671c7a09ab3d 100644
> --- a/arch/arm/mach-mmp/devices.c
> +++ b/arch/arm/mach-mmp/devices.c
> @@ -238,7 +238,7 @@ void pxa_usb_phy_deinit(void __iomem *phy_reg)
>  #endif
>  
>  #if IS_ENABLED(CONFIG_USB_SUPPORT)
> -static u64 usb_dma_mask = ~(u32)0;
> +static u64 __maybe_unused usb_dma_mask = ~(u32)0;
>  
>  #if IS_ENABLED(CONFIG_USB_MV_UDC)
>  struct resource pxa168_u2o_resources[] = {

-- 
Robert

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web