Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340057 > unrolled thread

[PATCH 0/8] tty: n_gsm: Make mux work as a responder station

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/8] tty: n_gsm: Make mux work as a responder station Andrej Krpic <ak77@tnode.com> - 2016-02-23 00:00 +0100
    [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel Andrej Krpic <ak77@tnode.com> - 2016-02-23 00:00 +0100
    Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station *DUPLICATE* Andrej Krpic <ak77@tnode.com> - 2016-02-23 00:40 +0100

#1340057 — [PATCH 0/8] tty: n_gsm: Make mux work as a responder station

When using n_gsm you have to explicitly set it to work as a initiator
station. This led me to believe that it can also work as a responder.

In a use case where I needed responder station mux I came to the
conclusion that it actually does not work. Second and third patch
fix dealings with frame C/R bit that then enable mux to work as a
responder station.

Next patches in the series then fix bugs that were found after two 
instances of n_gsm connected over null-modem cable were used.

First patch fixes formatting errors, such as space before comma, and
most of the warnings reported by the checkpatch script.


Andrej Krpic (8):
  tty: n_gsm: fix formatting errors
  tty: n_gsm: fix C/R bit when sending as a responder
  tty: n_gsm: make mux work as a responder station
  tty: n_gsm: send DM response when accessing an invalid channel
  tty: n_gsm: replace dead code with a meaningful comment
  tty: n_gsm: add missing length field in control channel commands
  tty: n_gsm: properly format Modem Status Command message
  tty: n_gsm: Enable reception of frames separated with a single SOF
    marker

 drivers/tty/n_gsm.c | 191 +++++++++++++++++++++++++++++++++-------------------
 1 file changed, 123 insertions(+), 68 deletions(-)

-- 
2.7.0

[toc] | [next] | [standalone]

#1340058 — [PATCH 4/8] tty: n_gsm: send DM response when accessing an invalid channel

Change C/R bit in a response to a UI/UIH frame sent to
non-existing/closed channel. As DM frame type is only valid as a
response, it should be sent using gsm_response function.

Signed-off-by: Andrej Krpic <ak77@tnode.com>
---
 drivers/tty/n_gsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 05b562d..8551fa4 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1857,7 +1857,7 @@ static void gsm_queue(struct gsm_mux *gsm)
 			goto invalid;
 #endif
 		if (dlci == NULL || dlci->state != DLCI_OPEN) {
-			gsm_command(gsm, address, DM|PF);
+			gsm_response(gsm, address, DM|PF);
 			return;
 		}
 		dlci->data(dlci, gsm->buf, gsm->len);
-- 
2.7.0

[toc] | [prev] | [next] | [standalone]

#1340085 — Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station *DUPLICATE*

Please ignore this duplicate thread.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web