Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339520 > unrolled thread

[PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-22 15:30 +0100
    Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for  gpio registration Alban <albeu@free.fr> - 2016-02-22 21:20 +0100
      Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio  registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-23 16:20 +0100

#1339520 — [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration

Use devm_gpiochip_add_data() for GPIO registration.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Alban Bedel <albeu@free.fr>
---
 drivers/gpio/gpio-ath79.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index d13dd13..a6aad59 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
 		ctrl->chip.direction_output = ar934x_gpio_direction_output;
 	}
 
-	err = gpiochip_add_data(&ctrl->chip, ctrl);
+	err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl);
 	if (err) {
 		dev_err(&pdev->dev,
 			"cannot add AR71xx GPIO chip, error=%d", err);
-- 
2.1.4

[toc] | [next] | [standalone]

#1339892 — Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration

On Mon, 22 Feb 2016 19:37:59 +0530
Laxman Dewangan <ldewangan@nvidia.com> wrote:

> Use devm_gpiochip_add_data() for GPIO registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Alban Bedel <albeu@free.fr>
> ---
>  drivers/gpio/gpio-ath79.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index d13dd13..a6aad59 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>  		ctrl->chip.direction_output = ar934x_gpio_direction_output;
>  	}
>  
> -	err = gpiochip_add_data(&ctrl->chip, ctrl);
> +	err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl);
>  	if (err) {
>  		dev_err(&pdev->dev,
>  			"cannot add AR71xx GPIO chip, error=%d", err);

With the patches already applied to the devel branch a few more changes
will be needed to remove the calls to gpiochip_remove() in the probe
error path and the remove callback.

Alban

[toc] | [prev] | [next] | [standalone]

#1340762 — Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio registration

On Tuesday 23 February 2016 01:43 AM, Alban wrote:
> On Mon, 22 Feb 2016 19:37:59 +0530
> Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Use devm_gpiochip_add_data() for GPIO registration.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Cc: Alban Bedel <albeu@free.fr>
>> ---
>>   drivers/gpio/gpio-ath79.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
>> index d13dd13..a6aad59 100644
>> --- a/drivers/gpio/gpio-ath79.c
>> +++ b/drivers/gpio/gpio-ath79.c
>> @@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>>   		ctrl->chip.direction_output = ar934x_gpio_direction_output;
>>   	}
>>   
>> -	err = gpiochip_add_data(&ctrl->chip, ctrl);
>> +	err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl);
>>   	if (err) {
>>   		dev_err(&pdev->dev,
>>   			"cannot add AR71xx GPIO chip, error=%d", err);
> With the patches already applied to the devel branch a few more changes
> will be needed to remove the calls to gpiochip_remove() in the probe
> error path and the remove callback.
>
OK, I will drop this patch when provide the git pointer to Linus.
We can work on this later.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web