Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332470 > unrolled thread

Re: [PATCH v6 0/2] Add initial support for RPM clocks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 0/2] Add initial support for RPM clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-02-12 01:40 +0100
    Re: [PATCH v6 0/2] Add initial support for RPM clocks Georgi Djakov <georgi.djakov@linaro.org> - 2016-02-22 16:30 +0100

#1332470 — Re: [PATCH v6 0/2] Add initial support for RPM clocks

On 12/15, Georgi Djakov wrote:
> 
>  .../devicetree/bindings/clock/qcom,rpmcc.txt       |   37 ++
>  drivers/clk/qcom/Kconfig                           |   29 ++
>  drivers/clk/qcom/Makefile                          |    2 +
>  drivers/clk/qcom/clk-rpm.c                         |  290 +++++++++++++
>  drivers/clk/qcom/clk-rpm.h                         |   71 ++++

Do we need this header file?

>  drivers/clk/qcom/clk-smd-rpm.c                     |  433 ++++++++++++++++++++
>  drivers/clk/qcom/clk-smd-rpm.h                     |  142 +++++++

And this one too?

From what I can tell they're only going to be included by the
clk-rpm and clk-smd-rpm C files. We can also avoid exporting the
RPM ops then if we're going to make the C files into full blown
platform drivers.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1339647

On 02/12/2016 02:37 AM, Stephen Boyd wrote:
> On 12/15, Georgi Djakov wrote:
>>
>>  .../devicetree/bindings/clock/qcom,rpmcc.txt       |   37 ++
>>  drivers/clk/qcom/Kconfig                           |   29 ++
>>  drivers/clk/qcom/Makefile                          |    2 +
>>  drivers/clk/qcom/clk-rpm.c                         |  290 +++++++++++++
>>  drivers/clk/qcom/clk-rpm.h                         |   71 ++++
> 
> Do we need this header file?
> 
>>  drivers/clk/qcom/clk-smd-rpm.c                     |  433 ++++++++++++++++++++
>>  drivers/clk/qcom/clk-smd-rpm.h                     |  142 +++++++
> 
> And this one too?
> 
> From what I can tell they're only going to be included by the
> clk-rpm and clk-smd-rpm C files. We can also avoid exporting the
> RPM ops then if we're going to make the C files into full blown
> platform drivers.
> 

Of course, good idea. Fixed it and will resubmit shortly.

Thanks,
Georgi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web