Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336090 > unrolled thread

[PATCH] staging: xgifb: Fix comment style

Started byBo YU <tsu.yubo@gmail.com>
First post2016-02-17 08:00 +0100
Last post2016-02-22 05:30 +0100
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: xgifb: Fix comment style Bo YU <tsu.yubo@gmail.com> - 2016-02-17 08:00 +0100
    Re: [PATCH] staging: xgifb: Fix comment style Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-21 00:40 +0100
      Re: [PATCH] staging: xgifb: Fix comment style Bo YU <tsu.yubo@gmail.com> - 2016-02-21 19:10 +0100
        Re: [PATCH] staging: xgifb: Fix comment style Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-21 20:40 +0100
          Re: [PATCH] staging: xgifb: Fix comment style Bo YU <tsu.yubo@gmail.com> - 2016-02-22 05:30 +0100

#1336090 — [PATCH] staging: xgifb: Fix comment style

FromBo YU <tsu.yubo@gmail.com>
Date2016-02-17 08:00 +0100
Subject[PATCH] staging: xgifb: Fix comment style
Message-ID<r34fE-2FN-17@gated-at.bofh.it>
Fix comments to use trailing */ on separate lines.

Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
  drivers/staging/xgifb/vb_init.c |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539b..c7f02c7 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -699,11 +699,11 @@ static void XGINew_CheckChannel(struct
xgi_hw_device_info *HwDeviceExtension,
  break;
  case XG42:
  /*
- XG42 SR14 D[3] Reserve
- D[2] = 1, Dual Channel
- = 0, Single Channel
-
- It's Different from Other XG40 Series.
+ * XG42 SR14 D[3] Reserve
+ * D[2] = 1, Dual Channel
+ * = 0, Single Channel
+ *
+ * It's Different from Other XG40 Series.
  */
  if (XGINew_CheckFrequence(pVBInfo) == 1) { /* DDRII, DDR2x */
  pVBInfo->ram_bus = 32; /* 32 bits */
--
1.7.10.4


--
Best Regards

[toc] | [next] | [standalone]

#1338822

FromKroah-Hartman <gregkh@linuxfoundation.org>
Date2016-02-21 00:40 +0100
Message-ID<r4pi2-5bF-27@gated-at.bofh.it>
In reply to#1336090
On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
> Fix comments to use trailing */ on separate lines.
> 
> Signed-off-by: YU BO <tsu.yubo@gmail.com>
> ---
>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Patch doesn't apply :(

[toc] | [prev] | [next] | [standalone]

#1338914

FromBo YU <tsu.yubo@gmail.com>
Date2016-02-21 19:10 +0100
Message-ID<r4GCe-1rJ-21@gated-at.bofh.it>
In reply to#1338822
Hello,

On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:
>On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
>> Fix comments to use trailing */ on separate lines.
>>
>> Signed-off-by: YU BO <tsu.yubo@gmail.com>
>> ---
>>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>
>Patch doesn't apply :(
I don't know that whether i am doing wrong something with git.
Because when i run `git am the-codingfixed-patch` ,it reports error.
But run `patch -p1 the-codingfixed-patch` it is ok.

Perhaps i am wrong with others.

Could you tell me a little hit?

Sorry for the noisy.:)
--
Best Regards

[toc] | [prev] | [next] | [standalone]

#1338966

FromKroah-Hartman <gregkh@linuxfoundation.org>
Date2016-02-21 20:40 +0100
Message-ID<r4I1k-2pb-5@gated-at.bofh.it>
In reply to#1338914
On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote:
> Hello,
> 
> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:
> >On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
> >> Fix comments to use trailing */ on separate lines.
> >>
> >> Signed-off-by: YU BO <tsu.yubo@gmail.com>
> >> ---
> >>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
> >>   1 file changed, 5 insertions(+), 5 deletions(-)
> >
> >Patch doesn't apply :(
> I don't know that whether i am doing wrong something with git.
> Because when i run `git am the-codingfixed-patch` ,it reports error.

Yes, that is the problem, please work on fixing that.  I don't have the
time to determine exactly what the error is, sorry.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1339124

FromBo YU <tsu.yubo@gmail.com>
Date2016-02-22 05:30 +0100
Message-ID<r4Qie-5G-9@gated-at.bofh.it>
In reply to#1338966
Hi,
On Sun, Feb 21, 2016 at 11:33:48AM -0800, Kroah-Hartman wrote:
>On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote:
>> Hello,
>>
>> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:

>> >Patch doesn't apply :(
>> I don't know that whether i am doing wrong something with git.
>> Because when i run `git am the-codingfixed-patch` ,it reports error.
>
>Yes, that is the problem, please work on fixing that.  I don't have the
>time to determine exactly what the error is, sorry.
>
I will fix that :)
Thanks a lot for your patience and help.
>greg k-h

--
Best Regards

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web