Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331084 > unrolled thread
| Started by | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| First post | 2016-02-10 12:40 +0100 |
| Last post | 2016-02-22 11:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-10 12:40 +0100
Re: [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-22 07:00 +0100
Re: [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-22 11:30 +0100
| From | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| Date | 2016-02-10 12:40 +0100 |
| Subject | [PATCH v2 2/8] arm64: dts: qcom: apq8016-sbc: add usb support |
| Message-ID | <r0BhM-1Cs-17@gated-at.bofh.it> |
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
2 files changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
index cbeee0b..4a79dd9 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
@@ -10,4 +10,19 @@
output-low;
};
};
+
+ usb_id_default: usb_id_default {
+ pinmux {
+ function = "gpio";
+ pins = "gpio121";
+ };
+
+ pinconf {
+ pins = "gpio121";
+ function = "gpio";
+ drive-strength = <8>;
+ input-enable;
+ bias-pull-up;
+ };
+ };
};
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index 9a6c595..23ba95a 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -151,6 +151,41 @@
cd-gpios = <&msmgpio 38 0x1>;
status = "okay";
};
+
+ usb@78d9000 {
+ extcon = <&usb_id>, <&usb_id>;
+ status = "okay";
+ };
+
+ ehci@78d9000 {
+ status = "okay";
+ };
+
+ phy@78d9000 {
+ v1p8-supply = <&pm8916_l7>;
+ v3p3-supply = <&pm8916_l13>;
+ vddcx-supply = <&pm8916_s1>;
+ extcon = <&usb_id>, <&usb_id>;
+ dr_mode = "otg";
+ status = "okay";
+ switch-gpio = <&pm8916_gpios 4 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_sw_sel_pm>;
+ };
+ };
+
+ usb2513 {
+ compatible = "smsc,usb3503";
+ reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>;
+ initial-mode = <1>;
+ };
+
+ usb_id: usb-id {
+ interrupt-parent = <&msmgpio>;
+ compatible = "linux,extcon-usb-gpio";
+ id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_id_default>;
};
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2016-02-22 07:00 +0100 |
| Message-ID | <r4RHk-118-1@gated-at.bofh.it> |
| In reply to | #1331084 |
On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
> 2 files changed, 50 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> index cbeee0b..4a79dd9 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
> @@ -10,4 +10,19 @@
> output-low;
> };
> };
> +
> + usb_id_default: usb_id_default {
Labels are built with _, node names with -.
> + pinmux {
> + function = "gpio";
> + pins = "gpio121";
> + };
You don't need a separate node to specify function...
> +
> + pinconf {
> + pins = "gpio121";
> + function = "gpio";
...but if you really want it, then you shouldn't specify the function
here.
> + drive-strength = <8>;
> + input-enable;
> + bias-pull-up;
> + };
> + };
> };
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
[..]
> +
> + usb_id: usb-id {
> + interrupt-parent = <&msmgpio>;
interrupt-parent is part of specifying an interrupt. You're not doing
that here, so no need to specify a parent.
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb_id_default>;
> };
> };
Apart from these two nits
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
[toc] | [prev] | [next] | [standalone]
| From | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| Date | 2016-02-22 11:30 +0100 |
| Message-ID | <r4VUC-4ex-17@gated-at.bofh.it> |
| In reply to | #1339143 |
Thanks for the review,
On 22/02/16 05:51, Bjorn Andersson wrote:
> On Wed 10 Feb 03:36 PST 2016, Srinivas Kandagatla wrote:
>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 15 ++++++++++
>> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 35 ++++++++++++++++++++++
>> 2 files changed, 50 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> index cbeee0b..4a79dd9 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi
>> @@ -10,4 +10,19 @@
>> output-low;
>> };
>> };
>> +
>> + usb_id_default: usb_id_default {
>
> Labels are built with _, node names with -.
>
>> + pinmux {
>> + function = "gpio";
>> + pins = "gpio121";
>> + };
>
> You don't need a separate node to specify function...
>
>> +
>> + pinconf {
>> + pins = "gpio121";
>> + function = "gpio";
>
> ...but if you really want it, then you shouldn't specify the function
> here.
Oops, Will remove this and resend the patch.
>
>> + drive-strength = <8>;
>> + input-enable;
>> + bias-pull-up;
>> + };
>> + };
>> };
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> [..]
>> +
>> + usb_id: usb-id {
>> + interrupt-parent = <&msmgpio>;
>
> interrupt-parent is part of specifying an interrupt. You're not doing
> that here, so no need to specify a parent.
Yep, will clean this up in next version.
>
>> + compatible = "linux,extcon-usb-gpio";
>> + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&usb_id_default>;
>> };
>> };
>
> Apart from these two nits
>
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks,
srini
>
> Regards,
> Bjorn
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web