Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1339028 > unrolled thread
| Started by | Philippe Loctaux <phil@philippeloctaux.com> |
|---|---|
| First post | 2016-02-22 01:30 +0100 |
| Last post | 2016-02-22 01:40 +0100 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH 1/2] Btrfs: dev-replace: Fixed indentation coding style issues Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-22 01:30 +0100
[PATCH 2/2] Btrfs: dev-replace: fixed comment blocks coding style issues Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-22 01:40 +0100
| From | Philippe Loctaux <phil@philippeloctaux.com> |
|---|---|
| Date | 2016-02-22 01:30 +0100 |
| Subject | [PATCH 1/2] Btrfs: dev-replace: Fixed indentation coding style issues |
| Message-ID | <r4MxX-5PB-1@gated-at.bofh.it> |
Use tabs instead of spaces, fixing 3 checkpatch errors. Signed-off-by: Philippe Loctaux <phil@philippeloctaux.com> --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index cbb7dbf..b89a8c6 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -378,7 +378,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, btrfs_info_in_rcu(root->fs_info, "dev_replace from %s (devid %llu) to %s started", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); @@ -525,7 +525,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, btrfs_err_in_rcu(root->fs_info, "btrfs_scrub_dev(%s, %llu, %s) failed %d", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name), scrub_ret); btrfs_dev_replace_unlock(dev_replace); @@ -542,7 +542,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, btrfs_info_in_rcu(root->fs_info, "dev_replace from %s (devid %llu) to %s finished", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); tgt_device->is_tgtdev_for_dev_replace = 0; -- 2.7.1
[toc] | [next] | [standalone]
| From | Philippe Loctaux <phil@philippeloctaux.com> |
|---|---|
| Date | 2016-02-22 01:40 +0100 |
| Subject | [PATCH 2/2] Btrfs: dev-replace: fixed comment blocks coding style issues |
| Message-ID | <r4MHE-5TA-7@gated-at.bofh.it> |
| In reply to | #1339028 |
Makes the comment blocks start with /* on separate lines, and end
with */ on separate lines as well.
Signed-off-by: Philippe Loctaux <phil@philippeloctaux.com>
---
fs/btrfs/dev-replace.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index b89a8c6..0d817aa 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -650,8 +650,10 @@ void btrfs_dev_replace_status(struct btrfs_fs_info *fs_info,
struct btrfs_device *srcdev;
btrfs_dev_replace_lock(dev_replace);
- /* even if !dev_replace_is_valid, the values are good enough for
- * the replace_status ioctl */
+ /*
+ * even if !dev_replace_is_valid, the values are good enough for
+ * the replace_status ioctl
+ */
args->result = BTRFS_IOCTL_DEV_REPLACE_RESULT_NO_ERROR;
args->status.replace_state = dev_replace->replace_state;
args->status.time_started = dev_replace->time_started;
@@ -870,8 +872,10 @@ void btrfs_dev_replace_lock(struct btrfs_dev_replace *dev_replace)
/* the beginning is just an optimization for the typical case */
if (atomic_read(&dev_replace->nesting_level) == 0) {
acquire_lock:
- /* this is not a nested case where the same thread
- * is trying to acqurire the same lock twice */
+ /*
+ * this is not a nested case where the same thread
+ * is trying to acqurire the same lock twice
+ */
mutex_lock(&dev_replace->lock);
mutex_lock(&dev_replace->lock_management_lock);
dev_replace->lock_owner = current->pid;
--
2.7.1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web