Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1337480 > unrolled thread
| Started by | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| First post | 2016-02-18 17:00 +0100 |
| Last post | 2016-02-21 21:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions Daniel Baluta <daniel.baluta@intel.com> - 2016-02-18 17:00 +0100
Re: [RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions Crt Mori <cmo@melexis.com> - 2016-02-19 10:20 +0100
Re: [RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions Jonathan Cameron <jic23@kernel.org> - 2016-02-21 21:40 +0100
| From | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| Date | 2016-02-18 17:00 +0100 |
| Subject | [RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions |
| Message-ID | <r3z9N-7KJ-41@gated-at.bofh.it> |
This fixes the following checkpatch warning:
* WARNING: Comparisons should place the constant
on the right side of the test
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 +++---
drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 84e014c..c550ebb 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -84,7 +84,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
* clock source be switched to gyro. Otherwise, it must be set to
* internal clock
*/
- if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
+ if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
result = regmap_read(st->map, st->reg->pwr_mgmt_1, &mgmt_1);
if (result)
return result;
@@ -92,7 +92,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
mgmt_1 &= ~INV_MPU6050_BIT_CLK_MASK;
}
- if ((INV_MPU6050_BIT_PWR_GYRO_STBY == mask) && (!en)) {
+ if ((mask == INV_MPU6050_BIT_PWR_GYRO_STBY) && (!en)) {
/*
* turning off gyro requires switch to internal clock first.
* Then turn off gyro engine
@@ -117,7 +117,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
if (en) {
/* Wait for output stabilize */
msleep(INV_MPU6050_TEMP_UP_TIME);
- if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
+ if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
/* switch internal clock to PLL */
mgmt_1 |= INV_CLK_PLL;
result = regmap_write(st->map,
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
index 1fc5fd9..441080b 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
@@ -168,7 +168,7 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
result = kfifo_out(&st->timestamps, ×tamp, 1);
/* when there is no timestamp, put timestamp as 0 */
- if (0 == result)
+ if (result == 0)
timestamp = 0;
result = iio_push_to_buffers_with_timestamp(indio_dev, data,
--
2.5.0
[toc] | [next] | [standalone]
| From | Crt Mori <cmo@melexis.com> |
|---|---|
| Date | 2016-02-19 10:20 +0100 |
| Message-ID | <r3Poe-2Ow-1@gated-at.bofh.it> |
| In reply to | #1337480 |
This is quite trivial.
Acked-by: Crt Mori <cmo@melexis.com>
On 18 February 2016 at 16:53, Daniel Baluta <daniel.baluta@intel.com> wrote:
> This fixes the following checkpatch warning:
> * WARNING: Comparisons should place the constant
> on the right side of the test
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 +++---
> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 84e014c..c550ebb 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -84,7 +84,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
> * clock source be switched to gyro. Otherwise, it must be set to
> * internal clock
> */
> - if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
> + if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
> result = regmap_read(st->map, st->reg->pwr_mgmt_1, &mgmt_1);
> if (result)
> return result;
> @@ -92,7 +92,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
> mgmt_1 &= ~INV_MPU6050_BIT_CLK_MASK;
> }
>
> - if ((INV_MPU6050_BIT_PWR_GYRO_STBY == mask) && (!en)) {
> + if ((mask == INV_MPU6050_BIT_PWR_GYRO_STBY) && (!en)) {
> /*
> * turning off gyro requires switch to internal clock first.
> * Then turn off gyro engine
> @@ -117,7 +117,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
> if (en) {
> /* Wait for output stabilize */
> msleep(INV_MPU6050_TEMP_UP_TIME);
> - if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
> + if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
> /* switch internal clock to PLL */
> mgmt_1 |= INV_CLK_PLL;
> result = regmap_write(st->map,
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> index 1fc5fd9..441080b 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> @@ -168,7 +168,7 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
>
> result = kfifo_out(&st->timestamps, ×tamp, 1);
> /* when there is no timestamp, put timestamp as 0 */
> - if (0 == result)
> + if (result == 0)
> timestamp = 0;
>
> result = iio_push_to_buffers_with_timestamp(indio_dev, data,
> --
> 2.5.0
>
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-02-21 21:40 +0100 |
| Message-ID | <r4IXo-33A-13@gated-at.bofh.it> |
| In reply to | #1338006 |
On 19/02/16 09:09, Crt Mori wrote:
> This is quite trivial.
>
> Acked-by: Crt Mori <cmo@melexis.com>
Applied.
>
> On 18 February 2016 at 16:53, Daniel Baluta <daniel.baluta@intel.com> wrote:
>> This fixes the following checkpatch warning:
>> * WARNING: Comparisons should place the constant
>> on the right side of the test
>>
>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>> ---
>> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 +++---
>> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +-
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> index 84e014c..c550ebb 100644
>> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
>> @@ -84,7 +84,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
>> * clock source be switched to gyro. Otherwise, it must be set to
>> * internal clock
>> */
>> - if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
>> + if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
>> result = regmap_read(st->map, st->reg->pwr_mgmt_1, &mgmt_1);
>> if (result)
>> return result;
>> @@ -92,7 +92,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
>> mgmt_1 &= ~INV_MPU6050_BIT_CLK_MASK;
>> }
>>
>> - if ((INV_MPU6050_BIT_PWR_GYRO_STBY == mask) && (!en)) {
>> + if ((mask == INV_MPU6050_BIT_PWR_GYRO_STBY) && (!en)) {
>> /*
>> * turning off gyro requires switch to internal clock first.
>> * Then turn off gyro engine
>> @@ -117,7 +117,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
>> if (en) {
>> /* Wait for output stabilize */
>> msleep(INV_MPU6050_TEMP_UP_TIME);
>> - if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
>> + if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
>> /* switch internal clock to PLL */
>> mgmt_1 |= INV_CLK_PLL;
>> result = regmap_write(st->map,
>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
>> index 1fc5fd9..441080b 100644
>> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
>> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
>> @@ -168,7 +168,7 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
>>
>> result = kfifo_out(&st->timestamps, ×tamp, 1);
>> /* when there is no timestamp, put timestamp as 0 */
>> - if (0 == result)
>> + if (result == 0)
>> timestamp = 0;
>>
>> result = iio_push_to_buffers_with_timestamp(indio_dev, data,
>> --
>> 2.5.0
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web