Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338826 > unrolled thread

Re: [PATCH] jme: remove the jme driver as it is no longer maintained

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] jme: remove the jme driver as it is no longer  maintained David Miller <davem@davemloft.net> - 2016-02-21 01:20 +0100
    Re: [PATCH] jme: remove the jme driver as it is no longer maintained Diego Viola <diego.viola@gmail.com> - 2016-02-21 01:40 +0100
      Re: [PATCH] jme: remove the jme driver as it is no longer maintained Diego Viola <diego.viola@gmail.com> - 2016-02-21 18:30 +0100

#1338826 — Re: [PATCH] jme: remove the jme driver as it is no longer maintained

Sorry, this is not how things work.

You can suggest marking the driver unmaintained in MAINTAINERS if the
listed developer has been unresponsive for a very long time.

But removing the driver altogether is not prudent at all.

Just because it doesn't work %100 the way you like, and nobody
has worked on fixing your specific problems, isn't a reason to
remove an entire driver _nor_ move it to -staging.

In fact, this driver is quite cleanly written, follows all of the
various coding style rules we have, and uses the vast majority of the
kernel APIs properly.

And those are the criteria for having something in staging, not that
it has bugs.

In fact it is so cleanly written, that you should be able to read it
and figure out what the suspend/resume problem might be.  These are
exactly the kind of drivers we want to keep in the tree.

I'm sorry that your bugs didn't get fixed, but your response to that
happening is not reasonable at all.

[toc] | [next] | [standalone]

#1338827 — Re: [PATCH] jme: remove the jme driver as it is no longer maintained

On Sat, Feb 20, 2016 at 10:16 PM, David Miller <davem@davemloft.net> wrote:
>
> Sorry, this is not how things work.
>
> You can suggest marking the driver unmaintained in MAINTAINERS if the
> listed developer has been unresponsive for a very long time.
>
> But removing the driver altogether is not prudent at all.
>
> Just because it doesn't work %100 the way you like, and nobody
> has worked on fixing your specific problems, isn't a reason to
> remove an entire driver _nor_ move it to -staging.
>
> In fact, this driver is quite cleanly written, follows all of the
> various coding style rules we have, and uses the vast majority of the
> kernel APIs properly.
>
> And those are the criteria for having something in staging, not that
> it has bugs.
>
> In fact it is so cleanly written, that you should be able to read it
> and figure out what the suspend/resume problem might be.  These are
> exactly the kind of drivers we want to keep in the tree.
>
> I'm sorry that your bugs didn't get fixed, but your response to that
> happening is not reasonable at all.

OK my sincere apologies.

I've been very frustrated trying to deal with this bug and I couldn't
find a solution yet, but I will continue to see what I can do to fix
it.

I would appreciate some hint from someone who is more experienced with drivers.

Anyways, sorry about my behavior.

Diego

[toc] | [prev] | [next] | [standalone]

#1338851 — Re: [PATCH] jme: remove the jme driver as it is no longer maintained

On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes
<gnomes@lxorguk.ukuu.org.uk> wrote:
>> I would appreciate some hint from someone who is more experienced with drivers.
>
> Start by testing
>
> - loading the driver as a module
> - using the networking
> - unloading the module (and checking it stays unloaded!)
>
> then suspend/resume
>
> If that works then you have a good starting point because you know a
> sequence of actions that suspends properly. If it fails then it's going
> to be rather more fun because it implies something in the hardware has
> not been properly shut down.
>
> Alan

Hi Alan,

Thanks for your email, did you see my bug report? Because I tried all
this already.

The only workarounds I've found to work is one of these:

$ rmmod jme # before suspend

or

$ ip link set ens34 down

or

$ echo 0 > /sys/power/pm_async # disable async power management

Then resume works fine (I can't reproduce the hang).

I'm not a C developer nor a kernel developer, I tried looking at the
jme.c driver code but it's not clear what is broken and what needs
fixing, so I would appreciate someone more experienced looking at the
issue and giving me an idea or two.

Thanks,
Diego

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web