Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1331357 > unrolled thread

[PATCH] Bluetooth: hci_intel: Fix a wrong comparison

Started byAnton Protopopov <a.s.protopopov@gmail.com>
First post2016-02-10 18:30 +0100
Last post2016-02-20 02:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Bluetooth: hci_intel: Fix a wrong comparison Anton Protopopov <a.s.protopopov@gmail.com> - 2016-02-10 18:30 +0100
    Re: [PATCH] Bluetooth: hci_intel: Fix a wrong comparison Marcel Holtmann <marcel@holtmann.org> - 2016-02-20 02:00 +0100

#1331357 — [PATCH] Bluetooth: hci_intel: Fix a wrong comparison

FromAnton Protopopov <a.s.protopopov@gmail.com>
Date2016-02-10 18:30 +0100
Subject[PATCH] Bluetooth: hci_intel: Fix a wrong comparison
Message-ID<r0GKv-5hG-23@gated-at.bofh.it>
A return value of the intel_wait_booting() function compared with
a constant ETIMEDOUT instead of -ETIMEDOUT.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
 drivers/bluetooth/hci_intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_intel.c b/drivers/bluetooth/hci_intel.c
index 3d63ea3..91d6051 100644
--- a/drivers/bluetooth/hci_intel.c
+++ b/drivers/bluetooth/hci_intel.c
@@ -488,7 +488,7 @@ static int intel_set_baudrate(struct hci_uart *hu, unsigned int speed)
 	clear_bit(STATE_BOOTING, &intel->flags);
 
 	/* In case of timeout, try to continue anyway */
-	if (err && err != ETIMEDOUT)
+	if (err && err != -ETIMEDOUT)
 		return err;
 
 	bt_dev_info(hdev, "Change controller speed to %d", speed);
@@ -581,7 +581,7 @@ static int intel_setup(struct hci_uart *hu)
 	clear_bit(STATE_BOOTING, &intel->flags);
 
 	/* In case of timeout, try to continue anyway */
-	if (err && err != ETIMEDOUT)
+	if (err && err != -ETIMEDOUT)
 		return err;
 
 	set_bit(STATE_BOOTLOADER, &intel->flags);
-- 
2.6.5

[toc] | [next] | [standalone]


#1338591

FromMarcel Holtmann <marcel@holtmann.org>
Date2016-02-20 02:00 +0100
Message-ID<r443T-5hi-1@gated-at.bofh.it>
In reply to#1331357
Hi Anton,

> A return value of the intel_wait_booting() function compared with
> a constant ETIMEDOUT instead of -ETIMEDOUT.
> 
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
> drivers/bluetooth/hci_intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web