Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1331941 > unrolled thread
| Started by | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| First post | 2016-02-11 14:30 +0100 |
| Last post | 2016-02-21 19:40 +0100 |
| Articles | 8 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Linus Walleij <linus.walleij@linaro.org> - 2016-02-11 14:30 +0100
Re: [linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski <k@japko.eu> - 2016-02-15 09:10 +0100
Re: [linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Linus Walleij <linus.walleij@linaro.org> - 2016-02-15 10:20 +0100
[PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Krzysztof Adamski <krzysztof.adamski@tieto.com> - 2016-02-18 16:10 +0100
Re: [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Chen-Yu Tsai <wens@csie.org> - 2016-02-18 18:10 +0100
Re: [linux-sunxi] Re: [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Krzysztof Adamski <k@japko.eu> - 2016-02-18 20:50 +0100
[PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation Krzysztof Adamski <k@japko.eu> - 2016-02-18 21:00 +0100
Re: [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation Chen-Yu Tsai <wens@csie.org> - 2016-02-21 19:40 +0100
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-02-11 14:30 +0100 |
| Subject | Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support |
| Message-ID | <r0ZtN-VJ-17@gated-at.bofh.it> |
On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k@japko.eu> wrote: > H3 has additional PIO controller similar to what we can find on A23. > It's a 12 pin port, described in H3 Datasheet rev 1.1, pages 345-350. > > Signed-off-by: Krzysztof Adamski <k@japko.eu> Patch applied with Maxime's ACK. Yours, Linus Walleij
[toc] | [next] | [standalone]
| From | Krzysztof Adamski <k@japko.eu> |
|---|---|
| Date | 2016-02-15 09:10 +0100 |
| Subject | Re: [linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support |
| Message-ID | <r2moh-6Gr-1@gated-at.bofh.it> |
| In reply to | #1331941 |
On Thu, Feb 11, 2016 at 02:21:15PM +0100, Linus Walleij wrote: >On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k@japko.eu> wrote: > >> H3 has additional PIO controller similar to what we can find on A23. >> It's a 12 pin port, described in H3 Datasheet rev 1.1, pages 345-350. >> >> Signed-off-by: Krzysztof Adamski <k@japko.eu> > >Patch applied with Maxime's ACK. Hi Linus, You took v2 which does not add documentation for allwinner,sun8i-h3-r-pinctrl compatible that is added in this patch. This was fixed in v3. Should I prepare a patch for you that only adds this to the documentation or you can handle this by taking v3/v4 instead of this patch? Best regards, Krzysztof Adamski
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-02-15 10:20 +0100 |
| Subject | Re: [linux-sunxi] Re: [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support |
| Message-ID | <r2nu1-7kC-9@gated-at.bofh.it> |
| In reply to | #1334224 |
On Mon, Feb 15, 2016 at 9:08 AM, Krzysztof Adamski <k@japko.eu> wrote: > On Thu, Feb 11, 2016 at 02:21:15PM +0100, Linus Walleij wrote: >> >> On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k@japko.eu> wrote: >> >>> H3 has additional PIO controller similar to what we can find on A23. >>> It's a 12 pin port, described in H3 Datasheet rev 1.1, pages 345-350. >>> >>> Signed-off-by: Krzysztof Adamski <k@japko.eu> >> >> >> Patch applied with Maxime's ACK. > > > Hi Linus, > > You took v2 which does not add documentation for > allwinner,sun8i-h3-r-pinctrl compatible that is added in this patch. This > was fixed in v3. Should I prepare a patch for you that only adds this to the > documentation or you can handle this by taking v3/v4 instead of this patch? Ooops please send a fixup patch, I don't like to rebase the tree if possible. Sorry for the mess and thanks for your help. Yours, Linus Walleij
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Adamski <krzysztof.adamski@tieto.com> |
|---|---|
| Date | 2016-02-18 16:10 +0100 |
| Subject | [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation |
| Message-ID | <r3yno-7re-19@gated-at.bofh.it> |
| In reply to | #1334307 |
allwinner,sun8i-h3-apb0-gates-clk was added by
commit ba83a11104ae ("pinctrl: sunxi: Add H3 R_PIO controller support")
but the patch was missing proper binding documentation. This patch fixes
this issue.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
index c09f59b..37d0fd6 100644
--- a/Documentation/devicetree/bindings/clock/sunxi.txt
+++ b/Documentation/devicetree/bindings/clock/sunxi.txt
@@ -38,6 +38,7 @@ Required properties:
"allwinner,sun4i-a10-apb0-clk" - for the APB0 clock
"allwinner,sun6i-a31-apb0-clk" - for the APB0 clock on A31
"allwinner,sun8i-a23-apb0-clk" - for the APB0 clock on A23
+ "allwinner,sun8i-h3-apb0-gates-clk" - for the APB0 gates on H3
"allwinner,sun9i-a80-apb0-clk" - for the APB0 bus clock on A80
"allwinner,sun8i-a83t-apb0-gates-clk" - for the APB0 gates on A83T
"allwinner,sun4i-a10-apb0-gates-clk" - for the APB0 gates on A10
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2016-02-18 18:10 +0100 |
| Subject | Re: [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation |
| Message-ID | <r3Afx-lQ-23@gated-at.bofh.it> |
| In reply to | #1337445 |
On Thu, Feb 18, 2016 at 7:03 AM, Krzysztof Adamski
<krzysztof.adamski@tieto.com> wrote:
> allwinner,sun8i-h3-apb0-gates-clk was added by
> commit ba83a11104ae ("pinctrl: sunxi: Add H3 R_PIO controller support")
> but the patch was missing proper binding documentation. This patch fixes
> this issue.
What are you talking about? The commit you mentioned only adds the pinctrl
driver. Your H3 PRCM related clock and reset patches are still pending.
No need for this patch as your earlier patches includes this.
ChenYu
>
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
> ---
> Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> index c09f59b..37d0fd6 100644
> --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> @@ -38,6 +38,7 @@ Required properties:
> "allwinner,sun4i-a10-apb0-clk" - for the APB0 clock
> "allwinner,sun6i-a31-apb0-clk" - for the APB0 clock on A31
> "allwinner,sun8i-a23-apb0-clk" - for the APB0 clock on A23
> + "allwinner,sun8i-h3-apb0-gates-clk" - for the APB0 gates on H3
> "allwinner,sun9i-a80-apb0-clk" - for the APB0 bus clock on A80
> "allwinner,sun8i-a83t-apb0-gates-clk" - for the APB0 gates on A83T
> "allwinner,sun4i-a10-apb0-gates-clk" - for the APB0 gates on A10
> --
> 2.1.4
>
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Adamski <k@japko.eu> |
|---|---|
| Date | 2016-02-18 20:50 +0100 |
| Subject | Re: [linux-sunxi] Re: [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation |
| Message-ID | <r3CKm-23z-25@gated-at.bofh.it> |
| In reply to | #1337541 |
On Thu, Feb 18, 2016 at 09:07:16AM -0800, Chen-Yu Tsai wrote:
>On Thu, Feb 18, 2016 at 7:03 AM, Krzysztof Adamski
><krzysztof.adamski@tieto.com> wrote:
>> allwinner,sun8i-h3-apb0-gates-clk was added by
>> commit ba83a11104ae ("pinctrl: sunxi: Add H3 R_PIO controller support")
>> but the patch was missing proper binding documentation. This patch fixes
>> this issue.
>
>What are you talking about? The commit you mentioned only adds the pinctrl
>driver. Your H3 PRCM related clock and reset patches are still pending.
>No need for this patch as your earlier patches includes this.
Damn, I messed up patches, I must have been tired or something. It was
documentation for "allwinner,sun8i-h3-r-pinctrl" that was missing. I'm
sending a new patch. Sorry for confusion.
Best regards,
Krzysztof Adamski
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Adamski <k@japko.eu> |
|---|---|
| Date | 2016-02-18 21:00 +0100 |
| Subject | [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation |
| Message-ID | <r3CU2-27a-9@gated-at.bofh.it> |
| In reply to | #1334307 |
allwinner,sun8i-h3-r-pinctrl was added by
commit ba83a11104ae ("pinctrl: sunxi: Add H3 R_PIO controller support")
but the patch was missing proper binding documentation. This patch fixes
this issue.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
index 9213b27..3e56b16 100644
--- a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt
@@ -21,6 +21,7 @@ Required properties:
"allwinner,sun9i-a80-r-pinctrl"
"allwinner,sun8i-a83t-pinctrl"
"allwinner,sun8i-h3-pinctrl"
+ "allwinner,sun8i-h3-r-pinctrl"
- reg: Should contain the register physical address and length for the
pin controller.
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2016-02-21 19:40 +0100 |
| Subject | Re: [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation |
| Message-ID | <r4H5g-1GU-1@gated-at.bofh.it> |
| In reply to | #1337643 |
On Thu, Feb 18, 2016 at 11:49 AM, Krzysztof Adamski <k@japko.eu> wrote:
> allwinner,sun8i-h3-r-pinctrl was added by
> commit ba83a11104ae ("pinctrl: sunxi: Add H3 R_PIO controller support")
> but the patch was missing proper binding documentation. This patch fixes
> this issue.
>
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
Acked-by: Chen-Yu Tsai <wens@csie.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web