Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337360 > unrolled thread

[PATCH] PCI: mvebu: Restrict build to 32-bit ARM

Started byThierry Reding <thierry.reding@gmail.com>
First post2016-02-18 14:40 +0100
Last post2016-02-18 15:40 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Thierry Reding <thierry.reding@gmail.com> - 2016-02-18 14:40 +0100
    Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Arnd Bergmann <arnd@arndb.de> - 2016-02-18 15:10 +0100
      Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Thierry Reding <thierry.reding@gmail.com> - 2016-02-18 15:30 +0100
      Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-18 15:40 +0100
        Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Arnd Bergmann <arnd@arndb.de> - 2016-02-18 15:50 +0100
    Re: [PATCH] PCI: mvebu: Restrict build to 32-bit ARM Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-18 15:40 +0100

#1337360 — [PATCH] PCI: mvebu: Restrict build to 32-bit ARM

FromThierry Reding <thierry.reding@gmail.com>
Date2016-02-18 14:40 +0100
Subject[PATCH] PCI: mvebu: Restrict build to 32-bit ARM
Message-ID<r3wYj-6bc-11@gated-at.bofh.it>
From: Thierry Reding <treding@nvidia.com>

This driver uses PCI glue that is only available on 32-bit ARM. This
used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
32-bit, but that's changed now, with ARCH_MVEBU also being available
on 64-bit ARM.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/pci/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 75a605426538..d1cdd9c992ac 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -14,6 +14,7 @@ config PCI_DRA7XX
 config PCI_MVEBU
 	bool "Marvell EBU PCIe controller"
 	depends on ARCH_MVEBU || ARCH_DOVE
+	depends on ARM
 	depends on OF
 
 config PCIE_DW
-- 
2.7.1

[toc] | [next] | [standalone]

#1337378

FromArnd Bergmann <arnd@arndb.de>
Date2016-02-18 15:10 +0100
Message-ID<r3xrm-6Oj-33@gated-at.bofh.it>
In reply to#1337360
On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Looks fine as a temporary workaround, but I think what we really want to
do here is to remove the dependency, as the new ARM64 platforms are going
to need this driver anyway.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1337395

FromThierry Reding <thierry.reding@gmail.com>
Date2016-02-18 15:30 +0100
Message-ID<r3xKH-6WT-27@gated-at.bofh.it>
In reply to#1337378

[Multipart message — attachments visible in raw view] — view raw

On Thu, Feb 18, 2016 at 03:06:23PM +0100, Arnd Bergmann wrote:
> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > This driver uses PCI glue that is only available on 32-bit ARM. This
> > used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> > 32-bit, but that's changed now, with ARCH_MVEBU also being available
> > on 64-bit ARM.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.

Agreed. I've been meaning to do just that for Tegra as well, but the
conversion is somewhat more involved and this is currently breaking the
linux-next builds, so a quick fix, even if temporary, is warranted in my
opinion.

Thierry

[toc] | [prev] | [next] | [standalone]

#1337400

FromGregory CLEMENT <gregory.clement@free-electrons.com>
Date2016-02-18 15:40 +0100
Message-ID<r3xUl-716-1@gated-at.bofh.it>
In reply to#1337378
Hi Arnd,
 
 On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:

> On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>> 
>> This driver uses PCI glue that is only available on 32-bit ARM. This
>> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
>> 32-bit, but that's changed now, with ARCH_MVEBU also being available
>> on 64-bit ARM.
>> 
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> Looks fine as a temporary workaround, but I think what we really want to
> do here is to remove the dependency, as the new ARM64 platforms are going
> to need this driver anyway.

Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
8K), won't use the same controller. A7K/A8K will use a synopsis IP and
Armada 3700 a new Marvell IP.

So for me depending on ARM32 is enough.

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1337427

FromArnd Bergmann <arnd@arndb.de>
Date2016-02-18 15:50 +0100
Message-ID<r3y42-74z-11@gated-at.bofh.it>
In reply to#1337400
On Thursday 18 February 2016 15:34:30 Gregory CLEMENT wrote:
>  On jeu., févr. 18 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > On Thursday 18 February 2016 14:32:10 Thierry Reding wrote:
> >> From: Thierry Reding <treding@nvidia.com>
> >> 
> >> This driver uses PCI glue that is only available on 32-bit ARM. This
> >> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> >> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> >> on 64-bit ARM.
> >> 
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >
> > Looks fine as a temporary workaround, but I think what we really want to
> > do here is to remove the dependency, as the new ARM64 platforms are going
> > to need this driver anyway.
> 
> Actually the mvebu ARM64 platform we know about (Armada 3700, 7K and
> 8K), won't use the same controller. A7K/A8K will use a synopsis IP and
> Armada 3700 a new Marvell IP.
> 
> So for me depending on ARM32 is enough.

Ah, that makes things much easier indeed.

Does this mean no more MBUS on the 64-bit platforms too?

	Arnd

[toc] | [prev] | [next] | [standalone]

#1337411

FromThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date2016-02-18 15:40 +0100
Message-ID<r3xUm-716-25@gated-at.bofh.it>
In reply to#1337360
Hello,

On Thu, 18 Feb 2016 14:32:10 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This driver uses PCI glue that is only available on 32-bit ARM. This
> used to work fine as long as ARCH_MVEBU and ARCH_DOVE were exclusively
> 32-bit, but that's changed now, with ARCH_MVEBU also being available
> on 64-bit ARM.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web