Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336206 > unrolled thread

[PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

Back to article view | Back to linux.kernel

Contents

  [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko <oleksandr@natalenko.name> - 2016-02-17 11:20 +0100
    Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2016-02-17 11:40 +0100
      Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Darren Hart <dvhart@infradead.org> - 2016-02-18 06:40 +0100
    Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Darren Hart <dvhart@infradead.org> - 2016-02-18 06:30 +0100

#1336206 — [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
is loaded with wapf=4 option. Add quirk for this.
---
  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/asus-nb-wmi.c 
b/drivers/platform/x86/asus-nb-wmi.c
index 131fee2..091ca7a 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -272,6 +272,15 @@ static const struct dmi_system_id asus_quirks[] = {
  	},
  	{
  		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X75VD",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X75VD"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
  		.ident = "ASUSTeK COMPUTER INC. 1015E",
  		.matches = {
  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
-- 
2.7.1

[toc] | [next] | [standalone]

#1336239

On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> is loaded with wapf=4 option. Add quirk for this.
> ---

You forgot Signed-off-by here. Always run your patch through
scripts/checkpatch.pl. Also, I think the format is usually
[PATCH RESEND vX AA/BB] and not [PATCH][RESEND].

--
        Giedrius

[toc] | [prev] | [next] | [standalone]

#1337058

On Wed, Feb 17, 2016 at 12:37:38PM +0200, Giedrius Statkevičius wrote:
> On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> > is loaded with wapf=4 option. Add quirk for this.
> > ---
> 
> You forgot Signed-off-by here. Always run your patch through
> scripts/checkpatch.pl. Also, I think the format is usually
> [PATCH RESEND vX AA/BB] and not [PATCH][RESEND].

RESEND means it's identical. v2 means there was a change. The change should be
noted below the --- line. See Documentation/SubmittingPatches Section 14.

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1337043

On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote:
> Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> is loaded with wapf=4 option. Add quirk for this.

Point of terminology. It is not a RESEND if you made changes, even whitespace,
it's v2, v3, etc. RESEND means it's identical to the previous one, but it's been
a long time (2 weeks) and nobody responded with a review.

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web