Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334950 > unrolled thread

[PATCH] et131x: check return value of dma_alloc_coherent

Back to article view | Back to linux.kernel

Contents

  [PATCH] et131x: check return value of dma_alloc_coherent Insu Yun <wuninsu@gmail.com> - 2016-02-16 03:30 +0100
    Re: [PATCH] et131x: check return value of dma_alloc_coherent David Miller <davem@davemloft.net> - 2016-02-18 05:40 +0100

#1334950 — [PATCH] et131x: check return value of dma_alloc_coherent

For error handling, dma_alloc_coherent's return value
needs to be checked, not argument.

Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
 drivers/net/ethernet/agere/et131x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
index 3f3bcbe..0907ab6 100644
--- a/drivers/net/ethernet/agere/et131x.c
+++ b/drivers/net/ethernet/agere/et131x.c
@@ -2380,7 +2380,7 @@ static int et131x_tx_dma_memory_alloc(struct et131x_adapter *adapter)
 						    sizeof(u32),
 						    &tx_ring->tx_status_pa,
 						    GFP_KERNEL);
-	if (!tx_ring->tx_status_pa) {
+	if (!tx_ring->tx_status) {
 		dev_err(&adapter->pdev->dev,
 			"Cannot alloc memory for Tx status block\n");
 		return -ENOMEM;
-- 
1.9.1

[toc] | [next] | [standalone]

#1337021

From: Insu Yun <wuninsu@gmail.com>
Date: Mon, 15 Feb 2016 21:23:47 -0500

> For error handling, dma_alloc_coherent's return value
> needs to be checked, not argument.
> 
> Signed-off-by: Insu Yun <wuninsu@gmail.com>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web