Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336896 > unrolled thread

[PATCH] net: phy: dp83848: Fix sysfs naming collision warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: phy: dp83848: Fix sysfs naming collision warning "Andrew F. Davis" <afd@ti.com> - 2016-02-18 01:20 +0100
    Re: [PATCH] net: phy: dp83848: Fix sysfs naming collision warning David Miller <davem@davemloft.net> - 2016-02-18 22:00 +0100

#1336896 — [PATCH] net: phy: dp83848: Fix sysfs naming collision warning

Files in sysfs are created using the name from the phy_driver struct,
when two names are the same we may get a duplicate filename warning,
fix this.

Reported-by: kernel test robot <ying.huang@linux.intel.com>
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 drivers/net/phy/dp83848.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 556904f..03d54c4 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -103,7 +103,7 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
 
 static struct phy_driver dp83848_driver[] = {
 	DP83848_PHY_DRIVER(TI_DP83848C_PHY_ID, "TI DP83848C 10/100 Mbps PHY"),
-	DP83848_PHY_DRIVER(NS_DP83848C_PHY_ID, "TI DP83848C 10/100 Mbps PHY"),
+	DP83848_PHY_DRIVER(NS_DP83848C_PHY_ID, "NS DP83848C 10/100 Mbps PHY"),
 	DP83848_PHY_DRIVER(TLK10X_PHY_ID, "TI TLK10X 10/100 Mbps PHY"),
 };
 module_phy_driver(dp83848_driver);
-- 
2.7.1

[toc] | [next] | [standalone]

#1337734

From: "Andrew F. Davis" <afd@ti.com>
Date: Wed, 17 Feb 2016 18:10:00 -0600

> Files in sysfs are created using the name from the phy_driver struct,
> when two names are the same we may get a duplicate filename warning,
> fix this.
> 
> Reported-by: kernel test robot <ying.huang@linux.intel.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web