Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336875 > unrolled thread

[PATCH] scripts/coccinelle: modernize &

Started byJulia Lawall <Julia.Lawall@lip6.fr>
First post2016-02-18 00:40 +0100
Last post2016-02-19 13:30 +0100
Articles 5 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] scripts/coccinelle: modernize & Julia Lawall <Julia.Lawall@lip6.fr> - 2016-02-18 00:40 +0100
    Re: [PATCH] scripts/coccinelle: modernize & Nishanth Menon <nm@ti.com> - 2016-02-18 00:50 +0100
      Re: [PATCH] scripts/coccinelle: modernize & Julia Lawall <julia.lawall@lip6.fr> - 2016-02-18 01:50 +0100
      Re: [PATCH] scripts/coccinelle: modernize & Michal Marek <mmarek@suse.com> - 2016-02-19 14:10 +0100
    Re: [PATCH] scripts/coccinelle: modernize & SF Markus Elfring <elfring@users.sourceforge.net> - 2016-02-19 13:30 +0100

#1336875 — [PATCH] scripts/coccinelle: modernize &

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2016-02-18 00:40 +0100
Subject[PATCH] scripts/coccinelle: modernize &
Message-ID<r3jRo-59z-5@gated-at.bofh.it>
& is no longer allowed in column 0, since Coccinelle 1.0.4.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
index f085f59..ce8cc9c 100644
--- a/scripts/coccinelle/iterators/use_after_iter.cocci
+++ b/scripts/coccinelle/iterators/use_after_iter.cocci
@@ -123,7 +123,7 @@ list_remove_head(x,c,...)
 |
 sizeof(<+...c...+>)
 |
-&c->member
+ &c->member
 |
 c = E
 |

[toc] | [next] | [standalone]

#1336889

FromNishanth Menon <nm@ti.com>
Date2016-02-18 00:50 +0100
Message-ID<r3k14-5dZ-17@gated-at.bofh.it>
In reply to#1336875
On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member
>  |
>  c = E
>  |
> 


Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0


Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

[toc] | [prev] | [next] | [standalone]

#1336908

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-02-18 01:50 +0100
Message-ID<r3kX8-5Re-23@gated-at.bofh.it>
In reply to#1336889
On Wed, 17 Feb 2016, Nishanth Menon wrote:

> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >  scripts/coccinelle/iterators/use_after_iter.cocci |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > -&c->member
> > + &c->member
> >  |
> >  c = E
> >  |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon <nm@ti.com>

Thanks!

julia

[toc] | [prev] | [next] | [standalone]

#1338172

FromMichal Marek <mmarek@suse.com>
Date2016-02-19 14:10 +0100
Message-ID<r3SYO-5z8-21@gated-at.bofh.it>
In reply to#1336889
On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
> 
> 
> Tested-by: Nishanth Menon <nm@ti.com>

Applied to kbuild.git#misc with Cc: stable.

Michal

[toc] | [prev] | [next] | [standalone]

#1338157

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-02-19 13:30 +0100
Message-ID<r3Sm6-52G-5@gated-at.bofh.it>
In reply to#1336875
> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web