Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1336838 > unrolled thread

[PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters

Started byAndi Kleen <andi@firstfloor.org>
First post2016-02-17 23:50 +0100
Last post2016-02-20 12:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters Andi Kleen <andi@firstfloor.org> - 2016-02-17 23:50 +0100
    [tip:perf/core] perf stat: Handled scaled == -1 case for counters tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-02-20 12:40 +0100

#1336838 — [PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters

FromAndi Kleen <andi@firstfloor.org>
Date2016-02-17 23:50 +0100
Subject[PATCH 1/6] perf, tools, stat: Handled scaled == -1 case for counters
Message-ID<r3j50-4A2-23@gated-at.bofh.it>
From: Andi Kleen <ak@linux.intel.com>

Arnaldo pointed out that the earlier
"Move noise/running printing into printout"
change changed behavior for not counted counters. This patch fixes it again.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 15e4fcf..86289df 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -860,7 +860,7 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
 
 	nl = new_line_std;
 
-	if (run == 0 || ena == 0) {
+	if (run == 0 || ena == 0 || counter->counts->scaled == -1) {
 		aggr_printout(counter, id, nr);
 
 		fprintf(stat_config.output, "%*s%s",
-- 
2.5.0

[toc] | [next] | [standalone]


#1338700 — [tip:perf/core] perf stat: Handled scaled == -1 case for counters

Fromtip-bot for Andi Kleen <tipbot@zytor.com>
Date2016-02-20 12:40 +0100
Subject[tip:perf/core] perf stat: Handled scaled == -1 case for counters
Message-ID<r4e3i-4EY-53@gated-at.bofh.it>
In reply to#1336838
Commit-ID:  b002f3bbd321993c1a6d56b86544065420156ab9
Gitweb:     http://git.kernel.org/tip/b002f3bbd321993c1a6d56b86544065420156ab9
Author:     Andi Kleen <ak@linux.intel.com>
AuthorDate: Wed, 17 Feb 2016 14:44:00 -0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 19 Feb 2016 19:12:45 -0300

perf stat: Handled scaled == -1 case for counters

Arnaldo pointed out that the earlier cb110f471025 ("perf stat: Move
noise/running printing into printout") change changed behavior for not
counted counters. This patch fixes it again.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Fixes: cb110f471025 ("perf stat: Move noise/running printing into printout")
Link: http://lkml.kernel.org/r/1455749045-18098-2-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 15e4fcf..86289df 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -860,7 +860,7 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
 
 	nl = new_line_std;
 
-	if (run == 0 || ena == 0) {
+	if (run == 0 || ena == 0 || counter->counts->scaled == -1) {
 		aggr_printout(counter, id, nr);
 
 		fprintf(stat_config.output, "%*s%s",

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web