Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334314 > unrolled thread

[PATCH] iio: health/afe4404: mark suspend/resume functions __maybe_unused

Back to article view | Back to linux.kernel

Contents

  [PATCH] iio: health/afe4404: mark suspend/resume functions __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-02-15 10:30 +0100
    Re: [PATCH] iio: health/afe4404: mark suspend/resume functions  __maybe_unused Jonathan Cameron <jic23@kernel.org> - 2016-02-17 20:40 +0100

#1334314 — [PATCH] iio: health/afe4404: mark suspend/resume functions __maybe_unused

The newly added afe4404 driver implements suspend/resume using the
SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual
functions when CONFIG_PM is disabled, causing a harmless warning:

health/afe4404.c:509:12: error: 'afe4404_suspend' defined but not used
health/afe4404.c:530:12: error: 'afe4404_resume' defined but not used

This marks the functions as __maybe_unused so we don't get those
warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
---
 drivers/iio/health/afe4404.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
index 0759268f37e0..5096a4643784 100644
--- a/drivers/iio/health/afe4404.c
+++ b/drivers/iio/health/afe4404.c
@@ -477,7 +477,7 @@ static const struct of_device_id afe4404_of_match[] = {
 MODULE_DEVICE_TABLE(of, afe4404_of_match);
 #endif
 
-static int afe4404_suspend(struct device *dev)
+static int __maybe_unused afe4404_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct afe4404_data *afe = iio_priv(indio_dev);
@@ -498,7 +498,7 @@ static int afe4404_suspend(struct device *dev)
 	return 0;
 }
 
-static int afe4404_resume(struct device *dev)
+static int __maybe_unused afe4404_resume(struct device *dev)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct afe4404_data *afe = iio_priv(indio_dev);
-- 
2.7.0

[toc] | [next] | [standalone]

#1336704 — Re: [PATCH] iio: health/afe4404: mark suspend/resume functions __maybe_unused

On 15/02/16 09:19, Arnd Bergmann wrote:
> The newly added afe4404 driver implements suspend/resume using the
> SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual
> functions when CONFIG_PM is disabled, causing a harmless warning:
> 
> health/afe4404.c:509:12: error: 'afe4404_suspend' defined but not used
> health/afe4404.c:530:12: error: 'afe4404_resume' defined but not used
> 
> This marks the functions as __maybe_unused so we don't get those
> warnings.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/health/afe4404.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
> index 0759268f37e0..5096a4643784 100644
> --- a/drivers/iio/health/afe4404.c
> +++ b/drivers/iio/health/afe4404.c
> @@ -477,7 +477,7 @@ static const struct of_device_id afe4404_of_match[] = {
>  MODULE_DEVICE_TABLE(of, afe4404_of_match);
>  #endif
>  
> -static int afe4404_suspend(struct device *dev)
> +static int __maybe_unused afe4404_suspend(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct afe4404_data *afe = iio_priv(indio_dev);
> @@ -498,7 +498,7 @@ static int afe4404_suspend(struct device *dev)
>  	return 0;
>  }
>  
> -static int afe4404_resume(struct device *dev)
> +static int __maybe_unused afe4404_resume(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct afe4404_data *afe = iio_priv(indio_dev);
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web