Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338165 > unrolled thread

[PATCH 0/3] LightNVM patches for next 4.5-rc

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] LightNVM patches for next 4.5-rc Matias Bjørling <m@bjorling.me> - 2016-02-19 14:00 +0100
    Re: [PATCH 0/3] LightNVM patches for next 4.5-rc Jens Axboe <axboe@kernel.dk> - 2016-02-19 20:20 +0100
      Re: [PATCH 0/3] LightNVM patches for next 4.5-rc Jens Axboe <axboe@kernel.dk> - 2016-02-20 04:50 +0100

#1338165 — [PATCH 0/3] LightNVM patches for next 4.5-rc

Hi Jens,

Here is a couple of patches for the next 4.5-rc.

A patch from Alan that fixes up logic in nvm_configure_get. Another
patch from Javier that fixes a bug with multiple luns in RRPC, and at
last a patch from me that fixes the get bad block interface when
multiple planes are available on the media.

Please pick up when convenient.

Thanks,
Matias

Alan (1):
  lightnvm: fix up nonsensical configure overrun checking

Javier González (1):
  lightnvm: generalize rrpc ppa calculations

Matias Bjørling (1):
  lightnvm: fold get bb tbl when using dual/quad plane mode

 drivers/lightnvm/core.c      | 13 ++++++------
 drivers/lightnvm/rrpc.c      | 48 ++++++++++++++++++++++++++++----------------
 drivers/lightnvm/rrpc.h      |  9 +++++++++
 drivers/nvme/host/lightnvm.c | 46 +++++++++++++++++++++++++++++++++++++-----
 include/linux/lightnvm.h     |  6 +++---
 5 files changed, 90 insertions(+), 32 deletions(-)

-- 
2.1.4

[toc] | [next] | [standalone]

#1338417

On Fri, Feb 19 2016, Matias Bjørling wrote:
> Hi Jens,
> 
> Here is a couple of patches for the next 4.5-rc.
> 
> A patch from Alan that fixes up logic in nvm_configure_get. Another
> patch from Javier that fixes a bug with multiple luns in RRPC, and at
> last a patch from me that fixes the get bad block interface when
> multiple planes are available on the media.

Applied, but you need to update your patch base, patch #3 needed to be
hand applied because your repo does not have the below applied.

commit ff0e498bfa185fad5e86c4c7a2db4f9648d2344f
Author: Javier González <jg@lightnvm.io>
Date:   Tue Jan 12 07:49:33 2016 +0100

    lightnvm: manage open and closed blocks separately

-- 
Jens Axboe

[toc] | [prev] | [next] | [standalone]

#1338627

On 02/19/2016 12:15 PM, Jens Axboe wrote:
> On Fri, Feb 19 2016, Matias Bjørling wrote:
>> Hi Jens,
>>
>> Here is a couple of patches for the next 4.5-rc.
>>
>> A patch from Alan that fixes up logic in nvm_configure_get. Another
>> patch from Javier that fixes a bug with multiple luns in RRPC, and at
>> last a patch from me that fixes the get bad block interface when
>> multiple planes are available on the media.
>
> Applied, but you need to update your patch base, patch #3 needed to be
> hand applied because your repo does not have the below applied.
>
> commit ff0e498bfa185fad5e86c4c7a2db4f9648d2344f
> Author: Javier González <jg@lightnvm.io>
> Date:   Tue Jan 12 07:49:33 2016 +0100
>
>      lightnvm: manage open and closed blocks separately

And even after that, it's broken:

drivers/lightnvm/rrpc.c: In function ‘rrpc_l2p_update’:
drivers/lightnvm/rrpc.c:1047:24: error: ‘struct rrpc’ has no member 
named ‘nr_sects’
    div_u64_rem(pba, rrpc->nr_sects, &mod);
                         ^
I've dropped that patch. You need to step it up, that's way too lax for 
something destined for the current series at -rc4 time.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web