Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1335983 > unrolled thread
| Started by | Nicolas Boichat <drinkcat@chromium.org> |
|---|---|
| First post | 2016-02-17 02:40 +0100 |
| Last post | 2016-02-21 00:50 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE Nicolas Boichat <drinkcat@chromium.org> - 2016-02-17 02:40 +0100
Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-19 11:00 +0100
Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE Olof Johansson <olof@lixom.net> - 2016-02-19 16:10 +0100
Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-21 00:50 +0100
| From | Nicolas Boichat <drinkcat@chromium.org> |
|---|---|
| Date | 2016-02-17 02:40 +0100 |
| Subject | [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE |
| Message-ID | <r2ZfY-7xT-3@gated-at.bofh.it> |
From: Lisa Du <cldu@marvell.com>
There's one point was missed in the patch commit da49889deb34 ("staging:
binder: Support concurrent 32 bit and 64 bit processes."). When configure
BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of
void * is 64bit on 64bit system. Correct it here.
Signed-off-by: Lisa Du <cldu@marvell.com>
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
This patch was first sent upstream here: https://lkml.org/lkml/2015/5/28/747,
but was not picked up (probably because it was part of a bigger series that
refactored binder).
This patch fixes issues when using 64-bit binder API on 32-bit kernels.
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 796301a..16288e7 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2081,7 +2081,7 @@ static int binder_thread_write(struct binder_proc *proc,
if (get_user(cookie, (binder_uintptr_t __user *)ptr))
return -EFAULT;
- ptr += sizeof(void *);
+ ptr += sizeof(cookie);
list_for_each_entry(w, &proc->delivered_death, entry) {
struct binder_ref_death *tmp_death = container_of(w, struct binder_ref_death, work);
--
2.7.0.rc3.207.g0ac5344
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-02-19 11:00 +0100 |
| Subject | Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE |
| Message-ID | <r3Q0W-37f-7@gated-at.bofh.it> |
| In reply to | #1335983 |
On Wed, Feb 17, 2016 at 09:32:52AM +0800, Nicolas Boichat wrote: > This patch was first sent upstream here: https://lkml.org/lkml/2015/5/28/747, > but was not picked up (probably because it was part of a bigger series that > refactored binder). Riley was supposed to resend it with a proper sign off but he must have lost track. Anyway, thanks for doing follow up on this. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Olof Johansson <olof@lixom.net> |
|---|---|
| Date | 2016-02-19 16:10 +0100 |
| Subject | Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE |
| Message-ID | <r3UQW-6RV-37@gated-at.bofh.it> |
| In reply to | #1335983 |
Hi,
On Tue, Feb 16, 2016 at 5:32 PM, Nicolas Boichat <drinkcat@chromium.org> wrote:
> From: Lisa Du <cldu@marvell.com>
>
> There's one point was missed in the patch commit da49889deb34 ("staging:
> binder: Support concurrent 32 bit and 64 bit processes."). When configure
> BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of
> void * is 64bit on 64bit system. Correct it here.
>
> Signed-off-by: Lisa Du <cldu@marvell.com>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Fixes: da49889deb34 ("staging: binder: Support concurrent 32 bit and
64 bit processes.")
Cc: <stable@vger.kernel.org>
Acked-by: Olof Johansson <olof@lixom.net>
(Hopefully Greg's script adds all 3 tags when he applies the patch. :)
-Olof
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-02-21 00:50 +0100 |
| Subject | Re: [RESEND PATCH] drivers: android: correct the size of struct binder_uintptr_t for BC_DEAD_BINDER_DONE |
| Message-ID | <r4prI-5gp-1@gated-at.bofh.it> |
| In reply to | #1338278 |
On Fri, Feb 19, 2016 at 07:08:40AM -0800, Olof Johansson wrote:
> Hi,
>
> On Tue, Feb 16, 2016 at 5:32 PM, Nicolas Boichat <drinkcat@chromium.org> wrote:
> > From: Lisa Du <cldu@marvell.com>
> >
> > There's one point was missed in the patch commit da49889deb34 ("staging:
> > binder: Support concurrent 32 bit and 64 bit processes."). When configure
> > BINDER_IPC_32BIT, the size of binder_uintptr_t was 32bits, but size of
> > void * is 64bit on 64bit system. Correct it here.
> >
> > Signed-off-by: Lisa Du <cldu@marvell.com>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Fixes: da49889deb34 ("staging: binder: Support concurrent 32 bit and
> 64 bit processes.")
> Cc: <stable@vger.kernel.org>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> (Hopefully Greg's script adds all 3 tags when he applies the patch. :)
Now added, thanks.
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web